From: "Heiko Stübner" <heiko@sntech.de>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Douglas Anderson <dianders@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
jwerner@chromium.org, hl@rock-chips.com, dbasehore@chromium.org,
zhengxing@rock-chips.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: rockchip: Set "ignore unused" for PMU M0 clocks on rk3399
Date: Wed, 15 Feb 2017 18:01:25 +0100 [thread overview]
Message-ID: <1716357.fXUCSFMPB6@diego> (raw)
In-Reply-To: <CABxcv=kzW9SvrWYNasqCDkV7D6Y2zq+oRuqoPFdWuaWUhPehEA@mail.gmail.com>
Am Mittwoch, 15. Februar 2017, 12:27:59 CET schrieb Javier Martinez Canillas:
> Hello Doug,
>
> On Tue, Feb 14, 2017 at 6:01 PM, Douglas Anderson <dianders@chromium.org>
wrote:
> > The PMU Cortex M0 on rk3399 is intended to be used for things like
> > DDRFreq transitions, suspend/resume, and other things that are the
> > purview of ARM Trusted Firmware and not the kernel. As such, the
> > kernel shouldn't be messing with the clocks. Add CLK_IGNORE_UNUSED to
> > these clocks.
>
> Isn't CLK_IS_CRITICAL a more suitable flag for this case?
>From the patch description it looks like the clock is expected to be
controlled from firmware in most cases as I guess the Cortex M0 will be used
for that all the time now. And the clock is not expected to run all the time.
So I'd think clk_ignore_unused is the correct one. The whole clock-subtree for
these clocks also does not get affected by other clocks, as it is
independendly coming from PLLs.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Javier Martinez Canillas <javier@dowhile0.org>
Cc: Douglas Anderson <dianders@chromium.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
jwerner@chromium.org, hl@rock-chips.com, dbasehore@chromium.org,
zhengxing@rock-chips.com,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
linux-clk@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clk: rockchip: Set "ignore unused" for PMU M0 clocks on rk3399
Date: Wed, 15 Feb 2017 18:01:25 +0100 [thread overview]
Message-ID: <1716357.fXUCSFMPB6@diego> (raw)
In-Reply-To: <CABxcv=kzW9SvrWYNasqCDkV7D6Y2zq+oRuqoPFdWuaWUhPehEA@mail.gmail.com>
Am Mittwoch, 15. Februar 2017, 12:27:59 CET schrieb Javier Martinez Canillas:
> Hello Doug,
>
> On Tue, Feb 14, 2017 at 6:01 PM, Douglas Anderson <dianders@chromium.org>
wrote:
> > The PMU Cortex M0 on rk3399 is intended to be used for things like
> > DDRFreq transitions, suspend/resume, and other things that are the
> > purview of ARM Trusted Firmware and not the kernel. As such, the
> > kernel shouldn't be messing with the clocks. Add CLK_IGNORE_UNUSED to
> > these clocks.
>
> Isn't CLK_IS_CRITICAL a more suitable flag for this case?
From the patch description it looks like the clock is expected to be
controlled from firmware in most cases as I guess the Cortex M0 will be used
for that all the time now. And the clock is not expected to run all the time.
So I'd think clk_ignore_unused is the correct one. The whole clock-subtree for
these clocks also does not get affected by other clocks, as it is
independendly coming from PLLs.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: Set "ignore unused" for PMU M0 clocks on rk3399
Date: Wed, 15 Feb 2017 18:01:25 +0100 [thread overview]
Message-ID: <1716357.fXUCSFMPB6@diego> (raw)
In-Reply-To: <CABxcv=kzW9SvrWYNasqCDkV7D6Y2zq+oRuqoPFdWuaWUhPehEA@mail.gmail.com>
Am Mittwoch, 15. Februar 2017, 12:27:59 CET schrieb Javier Martinez Canillas:
> Hello Doug,
>
> On Tue, Feb 14, 2017 at 6:01 PM, Douglas Anderson <dianders@chromium.org>
wrote:
> > The PMU Cortex M0 on rk3399 is intended to be used for things like
> > DDRFreq transitions, suspend/resume, and other things that are the
> > purview of ARM Trusted Firmware and not the kernel. As such, the
> > kernel shouldn't be messing with the clocks. Add CLK_IGNORE_UNUSED to
> > these clocks.
>
> Isn't CLK_IS_CRITICAL a more suitable flag for this case?
>From the patch description it looks like the clock is expected to be
controlled from firmware in most cases as I guess the Cortex M0 will be used
for that all the time now. And the clock is not expected to run all the time.
So I'd think clk_ignore_unused is the correct one. The whole clock-subtree for
these clocks also does not get affected by other clocks, as it is
independendly coming from PLLs.
Heiko
next prev parent reply other threads:[~2017-02-15 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 21:01 [PATCH] clk: rockchip: Set "ignore unused" for PMU M0 clocks on rk3399 Douglas Anderson
2017-02-14 21:01 ` Douglas Anderson
2017-02-15 15:27 ` Javier Martinez Canillas
2017-02-15 15:27 ` Javier Martinez Canillas
2017-02-15 16:46 ` Doug Anderson
2017-02-15 16:46 ` Doug Anderson
2017-02-15 17:01 ` Heiko Stübner [this message]
2017-02-15 17:01 ` Heiko Stübner
2017-02-15 17:01 ` Heiko Stübner
2017-02-15 17:06 ` Javier Martinez Canillas
2017-02-15 17:06 ` Javier Martinez Canillas
2017-02-15 17:06 ` Javier Martinez Canillas
2017-02-21 17:47 ` Heiko Stuebner
2017-02-21 17:47 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1716357.fXUCSFMPB6@diego \
--to=heiko@sntech.de \
--cc=dbasehore@chromium.org \
--cc=dianders@chromium.org \
--cc=hl@rock-chips.com \
--cc=javier@dowhile0.org \
--cc=jwerner@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.