All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+linux-riscv@kernel.org
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: linux-riscv@lists.infradead.org, rostedt@goodmis.org,
	mhiramat@kernel.org, mark.rutland@arm.com, guoren@kernel.org,
	chenhuacai@kernel.org, kernel@xen0n.name,
	James.Bottomley@HansenPartnership.com, deller@gmx.de,
	mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org,
	naveen.n.rao@linux.ibm.com, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com,
	gor@linux.ibm.com, agordeev@linux.ibm.com,
	borntraeger@linux.ibm.com, svens@linux.ibm.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org, loongarch@lists.linux.dev,
	linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH v3] kprobe/ftrace: bail out if ftrace was killed
Date: Wed, 22 May 2024 23:32:23 +0000	[thread overview]
Message-ID: <171642074348.9409.15455041633304152397.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240501162956.229427-1-stephen.s.brennan@oracle.com>

Hello:

This patch was applied to riscv/linux.git (fixes)
by Masami Hiramatsu (Google) <mhiramat@kernel.org>:

On Wed,  1 May 2024 09:29:56 -0700 you wrote:
> If an error happens in ftrace, ftrace_kill() will prevent disarming
> kprobes. Eventually, the ftrace_ops associated with the kprobes will be
> freed, yet the kprobes will still be active, and when triggered, they
> will use the freed memory, likely resulting in a page fault and panic.
> 
> This behavior can be reproduced quite easily, by creating a kprobe and
> then triggering a ftrace_kill(). For simplicity, we can simulate an
> ftrace error with a kernel module like [1]:
> 
> [...]

Here is the summary with links:
  - [v3] kprobe/ftrace: bail out if ftrace was killed
    https://git.kernel.org/riscv/c/1a7d0890dd4a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+linux-riscv@kernel.org
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: linux-riscv@lists.infradead.org, rostedt@goodmis.org,
	mhiramat@kernel.org, mark.rutland@arm.com, guoren@kernel.org,
	chenhuacai@kernel.org, kernel@xen0n.name,
	James.Bottomley@HansenPartnership.com, deller@gmx.de,
	mpe@ellerman.id.au, npiggin@gmail.com,
	christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org,
	naveen.n.rao@linux.ibm.com, paul.walmsley@sifive.com,
	palmer@dabbelt.com, aou@eecs.berkeley.edu, hca@linux.ibm.com,
	gor@linux.ibm.com, agordeev@linux.ibm.com,
	borntraeger@linux.ibm.com, svens@linux.ibm.com,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
	linux-csky@vger.kernel.org, loongarch@lists.linux.dev,
	linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH v3] kprobe/ftrace: bail out if ftrace was killed
Date: Wed, 22 May 2024 23:32:23 +0000	[thread overview]
Message-ID: <171642074348.9409.15455041633304152397.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240501162956.229427-1-stephen.s.brennan@oracle.com>

Hello:

This patch was applied to riscv/linux.git (fixes)
by Masami Hiramatsu (Google) <mhiramat@kernel.org>:

On Wed,  1 May 2024 09:29:56 -0700 you wrote:
> If an error happens in ftrace, ftrace_kill() will prevent disarming
> kprobes. Eventually, the ftrace_ops associated with the kprobes will be
> freed, yet the kprobes will still be active, and when triggered, they
> will use the freed memory, likely resulting in a page fault and panic.
> 
> This behavior can be reproduced quite easily, by creating a kprobe and
> then triggering a ftrace_kill(). For simplicity, we can simulate an
> ftrace error with a kernel module like [1]:
> 
> [...]

Here is the summary with links:
  - [v3] kprobe/ftrace: bail out if ftrace was killed
    https://git.kernel.org/riscv/c/1a7d0890dd4a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+linux-riscv@kernel.org
To: Stephen Brennan <stephen.s.brennan@oracle.com>
Cc: mark.rutland@arm.com, x86@kernel.org,
	dave.hansen@linux.intel.com,
	James.Bottomley@HansenPartnership.com, guoren@kernel.org,
	linux-csky@vger.kernel.org, hpa@zytor.com,
	agordeev@linux.ibm.com, linux-riscv@lists.infradead.org,
	linux-s390@vger.kernel.org, deller@gmx.de, chenhuacai@kernel.org,
	aneesh.kumar@kernel.org, mingo@redhat.com,
	naveen.n.rao@linux.ibm.com, borntraeger@linux.ibm.com,
	svens@linux.ibm.com, aou@eecs.berkeley.edu, gor@linux.ibm.com,
	hca@linux.ibm.com, npiggin@gmail.com, bp@alien8.de,
	rostedt@goodmis.org, loongarch@lists.linux.dev,
	paul.walmsley@sifive.com, tglx@linutronix.de,
	linux-parisc@vger.kernel.org, kernel@xen0n.name,
	linux-kernel@vger.kernel.org, palmer@dabbelt.com,
	mhiramat@kernel.org, linux-trace-kernel@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] kprobe/ftrace: bail out if ftrace was killed
Date: Wed, 22 May 2024 23:32:23 +0000	[thread overview]
Message-ID: <171642074348.9409.15455041633304152397.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240501162956.229427-1-stephen.s.brennan@oracle.com>

Hello:

This patch was applied to riscv/linux.git (fixes)
by Masami Hiramatsu (Google) <mhiramat@kernel.org>:

On Wed,  1 May 2024 09:29:56 -0700 you wrote:
> If an error happens in ftrace, ftrace_kill() will prevent disarming
> kprobes. Eventually, the ftrace_ops associated with the kprobes will be
> freed, yet the kprobes will still be active, and when triggered, they
> will use the freed memory, likely resulting in a page fault and panic.
> 
> This behavior can be reproduced quite easily, by creating a kprobe and
> then triggering a ftrace_kill(). For simplicity, we can simulate an
> ftrace error with a kernel module like [1]:
> 
> [...]

Here is the summary with links:
  - [v3] kprobe/ftrace: bail out if ftrace was killed
    https://git.kernel.org/riscv/c/1a7d0890dd4a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



  parent reply	other threads:[~2024-05-22 23:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-01 16:29 [PATCH v3] kprobe/ftrace: bail out if ftrace was killed Stephen Brennan
2024-05-01 16:29 ` Stephen Brennan
2024-05-01 16:29 ` Stephen Brennan
2024-05-01 17:24 ` Steven Rostedt
2024-05-01 17:24   ` Steven Rostedt
2024-05-01 17:24   ` Steven Rostedt
2024-05-01 17:35 ` Guo Ren
2024-05-01 17:35   ` Guo Ren
2024-05-01 17:35   ` Guo Ren
2024-05-02  2:03   ` Masami Hiramatsu
2024-05-02  2:03     ` Masami Hiramatsu
2024-05-02  2:03     ` Masami Hiramatsu
2024-05-15 22:18     ` Stephen Brennan
2024-05-15 22:18       ` Stephen Brennan
2024-05-15 22:18       ` Stephen Brennan
2024-05-16  0:23       ` Masami Hiramatsu
2024-05-16  0:23         ` Masami Hiramatsu
2024-05-16  0:23         ` Masami Hiramatsu
2024-05-06 14:46 ` Christophe Leroy
2024-05-06 14:46   ` Christophe Leroy
2024-05-06 14:46   ` Christophe Leroy
2024-05-06 22:50   ` Steven Rostedt
2024-05-06 22:50     ` Steven Rostedt
2024-05-06 22:50     ` Steven Rostedt
2024-05-07 18:36   ` Stephen Brennan
2024-05-07 18:36     ` Stephen Brennan
2024-05-07 18:36     ` Stephen Brennan
2024-05-22 23:32 ` patchwork-bot+linux-riscv [this message]
2024-05-22 23:32   ` patchwork-bot+linux-riscv
2024-05-22 23:32   ` patchwork-bot+linux-riscv

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171642074348.9409.15455041633304152397.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+linux-riscv@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=agordeev@linux.ibm.com \
    --cc=aneesh.kumar@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=borntraeger@linux.ibm.com \
    --cc=bp@alien8.de \
    --cc=chenhuacai@kernel.org \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dave.hansen@linux.intel.com \
    --cc=deller@gmx.de \
    --cc=gor@linux.ibm.com \
    --cc=guoren@kernel.org \
    --cc=hca@linux.ibm.com \
    --cc=hpa@zytor.com \
    --cc=kernel@xen0n.name \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=loongarch@lists.linux.dev \
    --cc=mark.rutland@arm.com \
    --cc=mhiramat@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=naveen.n.rao@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=rostedt@goodmis.org \
    --cc=stephen.s.brennan@oracle.com \
    --cc=svens@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.