* [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
@ 2024-04-25 19:58 ` Charlie Jenkins
0 siblings, 0 replies; 8+ messages in thread
From: Charlie Jenkins @ 2024-04-25 19:58 UTC (permalink / raw)
To: Shuah Khan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Andrew Jones
Cc: linux-kselftest, linux-riscv, linux-kernel, Charlie Jenkins
The cbo and which-cpu hwprobe selftests leave their artifacts in the
kernel tree and end up being tracked by git. Add the binaries to the
hwprobe selftest .gitignore so this no longer happens.
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
---
tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore
index 8113dc3bdd03..6e384e80ea1a 100644
--- a/tools/testing/selftests/riscv/hwprobe/.gitignore
+++ b/tools/testing/selftests/riscv/hwprobe/.gitignore
@@ -1 +1,3 @@
hwprobe
+cbo
+which-cpus
---
base-commit: ed30a4a51bb196781c8058073ea720133a65596f
change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
--
- Charlie
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
@ 2024-04-25 19:58 ` Charlie Jenkins
0 siblings, 0 replies; 8+ messages in thread
From: Charlie Jenkins @ 2024-04-25 19:58 UTC (permalink / raw)
To: Shuah Khan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Andrew Jones
Cc: linux-kselftest, linux-riscv, linux-kernel, Charlie Jenkins
The cbo and which-cpu hwprobe selftests leave their artifacts in the
kernel tree and end up being tracked by git. Add the binaries to the
hwprobe selftest .gitignore so this no longer happens.
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
---
tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore
index 8113dc3bdd03..6e384e80ea1a 100644
--- a/tools/testing/selftests/riscv/hwprobe/.gitignore
+++ b/tools/testing/selftests/riscv/hwprobe/.gitignore
@@ -1 +1,3 @@
hwprobe
+cbo
+which-cpus
---
base-commit: ed30a4a51bb196781c8058073ea720133a65596f
change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
--
- Charlie
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
2024-04-25 19:58 ` Charlie Jenkins
@ 2024-04-26 5:38 ` Muhammad Usama Anjum
-1 siblings, 0 replies; 8+ messages in thread
From: Muhammad Usama Anjum @ 2024-04-26 5:38 UTC (permalink / raw)
To: Charlie Jenkins, Shuah Khan, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Andrew Jones
Cc: Muhammad Usama Anjum, linux-kselftest, linux-riscv, linux-kernel
On 4/26/24 12:58 AM, Charlie Jenkins wrote:
> The cbo and which-cpu hwprobe selftests leave their artifacts in the
> kernel tree and end up being tracked by git. Add the binaries to the
> hwprobe selftest .gitignore so this no longer happens.
I've been posted comments on patches adding new tests to please put
artifacts in the .gitignore. But still people forget or don't know about it
as .gitignore is specific to selftests and they aren't used-to it.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore
> index 8113dc3bdd03..6e384e80ea1a 100644
> --- a/tools/testing/selftests/riscv/hwprobe/.gitignore
> +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore
> @@ -1 +1,3 @@
> hwprobe
> +cbo
> +which-cpus
>
> ---
> base-commit: ed30a4a51bb196781c8058073ea720133a65596f
> change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
--
BR,
Muhammad Usama Anjum
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
@ 2024-04-26 5:38 ` Muhammad Usama Anjum
0 siblings, 0 replies; 8+ messages in thread
From: Muhammad Usama Anjum @ 2024-04-26 5:38 UTC (permalink / raw)
To: Charlie Jenkins, Shuah Khan, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Andrew Jones
Cc: Muhammad Usama Anjum, linux-kselftest, linux-riscv, linux-kernel
On 4/26/24 12:58 AM, Charlie Jenkins wrote:
> The cbo and which-cpu hwprobe selftests leave their artifacts in the
> kernel tree and end up being tracked by git. Add the binaries to the
> hwprobe selftest .gitignore so this no longer happens.
I've been posted comments on patches adding new tests to please put
artifacts in the .gitignore. But still people forget or don't know about it
as .gitignore is specific to selftests and they aren't used-to it.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
Reviewed-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore
> index 8113dc3bdd03..6e384e80ea1a 100644
> --- a/tools/testing/selftests/riscv/hwprobe/.gitignore
> +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore
> @@ -1 +1,3 @@
> hwprobe
> +cbo
> +which-cpus
>
> ---
> base-commit: ed30a4a51bb196781c8058073ea720133a65596f
> change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
--
BR,
Muhammad Usama Anjum
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
2024-04-25 19:58 ` Charlie Jenkins
@ 2024-04-26 6:59 ` Andrew Jones
-1 siblings, 0 replies; 8+ messages in thread
From: Andrew Jones @ 2024-04-26 6:59 UTC (permalink / raw)
To: Charlie Jenkins
Cc: Shuah Khan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-kselftest, linux-riscv, linux-kernel
On Thu, Apr 25, 2024 at 12:58:03PM GMT, Charlie Jenkins wrote:
> The cbo and which-cpu hwprobe selftests leave their artifacts in the
> kernel tree and end up being tracked by git. Add the binaries to the
> hwprobe selftest .gitignore so this no longer happens.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
> ---
> tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore
> index 8113dc3bdd03..6e384e80ea1a 100644
> --- a/tools/testing/selftests/riscv/hwprobe/.gitignore
> +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore
> @@ -1 +1,3 @@
> hwprobe
> +cbo
> +which-cpus
>
> ---
> base-commit: ed30a4a51bb196781c8058073ea720133a65596f
> change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
> --
> - Charlie
>
We can also consider doing what kvm selftests does, which is to just have
the top-level .gitignore which ignores everything except the code. See
tools/testing/selftests/kvm/.gitignore
But, until (if at all) we go that way, we can do what this patch does,
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
@ 2024-04-26 6:59 ` Andrew Jones
0 siblings, 0 replies; 8+ messages in thread
From: Andrew Jones @ 2024-04-26 6:59 UTC (permalink / raw)
To: Charlie Jenkins
Cc: Shuah Khan, Paul Walmsley, Palmer Dabbelt, Albert Ou,
linux-kselftest, linux-riscv, linux-kernel
On Thu, Apr 25, 2024 at 12:58:03PM GMT, Charlie Jenkins wrote:
> The cbo and which-cpu hwprobe selftests leave their artifacts in the
> kernel tree and end up being tracked by git. Add the binaries to the
> hwprobe selftest .gitignore so this no longer happens.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
> ---
> tools/testing/selftests/riscv/hwprobe/.gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/riscv/hwprobe/.gitignore b/tools/testing/selftests/riscv/hwprobe/.gitignore
> index 8113dc3bdd03..6e384e80ea1a 100644
> --- a/tools/testing/selftests/riscv/hwprobe/.gitignore
> +++ b/tools/testing/selftests/riscv/hwprobe/.gitignore
> @@ -1 +1,3 @@
> hwprobe
> +cbo
> +which-cpus
>
> ---
> base-commit: ed30a4a51bb196781c8058073ea720133a65596f
> change-id: 20240425-gitignore_hwprobe_artifacts-fb0f2cd3509c
> --
> - Charlie
>
We can also consider doing what kvm selftests does, which is to just have
the top-level .gitignore which ignores everything except the code. See
tools/testing/selftests/kvm/.gitignore
But, until (if at all) we go that way, we can do what this patch does,
Reviewed-by: Andrew Jones <ajones@ventanamicro.com>
Thanks,
drew
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
2024-04-25 19:58 ` Charlie Jenkins
@ 2024-05-22 23:51 ` patchwork-bot+linux-riscv
-1 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-05-22 23:51 UTC (permalink / raw)
To: Charlie Jenkins
Cc: linux-riscv, shuah, paul.walmsley, palmer, aou, ajones,
linux-kselftest, linux-kernel
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Thu, 25 Apr 2024 12:58:03 -0700 you wrote:
> The cbo and which-cpu hwprobe selftests leave their artifacts in the
> kernel tree and end up being tracked by git. Add the binaries to the
> hwprobe selftest .gitignore so this no longer happens.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
>
> [...]
Here is the summary with links:
- riscv: selftests: Add hwprobe binaries to .gitignore
https://git.kernel.org/riscv/c/b1f4ad94cd12
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore
@ 2024-05-22 23:51 ` patchwork-bot+linux-riscv
0 siblings, 0 replies; 8+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-05-22 23:51 UTC (permalink / raw)
To: Charlie Jenkins
Cc: linux-riscv, shuah, paul.walmsley, palmer, aou, ajones,
linux-kselftest, linux-kernel
Hello:
This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:
On Thu, 25 Apr 2024 12:58:03 -0700 you wrote:
> The cbo and which-cpu hwprobe selftests leave their artifacts in the
> kernel tree and end up being tracked by git. Add the binaries to the
> hwprobe selftest .gitignore so this no longer happens.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Fixes: a29e2a48afe3 ("RISC-V: selftests: Add CBO tests")
> Fixes: ef7d6abb2cf5 ("RISC-V: selftests: Add which-cpus hwprobe test")
>
> [...]
Here is the summary with links:
- riscv: selftests: Add hwprobe binaries to .gitignore
https://git.kernel.org/riscv/c/b1f4ad94cd12
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-05-22 23:52 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-25 19:58 [PATCH] riscv: selftests: Add hwprobe binaries to .gitignore Charlie Jenkins
2024-04-25 19:58 ` Charlie Jenkins
2024-04-26 5:38 ` Muhammad Usama Anjum
2024-04-26 5:38 ` Muhammad Usama Anjum
2024-04-26 6:59 ` Andrew Jones
2024-04-26 6:59 ` Andrew Jones
2024-05-22 23:51 ` patchwork-bot+linux-riscv
2024-05-22 23:51 ` patchwork-bot+linux-riscv
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.