[PATCH BlueZ v2] avdtp: add NULL checks to avdtp_has_stream()

[PATCH BlueZ v2] avdtp: add NULL checks to avdtp_has_stream()

[Roman Smirnov]

Make avdtp_has_stream() safe for passing NULL pointers.

Found with the SVACE static analysis tool.
---
 V1 -> V2: added check for stream

 profiles/audio/avdtp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/profiles/audio/avdtp.c b/profiles/audio/avdtp.c
index 3667e0840..64735c5ee 100644
--- a/profiles/audio/avdtp.c
+++ b/profiles/audio/avdtp.c
@@ -3918,6 +3918,9 @@ struct btd_device *avdtp_get_device(struct avdtp *session)
 
 gboolean avdtp_has_stream(struct avdtp *session, struct avdtp_stream *stream)
 {
+	if (!session || !stream)
+		return FALSE;
+
 	return g_slist_find(session->streams, stream) ? TRUE : FALSE;
 }
 
-- 
2.43.0

RE: [BlueZ,v2] avdtp: add NULL checks to avdtp_has_stream()

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=866803

---Test result---

Test Summary:
CheckPatch                    PASS      0.36 seconds
GitLint                       PASS      0.20 seconds
BuildEll                      PASS      24.32 seconds
BluezMake                     PASS      1685.08 seconds
MakeCheck                     PASS      13.62 seconds
MakeDistcheck                 PASS      176.12 seconds
CheckValgrind                 PASS      256.04 seconds
CheckSmatch                   PASS      351.98 seconds
bluezmakeextell               PASS      118.74 seconds
IncrementalBuild              PASS      1385.55 seconds
ScanBuild                     PASS      988.63 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ v2] avdtp: add NULL checks to avdtp_has_stream()

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Sat, 29 Jun 2024 11:36:18 +0300 you wrote:
> Make avdtp_has_stream() safe for passing NULL pointers.
> 
> Found with the SVACE static analysis tool.
> ---
>  V1 -> V2: added check for stream
> 
>  profiles/audio/avdtp.c | 3 +++
>  1 file changed, 3 insertions(+)

Here is the summary with links:
  - [BlueZ,v2] avdtp: add NULL checks to avdtp_has_stream()
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=be0b08770e92

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html