[PATCH BlueZ] Fix discoverable property not emitted on updating value to false

[PATCH BlueZ] Fix discoverable property not emitted on updating value to false

[quic_prathm]

From: Prathibha Madugonde <quic_prathm@quicinc.com>

client/advertising.c:
Allowing discoverable property to list in the parsing
function when discoverable is off.

Test steps:
From DUT, bluetoothctl go to menu advertise
set discoverable to off and then advertise on.

---
 client/advertising.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/client/advertising.c b/client/advertising.c
index a9b865a65..4a98121a4 100644
--- a/client/advertising.c
+++ b/client/advertising.c
@@ -416,12 +416,6 @@ static gboolean get_data(const GDBusPropertyTable *property,
 	return TRUE;
 }
 
-static gboolean discoverable_exists(const GDBusPropertyTable *property,
-							void *data)
-{
-	return ad.discoverable;
-}
-
 static gboolean get_discoverable(const GDBusPropertyTable *property,
 					DBusMessageIter *iter, void *user_data)
 {
@@ -498,7 +492,7 @@ static const GDBusPropertyTable ad_props[] = {
 	{ "ManufacturerData", "a{qv}", get_manufacturer_data, NULL,
 						manufacturer_data_exists },
 	{ "Data", "a{yv}", get_data, NULL, data_exists },
-	{ "Discoverable", "b", get_discoverable, NULL, discoverable_exists },
+	{ "Discoverable", "b", get_discoverable, NULL, NULL },
 	{ "DiscoverableTimeout", "q", get_discoverable_timeout, NULL,
 						discoverable_timeout_exists },
 	{ "Includes", "as", get_includes, NULL, includes_exists },
-- 
2.17.1

RE: [BlueZ] Fix discoverable property not emitted on updating value to false

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=869179

---Test result---

Test Summary:
CheckPatch                    PASS      0.44 seconds
GitLint                       PASS      0.30 seconds
BuildEll                      PASS      24.34 seconds
BluezMake                     PASS      1621.73 seconds
MakeCheck                     PASS      13.41 seconds
MakeDistcheck                 PASS      178.61 seconds
CheckValgrind                 PASS      256.14 seconds
CheckSmatch                   PASS      364.50 seconds
bluezmakeextell               PASS      121.98 seconds
IncrementalBuild              PASS      1382.91 seconds
ScanBuild                     PASS      989.57 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] Fix discoverable property not emitted on updating value to false

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 8 Jul 2024 13:10:24 +0530 you wrote:
> From: Prathibha Madugonde <quic_prathm@quicinc.com>
> 
> client/advertising.c:
> Allowing discoverable property to list in the parsing
> function when discoverable is off.
> 
> Test steps:
> From DUT, bluetoothctl go to menu advertise
> set discoverable to off and then advertise on.
> 
> [...]

Here is the summary with links:
  - [BlueZ] Fix discoverable property not emitted on updating value to false
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=b2371f9f1134

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html