[f2fs-dev] [PATCH] f2fs: remove unreachable lazytime mount option parsing

[f2fs-dev] [PATCH] f2fs: remove unreachable lazytime mount option parsing

[Eric Sandeen]

The lazytime/nolazytime options are now handled in the VFS, and are
never seen in filesystem parsers, so remove handling of these
options from f2fs.

Note: when lazytime support was added in 6d94c74ab85f it made
lazytime the default in default_options() - as a result, lazytime
cannot be disabled (because Opt_nolazytime is never seen in f2fs
parsing).

If lazytime is desired to be configurable, and default off is OK,
default_options() could be updated to stop setting it by default
and allow mount option control.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

(I came across this when looking at mount API conversion, which still
has not gotten very far, sorry!)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 1f1b3647a998..12bf7f014fc4 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -151,8 +151,6 @@ enum {
 	Opt_mode,
 	Opt_fault_injection,
 	Opt_fault_type,
-	Opt_lazytime,
-	Opt_nolazytime,
 	Opt_quota,
 	Opt_noquota,
 	Opt_usrquota,
@@ -229,8 +227,6 @@ static match_table_t f2fs_tokens = {
 	{Opt_mode, "mode=%s"},
 	{Opt_fault_injection, "fault_injection=%u"},
 	{Opt_fault_type, "fault_type=%u"},
-	{Opt_lazytime, "lazytime"},
-	{Opt_nolazytime, "nolazytime"},
 	{Opt_quota, "quota"},
 	{Opt_noquota, "noquota"},
 	{Opt_usrquota, "usrquota"},
@@ -918,12 +914,6 @@ static int parse_options(struct super_block *sb, char *options, bool is_remount)
 			f2fs_info(sbi, "fault_type options not supported");
 			break;
 #endif
-		case Opt_lazytime:
-			sb->s_flags |= SB_LAZYTIME;
-			break;
-		case Opt_nolazytime:
-			sb->s_flags &= ~SB_LAZYTIME;
-			break;
 #ifdef CONFIG_QUOTA
 		case Opt_quota:
 		case Opt_usrquota:



_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: remove unreachable lazytime mount option parsing

[Chao Yu]

On 2024/6/29 12:38, Eric Sandeen wrote:
> The lazytime/nolazytime options are now handled in the VFS, and are
> never seen in filesystem parsers, so remove handling of these
> options from f2fs.
> 
> Note: when lazytime support was added in 6d94c74ab85f it made
> lazytime the default in default_options() - as a result, lazytime
> cannot be disabled (because Opt_nolazytime is never seen in f2fs
> parsing).
> 
> If lazytime is desired to be configurable, and default off is OK,
> default_options() could be updated to stop setting it by default
> and allow mount option control.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] f2fs: remove unreachable lazytime mount option parsing

[patchwork-bot+f2fs]

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Fri, 28 Jun 2024 23:38:17 -0500 you wrote:
> The lazytime/nolazytime options are now handled in the VFS, and are
> never seen in filesystem parsers, so remove handling of these
> options from f2fs.
> 
> Note: when lazytime support was added in 6d94c74ab85f it made
> lazytime the default in default_options() - as a result, lazytime
> cannot be disabled (because Opt_nolazytime is never seen in f2fs
> parsing).
> 
> [...]

Here is the summary with links:
  - [f2fs-dev] f2fs: remove unreachable lazytime mount option parsing
    https://git.kernel.org/jaegeuk/f2fs/c/54f43a10fa25

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html




_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel