From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: zzc@rock-chips.com, andyshrk@163.com, heiko@sntech.de,
jonas@kwiboo.se, linux-rockchip@lists.infradead.org,
Chris Morgan <macromorgan@hotmail.com>,
jagan@edgeble.ai, krzk+dt@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH V2 0/3] Add GameForce Ace
Date: Fri, 30 Aug 2024 11:33:50 -0500 [thread overview]
Message-ID: <172503553992.420479.9699991919956159507.robh@kernel.org> (raw)
In-Reply-To: <20240829204517.398669-1-macroalpha82@gmail.com>
On Thu, 29 Aug 2024 15:45:14 -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add support for the GameForce Ace. The GameForce Ace is an RK3588s
> based gaming device with a 1080p display, touchscreen, hall effect
> joysticks and triggers, 128GB of eMMC, 8GB or 12GB of RAM, WiFi 5,
> and support for a 2242 NVME.
>
> Changes since V1:
> - Update eMMC changes to note proper authorship.
> - Removed cw2015 changes for dual cell configuration. For the moment
> it's just cosmetic (aside from voltage_now reading incorrectly, no
> other issues were observed).
> - Removed USB bindings because vbus regulator isn't ready yet.
>
> Alex Zhao (1):
> arm64: dts: rockchip: rk3588s fix sdio pins to pull up
>
> Chris Morgan (2):
> dt-bindings: arm: rockchip: Add GameForce Ace
> arm64: dts: rockchip: Add GameForce Ace
>
> .../devicetree/bindings/arm/rockchip.yaml | 5 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3588-base-pinctrl.dtsi | 10 +-
> .../dts/rockchip/rk3588s-gameforce-ace.dts | 1237 +++++++++++++++++
> 4 files changed, 1248 insertions(+), 5 deletions(-)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-gameforce-ace.dtb' for 20240829204517.398669-1-macroalpha82@gmail.com:
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: video-codec@fdb50000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu'] is too long
'rockchip,rk3588-vpu121' is not one of ['rockchip,rk3036-vpu', 'rockchip,rk3066-vpu', 'rockchip,rk3288-vpu', 'rockchip,rk3328-vpu', 'rockchip,rk3399-vpu', 'rockchip,px30-vpu', 'rockchip,rk3568-vpu', 'rockchip,rk3588-av1-vpu']
'rockchip,rk3188-vpu' was expected
'rockchip,rk3228-vpu' was expected
'rockchip,rk3066-vpu' was expected
'rockchip,rk3399-vpu' was expected
from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdb50000: failed to match any schema with compatible: ['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdba0000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdba4000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdba8000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdbac000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: zzc@rock-chips.com, andyshrk@163.com, heiko@sntech.de,
jonas@kwiboo.se, linux-rockchip@lists.infradead.org,
Chris Morgan <macromorgan@hotmail.com>,
jagan@edgeble.ai, krzk+dt@kernel.org,
devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH V2 0/3] Add GameForce Ace
Date: Fri, 30 Aug 2024 11:33:50 -0500 [thread overview]
Message-ID: <172503553992.420479.9699991919956159507.robh@kernel.org> (raw)
In-Reply-To: <20240829204517.398669-1-macroalpha82@gmail.com>
On Thu, 29 Aug 2024 15:45:14 -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add support for the GameForce Ace. The GameForce Ace is an RK3588s
> based gaming device with a 1080p display, touchscreen, hall effect
> joysticks and triggers, 128GB of eMMC, 8GB or 12GB of RAM, WiFi 5,
> and support for a 2242 NVME.
>
> Changes since V1:
> - Update eMMC changes to note proper authorship.
> - Removed cw2015 changes for dual cell configuration. For the moment
> it's just cosmetic (aside from voltage_now reading incorrectly, no
> other issues were observed).
> - Removed USB bindings because vbus regulator isn't ready yet.
>
> Alex Zhao (1):
> arm64: dts: rockchip: rk3588s fix sdio pins to pull up
>
> Chris Morgan (2):
> dt-bindings: arm: rockchip: Add GameForce Ace
> arm64: dts: rockchip: Add GameForce Ace
>
> .../devicetree/bindings/arm/rockchip.yaml | 5 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../dts/rockchip/rk3588-base-pinctrl.dtsi | 10 +-
> .../dts/rockchip/rk3588s-gameforce-ace.dts | 1237 +++++++++++++++++
> 4 files changed, 1248 insertions(+), 5 deletions(-)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dts
>
> --
> 2.34.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3588s-gameforce-ace.dtb' for 20240829204517.398669-1-macroalpha82@gmail.com:
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: video-codec@fdb50000: compatible: 'oneOf' conditional failed, one must be fixed:
['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu'] is too long
'rockchip,rk3588-vpu121' is not one of ['rockchip,rk3036-vpu', 'rockchip,rk3066-vpu', 'rockchip,rk3288-vpu', 'rockchip,rk3328-vpu', 'rockchip,rk3399-vpu', 'rockchip,px30-vpu', 'rockchip,rk3568-vpu', 'rockchip,rk3588-av1-vpu']
'rockchip,rk3188-vpu' was expected
'rockchip,rk3228-vpu' was expected
'rockchip,rk3066-vpu' was expected
'rockchip,rk3399-vpu' was expected
from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdb50000: failed to match any schema with compatible: ['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdba0000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdba4000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdba8000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588s-gameforce-ace.dtb: /video-codec@fdbac000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
next prev parent reply other threads:[~2024-08-30 16:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 20:45 [PATCH V2 0/3] Add GameForce Ace Chris Morgan
2024-08-29 20:45 ` Chris Morgan
2024-08-29 20:45 ` [PATCH V2 1/3] arm64: dts: rockchip: rk3588s fix sdio pins to pull up Chris Morgan
2024-08-29 20:45 ` Chris Morgan
2024-08-29 20:45 ` [PATCH V2 2/3] dt-bindings: arm: rockchip: Add GameForce Ace Chris Morgan
2024-08-29 20:45 ` Chris Morgan
2024-08-29 20:45 ` [PATCH V2 3/3] arm64: dts: " Chris Morgan
2024-08-29 20:45 ` Chris Morgan
2024-08-30 16:33 ` Rob Herring (Arm) [this message]
2024-08-30 16:33 ` [PATCH V2 0/3] " Rob Herring (Arm)
2024-08-30 18:49 ` Heiko Stübner
2024-08-30 18:49 ` Heiko Stübner
2024-09-04 19:07 ` Heiko Stuebner
2024-09-04 19:07 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172503553992.420479.9699991919956159507.robh@kernel.org \
--to=robh@kernel.org \
--cc=andyshrk@163.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=zzc@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.