All of lore.kernel.org
 help / color / mirror / Atom feed
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] dw-hdmi CEC support
Date: Wed, 02 Aug 2017 01:29:32 +0300	[thread overview]
Message-ID: <17264852.3R3UM7X4I0@avalon> (raw)
In-Reply-To: <20170731142906.GX31807@n2100.armlinux.org.uk>

Hi Russell,

Thank you for the patches.

On Monday 31 Jul 2017 15:29:06 Russell King - ARM Linux wrote:
> Hi,
> 
> This series adds dw-hdmi CEC support.  This is done in four stages:
> 
> 1. Add cec-notifier support
> 2. Fix up the clkdis register support, as this register contains a
>    clock disable bit for the CEC module.
> 3. Add the driver.
> 4. Remove definitions that are not required from dw-hdmi.h
> 
> The CEC driver has been updated to use the register accessors in the
> main driver - it would be nice if it was possible to use the regmap
> support directly, but there's some knowledge private to the main
> driver that's required to correctly access the registers.  (I don't
> understand why the register stride isn't part of regmap.)
> 
>  drivers/gpu/drm/bridge/synopsys/Kconfig       |  10 +
>  drivers/gpu/drm/bridge/synopsys/Makefile      |   1 +
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 326 +++++++++++++++++++++++
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.h |  19 ++
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c     |  93 +++++++-
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.h     |  46 +---
>  6 files changed, 437 insertions(+), 58 deletions(-)
> 
> v2 - fix selection of CEC_NOTIFIER in Kconfig

For the whole series,

Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

on R-Car H3.

The DWC HDMI controller in this SoC supports CEC, but I have no CEC-enabled 
sink, so tests were limited to regression checks.

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: dri-devel@lists.freedesktop.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
	Russell King - ARM Linux <linux@armlinux.org.uk>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] dw-hdmi CEC support
Date: Wed, 02 Aug 2017 01:29:32 +0300	[thread overview]
Message-ID: <17264852.3R3UM7X4I0@avalon> (raw)
In-Reply-To: <20170731142906.GX31807@n2100.armlinux.org.uk>

Hi Russell,

Thank you for the patches.

On Monday 31 Jul 2017 15:29:06 Russell King - ARM Linux wrote:
> Hi,
> 
> This series adds dw-hdmi CEC support.  This is done in four stages:
> 
> 1. Add cec-notifier support
> 2. Fix up the clkdis register support, as this register contains a
>    clock disable bit for the CEC module.
> 3. Add the driver.
> 4. Remove definitions that are not required from dw-hdmi.h
> 
> The CEC driver has been updated to use the register accessors in the
> main driver - it would be nice if it was possible to use the regmap
> support directly, but there's some knowledge private to the main
> driver that's required to correctly access the registers.  (I don't
> understand why the register stride isn't part of regmap.)
> 
>  drivers/gpu/drm/bridge/synopsys/Kconfig       |  10 +
>  drivers/gpu/drm/bridge/synopsys/Makefile      |   1 +
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.c | 326 +++++++++++++++++++++++
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi-cec.h |  19 ++
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.c     |  93 +++++++-
>  drivers/gpu/drm/bridge/synopsys/dw-hdmi.h     |  46 +---
>  6 files changed, 437 insertions(+), 58 deletions(-)
> 
> v2 - fix selection of CEC_NOTIFIER in Kconfig

For the whole series,

Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

on R-Car H3.

The DWC HDMI controller in this SoC supports CEC, but I have no CEC-enabled 
sink, so tests were limited to regression checks.

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2017-08-01 22:29 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 14:29 [PATCH v2 0/4] dw-hdmi CEC support Russell King - ARM Linux
2017-07-31 14:29 ` Russell King - ARM Linux
2017-07-31 14:29 ` [PATCH v2 1/4] drm/bridge: dw-hdmi: add cec notifier support Russell King
2017-07-31 14:29   ` Russell King
2017-07-31 14:33   ` Neil Armstrong
2017-07-31 14:33     ` Neil Armstrong
2017-07-31 15:25   ` Hans Verkuil
2017-07-31 15:25     ` Hans Verkuil
2017-08-04 13:36     ` Archit Taneja
2017-08-04 13:36       ` Archit Taneja
2017-08-05  9:23       ` Hans Verkuil
2017-08-05  9:23         ` Hans Verkuil
2017-08-07  3:59         ` Archit Taneja
2017-08-07  3:59           ` Archit Taneja
2017-08-02 14:11   ` Laurent Pinchart
2017-08-02 14:11     ` Laurent Pinchart
2017-08-02 14:17     ` Hans Verkuil
2017-08-02 14:17       ` Hans Verkuil
2017-08-02 17:44       ` Russell King - ARM Linux
2017-08-02 17:44         ` Russell King - ARM Linux
2017-07-31 14:29 ` [PATCH v2 2/4] drm/bridge: dw-hdmi: add better clock disable control Russell King
2017-07-31 14:29   ` Russell King
2017-07-31 15:26   ` Hans Verkuil
2017-07-31 15:26     ` Hans Verkuil
2017-08-04 13:39     ` Archit Taneja
2017-08-04 13:39       ` Archit Taneja
2017-07-31 14:29 ` [PATCH v2 3/4] drm/bridge: dw-hdmi: add cec driver Russell King
2017-07-31 14:29   ` Russell King
2017-07-31 15:35   ` Hans Verkuil
2017-07-31 15:35     ` Hans Verkuil
2017-08-01 22:32   ` Laurent Pinchart
2017-08-01 22:32     ` Laurent Pinchart
2017-08-02  6:47     ` Hans Verkuil
2017-08-02  6:47       ` Hans Verkuil
2017-08-02 13:14       ` Laurent Pinchart
2017-08-02 13:14         ` Laurent Pinchart
2017-08-02 13:27         ` Russell King - ARM Linux
2017-08-02 13:27           ` Russell King - ARM Linux
2017-08-02 13:34           ` Hans Verkuil
2017-08-02 13:34             ` Hans Verkuil
2017-08-02 14:22             ` Laurent Pinchart
2017-08-02 14:22               ` Laurent Pinchart
2017-08-02 17:43               ` Russell King - ARM Linux
2017-08-02 17:43                 ` Russell King - ARM Linux
2017-08-02 14:17         ` Neil Armstrong
2017-07-31 14:29 ` [PATCH v2 4/4] drm/bridge: dw-hdmi: remove CEC engine register definitions Russell King
2017-07-31 14:29   ` Russell King
2017-07-31 15:26   ` Hans Verkuil
2017-07-31 15:26     ` Hans Verkuil
2017-08-01 22:29 ` Laurent Pinchart [this message]
2017-08-01 22:29   ` [PATCH v2 0/4] dw-hdmi CEC support Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17264852.3R3UM7X4I0@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.