[BlueZ 1/2] profiles/audio: Quiet plug-in warnings

[BlueZ 1/2] profiles/audio: Quiet plug-in warnings

[Bastien Nocera]

A normal daemon start should not throw warnings on a system in the
default configuration. Quiet the plug-in warnings that require
experimental features to be enabled. They will still appear in the debug
output.

bluetoothd[896]: profiles/audio/micp.c:micp_init() D-Bus experimental not enabled
---
 profiles/audio/media.c | 2 +-
 profiles/audio/micp.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index 746e538fcacd..062475e56c49 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -1249,7 +1249,7 @@ static bool endpoint_init_pac(struct media_endpoint *endpoint, uint8_t type,
 	char *name;
 
 	if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) {
-		warn("D-Bus experimental not enabled");
+		DBG("D-Bus experimental not enabled");
 		*err = -ENOTSUP;
 		return false;
 	}
diff --git a/profiles/audio/micp.c b/profiles/audio/micp.c
index 452027c75da2..3f0845dcb328 100644
--- a/profiles/audio/micp.c
+++ b/profiles/audio/micp.c
@@ -318,7 +318,7 @@ static unsigned int micp_id;
 static int micp_init(void)
 {
 	if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL)) {
-		warn("D-Bus experimental not enabled");
+		DBG("D-Bus experimental not enabled");
 		return -ENOTSUP;
 	}
 
-- 
2.47.0

[BlueZ 2/2] plugin: Quiet start-up warnings

[Bastien Nocera]

It's not an error for a plug-in not to start if the hardware doesn't
support it. Quiet the warnings that require specific hardware.
The messages will still appear in the debug output.

bluetoothd[896]: src/plugin.c:plugin_init() System does not support csip plugin
bluetoothd[896]: src/plugin.c:plugin_init() System does not support micp plugin
bluetoothd[896]: src/plugin.c:plugin_init() System does not support vcp plugin
bluetoothd[896]: src/plugin.c:plugin_init() System does not support mcp plugin
bluetoothd[896]: src/plugin.c:plugin_init() System does not support bass plugin
bluetoothd[896]: src/plugin.c:plugin_init() System does not support bap plugin
---
 src/plugin.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/plugin.c b/src/plugin.c
index e6d05be4ce08..00d3d7b6a0b5 100644
--- a/src/plugin.c
+++ b/src/plugin.c
@@ -50,7 +50,7 @@ static int init_plugin(const struct bluetooth_plugin_desc *desc)
 	err = desc->init();
 	if (err < 0) {
 		if (err == -ENOSYS || err == -ENOTSUP)
-			warn("System does not support %s plugin",
+			DBG("System does not support %s plugin",
 						desc->name);
 		else
 			error("Failed to init %s plugin",
-- 
2.47.0

RE: [BlueZ,1/2] profiles/audio: Quiet plug-in warnings

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 1260 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=912795

---Test result---

Test Summary:
CheckPatch                    PENDING   0.18 seconds
GitLint                       PENDING   0.22 seconds
BuildEll                      PASS      20.37 seconds
BluezMake                     PASS      1559.79 seconds
MakeCheck                     PASS      13.46 seconds
MakeDistcheck                 PASS      158.91 seconds
CheckValgrind                 PASS      214.05 seconds
CheckSmatch                   PASS      271.16 seconds
bluezmakeextell               PASS      98.57 seconds
IncrementalBuild              PENDING   0.28 seconds
ScanBuild                     PASS      840.46 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [BlueZ 1/2] profiles/audio: Quiet plug-in warnings

[patchwork-bot+bluetooth]

Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 27 Nov 2024 12:49:52 +0100 you wrote:
> A normal daemon start should not throw warnings on a system in the
> default configuration. Quiet the plug-in warnings that require
> experimental features to be enabled. They will still appear in the debug
> output.
> 
> bluetoothd[896]: profiles/audio/micp.c:micp_init() D-Bus experimental not enabled
> 
> [...]

Here is the summary with links:
  - [BlueZ,1/2] profiles/audio: Quiet plug-in warnings
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=fdcde2ce2112
  - [BlueZ,2/2] plugin: Quiet start-up warnings
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=252883241228

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html