[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[Hebbar]

Hi,

Thanks to wd and all people who contributed for release of u-boot-1.3.3. 

While going through some the files that i use for my u-boot version, i found
an incorrect escape sequence mentioned in u-boot-1.3.3/common/usb.c. Below
is the patch that corrects the same.

Here in my company i cannot use git and hence no git-patch or git-mail.
sorry for that..


Regards
Gururaja

Signed off by: Gururaja Hebbar <gururajakr@sanyo.co.in>

diff -purN u-boot-1.3.3/common/usb.c u-boot-1.3.3-modified/common/usb.c
--- u-boot-1.3.3/common/usb.c	2008-05-19 03:47:11.000000000 -0700
+++ u-boot-1.3.3-modified/common/usb.c	2008-05-20 13:39:17.484375000 -0700
@@ -1088,7 +1088,7 @@ int usb_hub_configure(struct usb_device 
 	/* silence compiler warning if USB_BUFSIZ is > 256 [= sizeof(char)] */
 	i = descriptor->bLength;
 	if (i > USB_BUFSIZ) {
-		USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
long: %d\N",
+		USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
long: %d\n",
 			descriptor->bLength);
 		return -1;
 	}




http://www.nabble.com/file/p17336362/uboot-1.3.3-usb_driver-incorrect_escape_sequence.diff
uboot-1.3.3-usb_driver-incorrect_escape_sequence.diff 
-- 
View this message in context: http://www.nabble.com/-PATCH--Incorrect-escape-sequences-in-u-boot-1.3.3-common-usb.c-tp17336362p17336362.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[Wolfgang Denk]

Dear Gururaja,

in message <17336362.post@talk.nabble.com> you wrote:
> 
> While going through some the files that i use for my u-boot version, i found
> an incorrect escape sequence mentioned in u-boot-1.3.3/common/usb.c. Below
> is the patch that corrects the same.

Thanks. Had to apply manually, as your patch is line-wrapped.

> Here in my company i cannot use git and hence no git-patch or git-mail.
> sorry for that..

What could you prevent from using git? I cannot imagine...

> -		USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
> long: %d\N",
^^^^^^^^^^^^^^^^^^
> +		USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
> long: %d\n",
^^^^^^^^^^^^^^^^^^

Please fix your mailer to not wrap lines!

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Do not underestimate the value of print statements for debugging.
Don't have aesthetic convulsions when using them, either.

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[Hebbar]

>>
>>
>>Thanks. Had to apply manually, as your patch is line-wrapped.

>>Please fix your mailer to not wrap lines!

I sent the patch from nabble forum becuase i thought microsoft outlook will
line wrap the mails. Also i uploaded patch along with the mail rom nable
forum.

>>What could you prevent from using git? I cannot imagine...

Even i dont know y and i am trying to convince them.

Will try to solve this at the earliest. 

Regards
Gururaja


-- 
View this message in context: http://www.nabble.com/-PATCH--Incorrect-escape-sequences-in-u-boot-1.3.3-common-usb.c-tp17336362p17336578.html
Sent from the Uboot - Users mailing list archive at Nabble.com.

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[Wolfgang Denk]

In message <17336578.post@talk.nabble.com> you wrote:
> 
> >>What could you prevent from using git? I cannot imagine...
> 
> Even i dont know y and i am trying to convince them.

I mean: what prevents you from installing it locally in your $HOME
dir?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The man on tops walks a lonely street;  the  "chain"  of  command  is
often a noose.

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[Jean-Christophe PLAGNIOL-VILLARD]

On 02:16 Tue 20 May     , Hebbar wrote:
> 
> Hi,
> 
> Thanks to wd and all people who contributed for release of u-boot-1.3.3. 
> 
> While going through some the files that i use for my u-boot version, i found
> an incorrect escape sequence mentioned in u-boot-1.3.3/common/usb.c. Below
> is the patch that corrects the same.
> 
> Here in my company i cannot use git and hence no git-patch or git-mail.
> sorry for that..
> 
> 
> Regards
> Gururaja
> 
> Signed off by: Gururaja Hebbar <gururajakr@sanyo.co.in>
> 
> diff -purN u-boot-1.3.3/common/usb.c u-boot-1.3.3-modified/common/usb.c
> --- u-boot-1.3.3/common/usb.c	2008-05-19 03:47:11.000000000 -0700
> +++ u-boot-1.3.3-modified/common/usb.c	2008-05-20 13:39:17.484375000 -0700
> @@ -1088,7 +1088,7 @@ int usb_hub_configure(struct usb_device 
>  	/* silence compiler warning if USB_BUFSIZ is > 256 [= sizeof(char)] */
>  	i = descriptor->bLength;
>  	if (i > USB_BUFSIZ) {
> -		USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
> long: %d\N",
> +		USB_HUB_PRINTF("usb_hub_configure: failed to get hub descriptor - too
> long: %d\n",
>  			descriptor->bLength);
>  		return -1;
>  	}
I'll send tomorow a full coding style patch

Best Regards,
J.

[U-Boot-Users] [PATCH] Incorrect escape sequences in u-boot-1.3.3/common/usb.c

[Wolfgang Denk]

In message <20080520153818.GA18756@game.jcrosoft.org> you wrote:
>
> > diff -purN u-boot-1.3.3/common/usb.c u-boot-1.3.3-modified/common/usb.c
> > --- u-boot-1.3.3/common/usb.c	2008-05-19 03:47:11.000000000 -0700
> > +++ u-boot-1.3.3-modified/common/usb.c	2008-05-20 13:39:17.484375000 -0700
...
> I'll send tomorow a full coding style patch

Mind my pending whitespace-cleanup patch which touches this file, too.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Digital computers are themselves more complex than most things people
build: They have very large numbers of states. This makes conceiving,
describing, and testing them hard. Software systems  have  orders-of-
magnitude more states than computers do.           - Fred Brooks, Jr.