From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie,
daniel@ffwll.ch, peda@axentia.se,
linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] media: Add LE version of RGB LVDS formats
Date: Mon, 23 Apr 2018 16:06:01 +0300 [thread overview]
Message-ID: <1733883.PFymhGyeZa@avalon> (raw)
In-Reply-To: <1524130269-32688-6-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo,
Thank you for the patch.
On Thursday, 19 April 2018 12:31:06 EEST Jacopo Mondi wrote:
> Some LVDS controller can output swapped versions of LVDS RGB formats.
> Define and document them in the list of supported media bus formats
I wouldn't introduce those new formats as we don't need them. As a general
rule we would like to have at least one user for any new format added to the
API.
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> Documentation/media/uapi/v4l/subdev-formats.rst | 174 +++++++++++++++++++++
> include/uapi/linux/media-bus-format.h | 5 +-
> 2 files changed, 178 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst
> b/Documentation/media/uapi/v4l/subdev-formats.rst index 9fcabe7..9a5263c
> 100644
> --- a/Documentation/media/uapi/v4l/subdev-formats.rst
> +++ b/Documentation/media/uapi/v4l/subdev-formats.rst
> @@ -1669,6 +1669,64 @@ JEIDA defined bit mapping will be named
> - b\ :sub:`2`
> - g\ :sub:`1`
> - r\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-RGB666-1X7X3-SPWG_LE:
> +
> + - MEDIA_BUS_FMT_RGB666_1X7X3_SPWG_LE
> + - 0x101b
> + - 0
> + -
> + -
> + - b\ :sub:`2`
> + - g\ :sub:`1`
> + - r\ :sub:`0`
> + * -
> + -
> + - 1
> + -
> + -
> + - b\ :sub:`3`
> + - g\ :sub:`2`
> + - r\ :sub:`1`
> + * -
> + -
> + - 2
> + -
> + -
> + - b\ :sub:`4`
> + - g\ :sub:`3`
> + - r\ :sub:`2`
> + * -
> + -
> + - 3
> + -
> + -
> + - b\ :sub:`5`
> + - g\ :sub:`4`
> + - r\ :sub:`3`
> + * -
> + -
> + - 4
> + -
> + -
> + - d
> + - g\ :sub:`5`
> + - r\ :sub:`4`
> + * -
> + -
> + - 5
> + -
> + -
> + - d
> + - b\ :sub:`0`
> + - r\ :sub:`5`
> + * -
> + -
> + - 6
> + -
> + -
> + - d
> + - b\ :sub:`1`
> + - g\ :sub:`0`
> * .. _MEDIA-BUS-FMT-RGB888-1X7X4-SPWG:
>
> - MEDIA_BUS_FMT_RGB888_1X7X4_SPWG
> @@ -1727,6 +1785,64 @@ JEIDA defined bit mapping will be named
> - b\ :sub:`2`
> - g\ :sub:`1`
> - r\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-RGB888-1X7X4-SPWG_LE:
> +
> + - MEDIA_BUS_FMT_RGB888_1X7X4_SPWG_LE
> + - 0x101c
> + - 0
> + -
> + - r\ :sub:`6`
> + - b\ :sub:`2`
> + - g\ :sub:`1`
> + - r\ :sub:`0`
> + * -
> + -
> + - 1
> + -
> + - r\ :sub:`7`
> + - b\ :sub:`3`
> + - g\ :sub:`2`
> + - r\ :sub:`1`
> + * -
> + -
> + - 2
> + -
> + - g\ :sub:`6`
> + - b\ :sub:`4`
> + - g\ :sub:`3`
> + - r\ :sub:`2`
> + * -
> + -
> + - 3
> + -
> + - g\ :sub:`7`
> + - b\ :sub:`5`
> + - g\ :sub:`4`
> + - r\ :sub:`3`
> + * -
> + -
> + - 4
> + -
> + - b\ :sub:`6`
> + - d
> + - g\ :sub:`5`
> + - r\ :sub:`4`
> + * -
> + -
> + - 5
> + -
> + - b\ :sub:`7`
> + - d
> + - b\ :sub:`0`
> + - r\ :sub:`5`
> + * -
> + -
> + - 6
> + -
> + - d
> + - d
> + - b\ :sub:`1`
> + - g\ :sub:`0`
> * .. _MEDIA-BUS-FMT-RGB888-1X7X4-JEIDA:
>
> - MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA
> @@ -1785,6 +1901,64 @@ JEIDA defined bit mapping will be named
> - b\ :sub:`4`
> - g\ :sub:`3`
> - r\ :sub:`2`
> + * .. _MEDIA-BUS-FMT-RGB888-1X7X4-JEIDA_LE:
> +
> + - MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA_LE
> + - 0x101d
> + - 0
> + -
> + - r\ :sub:`0`
> + - b\ :sub:`4`
> + - g\ :sub:`3`
> + - r\ :sub:`2`
> + * -
> + -
> + - 1
> + -
> + - r\ :sub:`1`
> + - b\ :sub:`5`
> + - g\ :sub:`4`
> + - r\ :sub:`3`
> + * -
> + -
> + - 2
> + -
> + - g\ :sub:`0`
> + - b\ :sub:`6`
> + - g\ :sub:`5`
> + - r\ :sub:`4`
> + * -
> + -
> + - 3
> + -
> + - g\ :sub:`1`
> + - b\ :sub:`7`
> + - g\ :sub:`6`
> + - r\ :sub:`5`
> + * -
> + -
> + - 4
> + -
> + - b\ :sub:`0`
> + - d
> + - g\ :sub:`7`
> + - r\ :sub:`6`
> + * -
> + -
> + - 5
> + -
> + - b\ :sub:`1`
> + - d
> + - b\ :sub:`2`
> + - r\ :sub:`7`
> + * -
> + -
> + - 6
> + -
> + - d
> + - d
> + - b\ :sub:`3`
> + - g\ :sub:`2`
>
> .. raw:: latex
>
> diff --git a/include/uapi/linux/media-bus-format.h
> b/include/uapi/linux/media-bus-format.h index 9e35117..5bea7c0 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x101b */
> +/* RGB - next is 0x101f */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -49,13 +49,16 @@
> #define MEDIA_BUS_FMT_RBG888_1X24 0x100e
> #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
> #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG 0x1010
> +#define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG_LE 0x101b
> #define MEDIA_BUS_FMT_BGR888_1X24 0x1013
> #define MEDIA_BUS_FMT_GBR888_1X24 0x1014
> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
> #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011
> +#define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG_LE 0x101c
> #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012
> +#define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA_LE 0x101d
> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
> #define MEDIA_BUS_FMT_RGB888_1X32_PADHI 0x100f
> #define MEDIA_BUS_FMT_RGB101010_1X30 0x1018
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacopo Mondi <jacopo+renesas@jmondi.org>
Cc: devicetree@vger.kernel.org, airlied@linux.ie,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org, peda@axentia.se,
linux-media@vger.kernel.org
Subject: Re: [PATCH 5/8] media: Add LE version of RGB LVDS formats
Date: Mon, 23 Apr 2018 16:06:01 +0300 [thread overview]
Message-ID: <1733883.PFymhGyeZa@avalon> (raw)
In-Reply-To: <1524130269-32688-6-git-send-email-jacopo+renesas@jmondi.org>
Hi Jacopo,
Thank you for the patch.
On Thursday, 19 April 2018 12:31:06 EEST Jacopo Mondi wrote:
> Some LVDS controller can output swapped versions of LVDS RGB formats.
> Define and document them in the list of supported media bus formats
I wouldn't introduce those new formats as we don't need them. As a general
rule we would like to have at least one user for any new format added to the
API.
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
> Documentation/media/uapi/v4l/subdev-formats.rst | 174 +++++++++++++++++++++
> include/uapi/linux/media-bus-format.h | 5 +-
> 2 files changed, 178 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/media/uapi/v4l/subdev-formats.rst
> b/Documentation/media/uapi/v4l/subdev-formats.rst index 9fcabe7..9a5263c
> 100644
> --- a/Documentation/media/uapi/v4l/subdev-formats.rst
> +++ b/Documentation/media/uapi/v4l/subdev-formats.rst
> @@ -1669,6 +1669,64 @@ JEIDA defined bit mapping will be named
> - b\ :sub:`2`
> - g\ :sub:`1`
> - r\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-RGB666-1X7X3-SPWG_LE:
> +
> + - MEDIA_BUS_FMT_RGB666_1X7X3_SPWG_LE
> + - 0x101b
> + - 0
> + -
> + -
> + - b\ :sub:`2`
> + - g\ :sub:`1`
> + - r\ :sub:`0`
> + * -
> + -
> + - 1
> + -
> + -
> + - b\ :sub:`3`
> + - g\ :sub:`2`
> + - r\ :sub:`1`
> + * -
> + -
> + - 2
> + -
> + -
> + - b\ :sub:`4`
> + - g\ :sub:`3`
> + - r\ :sub:`2`
> + * -
> + -
> + - 3
> + -
> + -
> + - b\ :sub:`5`
> + - g\ :sub:`4`
> + - r\ :sub:`3`
> + * -
> + -
> + - 4
> + -
> + -
> + - d
> + - g\ :sub:`5`
> + - r\ :sub:`4`
> + * -
> + -
> + - 5
> + -
> + -
> + - d
> + - b\ :sub:`0`
> + - r\ :sub:`5`
> + * -
> + -
> + - 6
> + -
> + -
> + - d
> + - b\ :sub:`1`
> + - g\ :sub:`0`
> * .. _MEDIA-BUS-FMT-RGB888-1X7X4-SPWG:
>
> - MEDIA_BUS_FMT_RGB888_1X7X4_SPWG
> @@ -1727,6 +1785,64 @@ JEIDA defined bit mapping will be named
> - b\ :sub:`2`
> - g\ :sub:`1`
> - r\ :sub:`0`
> + * .. _MEDIA-BUS-FMT-RGB888-1X7X4-SPWG_LE:
> +
> + - MEDIA_BUS_FMT_RGB888_1X7X4_SPWG_LE
> + - 0x101c
> + - 0
> + -
> + - r\ :sub:`6`
> + - b\ :sub:`2`
> + - g\ :sub:`1`
> + - r\ :sub:`0`
> + * -
> + -
> + - 1
> + -
> + - r\ :sub:`7`
> + - b\ :sub:`3`
> + - g\ :sub:`2`
> + - r\ :sub:`1`
> + * -
> + -
> + - 2
> + -
> + - g\ :sub:`6`
> + - b\ :sub:`4`
> + - g\ :sub:`3`
> + - r\ :sub:`2`
> + * -
> + -
> + - 3
> + -
> + - g\ :sub:`7`
> + - b\ :sub:`5`
> + - g\ :sub:`4`
> + - r\ :sub:`3`
> + * -
> + -
> + - 4
> + -
> + - b\ :sub:`6`
> + - d
> + - g\ :sub:`5`
> + - r\ :sub:`4`
> + * -
> + -
> + - 5
> + -
> + - b\ :sub:`7`
> + - d
> + - b\ :sub:`0`
> + - r\ :sub:`5`
> + * -
> + -
> + - 6
> + -
> + - d
> + - d
> + - b\ :sub:`1`
> + - g\ :sub:`0`
> * .. _MEDIA-BUS-FMT-RGB888-1X7X4-JEIDA:
>
> - MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA
> @@ -1785,6 +1901,64 @@ JEIDA defined bit mapping will be named
> - b\ :sub:`4`
> - g\ :sub:`3`
> - r\ :sub:`2`
> + * .. _MEDIA-BUS-FMT-RGB888-1X7X4-JEIDA_LE:
> +
> + - MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA_LE
> + - 0x101d
> + - 0
> + -
> + - r\ :sub:`0`
> + - b\ :sub:`4`
> + - g\ :sub:`3`
> + - r\ :sub:`2`
> + * -
> + -
> + - 1
> + -
> + - r\ :sub:`1`
> + - b\ :sub:`5`
> + - g\ :sub:`4`
> + - r\ :sub:`3`
> + * -
> + -
> + - 2
> + -
> + - g\ :sub:`0`
> + - b\ :sub:`6`
> + - g\ :sub:`5`
> + - r\ :sub:`4`
> + * -
> + -
> + - 3
> + -
> + - g\ :sub:`1`
> + - b\ :sub:`7`
> + - g\ :sub:`6`
> + - r\ :sub:`5`
> + * -
> + -
> + - 4
> + -
> + - b\ :sub:`0`
> + - d
> + - g\ :sub:`7`
> + - r\ :sub:`6`
> + * -
> + -
> + - 5
> + -
> + - b\ :sub:`1`
> + - d
> + - b\ :sub:`2`
> + - r\ :sub:`7`
> + * -
> + -
> + - 6
> + -
> + - d
> + - d
> + - b\ :sub:`3`
> + - g\ :sub:`2`
>
> .. raw:: latex
>
> diff --git a/include/uapi/linux/media-bus-format.h
> b/include/uapi/linux/media-bus-format.h index 9e35117..5bea7c0 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -34,7 +34,7 @@
>
> #define MEDIA_BUS_FMT_FIXED 0x0001
>
> -/* RGB - next is 0x101b */
> +/* RGB - next is 0x101f */
> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> @@ -49,13 +49,16 @@
> #define MEDIA_BUS_FMT_RBG888_1X24 0x100e
> #define MEDIA_BUS_FMT_RGB666_1X24_CPADHI 0x1015
> #define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG 0x1010
> +#define MEDIA_BUS_FMT_RGB666_1X7X3_SPWG_LE 0x101b
> #define MEDIA_BUS_FMT_BGR888_1X24 0x1013
> #define MEDIA_BUS_FMT_GBR888_1X24 0x1014
> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a
> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b
> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c
> #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011
> +#define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG_LE 0x101c
> #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012
> +#define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA_LE 0x101d
> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d
> #define MEDIA_BUS_FMT_RGB888_1X32_PADHI 0x100f
> #define MEDIA_BUS_FMT_RGB101010_1X30 0x1018
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-23 13:06 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 9:31 [PATCH 0/8] drm: bridge: Add support for static image formats Jacopo Mondi
2018-04-19 9:31 ` [PATCH 1/8] " Jacopo Mondi
2018-04-22 20:02 ` Peter Rosin
2018-04-26 18:44 ` jacopo mondi
2018-04-26 18:44 ` jacopo mondi
2018-04-23 9:27 ` Laurent Pinchart
2018-04-23 9:27 ` Laurent Pinchart
2018-04-26 18:40 ` jacopo mondi
2018-04-26 18:40 ` jacopo mondi
2018-04-26 19:57 ` Laurent Pinchart
2018-04-26 19:57 ` Laurent Pinchart
2018-04-19 9:31 ` [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Jacopo Mondi
2018-04-22 20:02 ` Peter Rosin
2018-04-23 7:35 ` jacopo mondi
2018-04-23 7:35 ` jacopo mondi
2018-04-23 11:59 ` Laurent Pinchart
2018-04-23 11:59 ` Laurent Pinchart
2018-04-23 12:02 ` Laurent Pinchart
2018-04-23 12:02 ` Laurent Pinchart
2018-04-24 16:37 ` Rob Herring
2018-04-24 16:37 ` Rob Herring
2018-04-19 9:31 ` [PATCH 3/8] drm: bridge: thc63lvd1024: Add support for LVDS mode map Jacopo Mondi
2018-04-22 20:02 ` Peter Rosin
2018-04-23 7:41 ` jacopo mondi
2018-04-23 12:12 ` Laurent Pinchart
2018-04-23 12:12 ` Laurent Pinchart
2018-04-23 12:08 ` Laurent Pinchart
2018-04-23 12:08 ` Laurent Pinchart
2018-04-19 9:31 ` [PATCH 4/8] arm64: dts: renesas: eagle: Add thc63 LVDS map Jacopo Mondi
2018-04-23 10:29 ` Simon Horman
2018-04-23 13:07 ` Laurent Pinchart
2018-04-23 13:07 ` Laurent Pinchart
2018-04-19 9:31 ` [PATCH 5/8] media: Add LE version of RGB LVDS formats Jacopo Mondi
2018-04-23 13:06 ` Laurent Pinchart [this message]
2018-04-23 13:06 ` Laurent Pinchart
2018-04-24 7:16 ` jacopo mondi
2018-04-24 7:16 ` jacopo mondi
2018-04-19 9:31 ` [PATCH 6/8] drm: rcar-du: rcar-lvds: Add bridge format support Jacopo Mondi
2018-04-22 20:08 ` Peter Rosin
2018-04-23 7:28 ` jacopo mondi
2018-04-23 7:28 ` jacopo mondi
2018-04-23 7:59 ` Peter Rosin
2018-04-23 8:47 ` jacopo mondi
2018-04-23 8:47 ` jacopo mondi
2018-04-23 12:59 ` Laurent Pinchart
2018-04-23 12:59 ` Laurent Pinchart
2018-04-19 9:31 ` [PATCH 7/8] drm: panel: Use _LE LVDS formats for data mirroring Jacopo Mondi
2018-04-19 9:31 ` [PATCH 8/8] drm: connector: Remove DRM_BUS_FLAG_DATA_* flags Jacopo Mondi
2018-04-23 21:03 ` Laurent Pinchart
2018-04-23 21:03 ` Laurent Pinchart
2018-04-24 7:22 ` jacopo mondi
2018-04-24 7:22 ` jacopo mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1733883.PFymhGyeZa@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacopo+renesas@jmondi.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.