From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH] net/mlx5: fix handling of small mbuf sizes
Date: Mon, 07 Nov 2016 18:22:59 +0100 [thread overview]
Message-ID: <1734224.1G63DZ4fph@xps13> (raw)
In-Reply-To: <20161028121906.GW5733@6wind.com>
2016-10-28 14:19, Adrien Mazarguil:
> On Mon, Oct 24, 2016 at 11:10:59AM +0300, Raslan Darawsheh wrote:
> > When mbufs are smaller than MRU, multi-segment support must be enabled to
> > default set when not in promiscuous or allmulticast modes.
> >
> > Fixes: 9964b965ad69 ("net/mlx5: re-add Rx scatter support")
> >
> > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
[...]
> > + /* If smaller than MRU, multi-segment support must be enabled. */
> > + if (mb_len < (priv->mtu > dev->data->dev_conf.rxmode.max_rx_pkt_len ?
> > + dev->data->dev_conf.rxmode.max_rx_pkt_len :
> > + priv->mtu
> > + ))
>
> Let's move poor "))" to the end of the previous line.
[...]
> Besides the above comment:
>
> Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Fixed and applied, thanks
prev parent reply other threads:[~2016-11-07 17:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 8:10 [PATCH] net/mlx5: fix handling of small mbuf sizes Raslan Darawsheh
2016-10-28 12:19 ` Adrien Mazarguil
2016-11-07 17:22 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1734224.1G63DZ4fph@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=rasland@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.