All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Muezerie <andremue@linux.microsoft.com>
To: andremue@linux.microsoft.com
Cc: dev@dpdk.org, mb@smartsharesystems.com
Subject: [PATCH v2 4/5] drivers/net: use portable version of __builtin_add_overflow
Date: Fri,  3 Jan 2025 12:39:40 -0800	[thread overview]
Message-ID: <1735936781-24199-5-git-send-email-andremue@linux.microsoft.com> (raw)
In-Reply-To: <1735936781-24199-1-git-send-email-andremue@linux.microsoft.com>

__builtin_add_overflow is gcc specific. It should be replaced with
a portable version that can also be used with other compilers.

Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
---
 drivers/net/ice/base/ice_nvm.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/ice/base/ice_nvm.c b/drivers/net/ice/base/ice_nvm.c
index 56c6c96a95..1002a6b59f 100644
--- a/drivers/net/ice/base/ice_nvm.c
+++ b/drivers/net/ice/base/ice_nvm.c
@@ -3,6 +3,7 @@
  */
 
 #include "ice_common.h"
+#include <rte_math.h>
 
 #define GL_MNG_DEF_DEVID 0x000B611C
 
@@ -469,8 +470,6 @@ int ice_read_sr_word(struct ice_hw *hw, u16 offset, u16 *data)
 	return status;
 }
 
-#define check_add_overflow __builtin_add_overflow
-
 /**
  * ice_get_pfa_module_tlv - Reads sub module TLV from NVM PFA
  * @hw: pointer to hardware structure
@@ -500,7 +499,7 @@ ice_get_pfa_module_tlv(struct ice_hw *hw, u16 *module_tlv, u16 *module_tlv_len,
 		return status;
 	}
 
-	if (check_add_overflow(pfa_ptr, (u16)(pfa_len - 1), &max_tlv)) {
+	if (rte_add_overflow(pfa_ptr, (u16)(pfa_len - 1), &max_tlv)) {
 		ice_debug(hw, ICE_DBG_INIT, "PFA starts at offset %u. PFA length of %u caused 16-bit arithmetic overflow.\n",
 				  pfa_ptr, pfa_len);
 		return ICE_ERR_INVAL_SIZE;
@@ -541,8 +540,8 @@ ice_get_pfa_module_tlv(struct ice_hw *hw, u16 *module_tlv, u16 *module_tlv_len,
 			return ICE_ERR_INVAL_SIZE;
 		}
 
-		if (check_add_overflow(next_tlv, (u16)2, &next_tlv) ||
-		    check_add_overflow(next_tlv, tlv_len, &next_tlv)) {
+		if (rte_add_overflow(next_tlv, (u16)2, &next_tlv) ||
+		    rte_add_overflow(next_tlv, tlv_len, &next_tlv)) {
 			ice_debug(hw, ICE_DBG_INIT, "TLV of type %u and length 0x%04x caused 16-bit arithmetic overflow. The PFA starts at 0x%04x and has length of 0x%04x\n",
 					  tlv_sub_module_type, tlv_len, pfa_ptr, pfa_len);
 			return ICE_ERR_INVAL_SIZE;
-- 
2.47.0.vfs.0.3


  parent reply	other threads:[~2025-01-03 20:40 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 22:32 [PATCH 0/5] add portable version of __builtin_add_overflow Andre Muezerie
2025-01-02 22:32 ` [PATCH 1/5] maintainers: " Andre Muezerie
2025-01-02 22:32 ` [PATCH 2/5] lib/eal: " Andre Muezerie
2025-01-03  8:19   ` Morten Brørup
2025-01-03 20:38     ` Andre Muezerie
2025-01-02 22:32 ` [PATCH 3/5] doc/api: " Andre Muezerie
2025-01-02 22:32 ` [PATCH 4/5] drivers/net: use " Andre Muezerie
2025-01-02 22:32 ` [PATCH 5/5] app/test: add tests for portable versions " Andre Muezerie
2025-01-02 23:51 ` [PATCH 0/5] add portable version " Stephen Hemminger
2025-01-03  0:15   ` Andre Muezerie
2025-01-03  0:41     ` Andre Muezerie
2025-01-03 20:39 ` [PATCH v2 " Andre Muezerie
2025-01-03 20:39   ` [PATCH v2 1/5] maintainers: " Andre Muezerie
2025-01-03 20:39   ` [PATCH v2 2/5] lib/eal: " Andre Muezerie
2025-01-06 11:07     ` Bruce Richardson
2025-01-06 11:21       ` Morten Brørup
2025-01-06 11:34         ` Bruce Richardson
2025-01-06 11:58           ` Morten Brørup
2025-03-05 15:46             ` Andre Muezerie
2025-01-03 20:39   ` [PATCH v2 3/5] doc/api: " Andre Muezerie
2025-01-03 20:39   ` Andre Muezerie [this message]
2025-01-03 20:39   ` [PATCH v2 5/5] app/test: add tests for " Andre Muezerie
2025-03-05 16:38 ` [PATCH v3 0/5] add " Andre Muezerie
2025-03-05 16:38   ` [PATCH v3 1/5] maintainers: " Andre Muezerie
2025-03-05 16:38   ` [PATCH v3 2/5] eal: " Andre Muezerie
2025-03-05 16:38   ` [PATCH v3 3/5] doc/api: " Andre Muezerie
2025-03-05 16:38   ` [PATCH v3 4/5] net/intel: use " Andre Muezerie
2025-03-05 16:52     ` Bruce Richardson
2025-03-11 18:39       ` Andre Muezerie
2025-03-05 16:38   ` [PATCH v3 5/5] app/test: add tests for " Andre Muezerie
2025-03-06  3:00     ` Patrick Robb
2025-03-13 20:00 ` [PATCH v4 0/5] add " Andre Muezerie
2025-03-13 20:00   ` [PATCH v4 1/5] maintainers: " Andre Muezerie
2025-03-14  8:39     ` Bruce Richardson
2025-03-13 20:00   ` [PATCH v4 2/5] eal: " Andre Muezerie
2025-03-13 20:00   ` [PATCH v4 3/5] doc/api: " Andre Muezerie
2025-03-14  8:40     ` Bruce Richardson
2025-03-13 20:00   ` [PATCH v4 4/5] net/intel: use " Andre Muezerie
2025-03-13 20:00   ` [PATCH v4 5/5] app/test: add tests for " Andre Muezerie
2025-03-14 14:33 ` [PATCH v5 0/3] add " Andre Muezerie
2025-03-14 14:33   ` [PATCH v5 1/3] eal: " Andre Muezerie
2025-03-14 14:33   ` [PATCH v5 2/3] net/intel: use " Andre Muezerie
2025-03-14 14:46     ` Bruce Richardson
2025-03-14 14:33   ` [PATCH v5 3/3] app/test: add tests for " Andre Muezerie
2025-06-04 10:08   ` [PATCH v5 0/3] add " David Marchand
2025-06-04 10:29     ` Morten Brørup
2025-06-04 10:41       ` David Marchand
2025-06-04 11:04         ` Morten Brørup
2025-06-04 11:39           ` Thomas Monjalon
2025-06-05 14:47 ` [PATCH v6 0/1] define __builtin_add_overflow for MSVC Andre Muezerie
2025-06-05 14:47   ` [PATCH v6 1/1] net/intel: " Andre Muezerie
2025-06-05 14:57     ` Morten Brørup
2025-06-09 15:45       ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1735936781-24199-5-git-send-email-andremue@linux.microsoft.com \
    --to=andremue@linux.microsoft.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.