From: Tomasz Figa <tomasz.figa@gmail.com>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Yadwinder Singh Brar <yadi.brar@samsung.com>,
linux-doc@vger.kernel.org, Padmavathi Venna <padma.v@samsung.com>,
Tomasz Figa <t.figa@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tushar Behera <tushar.behera@linaro.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Sachin Kamat <sachin.kamat@linaro.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <rob.herring@calxeda.com>,
Kukjin Kim <kgene.kim@samsung.com>,
Mike Turquette <mturquette@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Rahul Sharma <rahul.sharma@samsung.com>,
Jiri Kosina <jkosina@suse.cz>Stephe
Subject: Re: [PATCH 1/6] clk: exynos-audss: convert to platform device
Date: Mon, 23 Sep 2013 23:30:17 +0200 [thread overview]
Message-ID: <1736317.9RH9hT0fWO@flatron> (raw)
In-Reply-To: <CAL1qeaGjUTrfDaAr1rgsgDaZscjaV7tqi3Jd_-zo2sMtCCFSAQ@mail.gmail.com>
On Monday 23 of September 2013 14:25:12 Andrew Bresticker wrote:
> >> +static int __init exynos_audss_clk_init(void)
> >> +{
> >> + return platform_driver_register(&exynos_audss_clk_driver);
> >> +}
> >> +core_initcall(exynos_audss_clk_init);
> >
> > Does it need to be core_initcall? Drivers depending on clocks provided
> > by this driver should be able to defer probing if they are probed
> > before this driver.
>
> Unfortunately there are a couple of issues with making this a
> module_initcall: 1. On the Exynos5420, the AudioSS block provides the
> apb_pclk gate for the ADMA bus, which is probed at postcore_initcall
> time and does not support deferred probing, and
Just out of curiosity, what is this ADMA bus?
Anyway, I'm fine with this, just wanted to make sure that there is a
reason behind it.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] clk: exynos-audss: convert to platform device
Date: Mon, 23 Sep 2013 23:30:17 +0200 [thread overview]
Message-ID: <1736317.9RH9hT0fWO@flatron> (raw)
In-Reply-To: <CAL1qeaGjUTrfDaAr1rgsgDaZscjaV7tqi3Jd_-zo2sMtCCFSAQ@mail.gmail.com>
On Monday 23 of September 2013 14:25:12 Andrew Bresticker wrote:
> >> +static int __init exynos_audss_clk_init(void)
> >> +{
> >> + return platform_driver_register(&exynos_audss_clk_driver);
> >> +}
> >> +core_initcall(exynos_audss_clk_init);
> >
> > Does it need to be core_initcall? Drivers depending on clocks provided
> > by this driver should be able to defer probing if they are probed
> > before this driver.
>
> Unfortunately there are a couple of issues with making this a
> module_initcall: 1. On the Exynos5420, the AudioSS block provides the
> apb_pclk gate for the ADMA bus, which is probed at postcore_initcall
> time and does not support deferred probing, and
Just out of curiosity, what is this ADMA bus?
Anyway, I'm fine with this, just wanted to make sure that there is a
reason behind it.
Best regards,
Tomasz
next prev parent reply other threads:[~2013-09-23 21:30 UTC|newest]
Thread overview: 121+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-20 21:13 [PATCH 1/6] clk: exynos-audss: convert to platform device Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` [PATCH 2/6] clk: exynos-audss: allow input clocks to be specified in device tree Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
[not found] ` <1379711637-5226-2-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-09-21 15:12 ` Tomasz Figa
2013-09-21 15:12 ` Tomasz Figa
2013-09-21 15:12 ` Tomasz Figa
[not found] ` <1379711637-5226-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-09-20 21:13 ` [PATCH 3/6] clk: exynos5250: add clock ID for div_pcm0 Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-21 15:19 ` Tomasz Figa
2013-09-21 15:19 ` Tomasz Figa
2013-09-21 15:19 ` Tomasz Figa
2013-09-21 12:50 ` [PATCH 1/6] clk: exynos-audss: convert to platform device Tomasz Figa
2013-09-21 12:50 ` Tomasz Figa
2013-09-21 12:50 ` Tomasz Figa
2013-09-23 21:25 ` Andrew Bresticker
2013-09-23 21:25 ` Andrew Bresticker
2013-09-23 21:30 ` Tomasz Figa [this message]
2013-09-23 21:30 ` Tomasz Figa
2013-09-23 21:36 ` Andrew Bresticker
2013-09-23 21:36 ` Andrew Bresticker
[not found] ` <CAL1qeaGjUTrfDaAr1rgsgDaZscjaV7tqi3Jd_-zo2sMtCCFSAQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-23 22:50 ` Sylwester Nawrocki
2013-09-23 22:50 ` Sylwester Nawrocki
2013-09-23 22:50 ` Sylwester Nawrocki
2013-09-20 21:13 ` [PATCH 4/6] ARM: dts: exynos5250: add sclk_pcm_in to audss clock controller Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-21 15:13 ` Tomasz Figa
2013-09-21 15:13 ` Tomasz Figa
2013-09-21 15:13 ` Tomasz Figa
2013-09-20 21:13 ` [PATCH 5/6] clk: exynos-audss: add support for Exynos 5420 Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-21 15:17 ` Tomasz Figa
2013-09-21 15:17 ` Tomasz Figa
2013-09-21 15:17 ` Tomasz Figa
2013-09-20 21:13 ` [PATCH 6/6] ARM: dts: exynos5420: add sclk_pcm_in to audss clock controller Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
2013-09-20 21:13 ` Andrew Bresticker
[not found] ` <1379711637-5226-6-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-09-21 15:18 ` Tomasz Figa
2013-09-21 15:18 ` Tomasz Figa
2013-09-21 15:18 ` Tomasz Figa
2013-09-24 0:21 ` [PATCH V2 1/6] clk: exynos-audss: convert to platform device Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
2013-09-24 0:21 ` [PATCH V2 2/6] clk: exynos-audss: allow input clocks to be specified in device tree Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
2013-09-24 0:21 ` [PATCH V2 3/6] clk: exynos5250: add clock ID for div_pcm0 Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
2013-09-24 0:21 ` [PATCH V2 4/6] ARM: dts: exynos5250: add input clocks to audss clock controller Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
[not found] ` <1379982078-23381-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-09-24 0:21 ` [PATCH V2 5/6] clk: exynos-audss: add support for Exynos 5420 Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
2013-09-24 9:35 ` [PATCH V2 1/6] clk: exynos-audss: convert to platform device Sylwester Nawrocki
2013-09-24 9:35 ` Sylwester Nawrocki
2013-09-24 9:35 ` Sylwester Nawrocki
2013-09-24 0:21 ` [PATCH V2 6/6] ARM: dts: exynos5420: add input clocks to audss clock controller Andrew Bresticker
2013-09-24 0:21 ` Andrew Bresticker
2013-09-24 9:20 ` [PATCH V2 1/6] clk: exynos-audss: convert to platform device Tomasz Figa
2013-09-24 9:20 ` Tomasz Figa
2013-09-24 9:20 ` Tomasz Figa
2013-09-24 9:47 ` Sylwester Nawrocki
2013-09-24 9:47 ` Sylwester Nawrocki
2013-09-24 18:06 ` [PATCH V3 " Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` [PATCH V3 2/6] clk: exynos-audss: allow input clocks to be specified in device tree Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` [PATCH V3 4/6] ARM: dts: exynos5250: add input clocks to audss clock controller Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` [PATCH V3 5/6] clk: exynos-audss: add support for Exynos 5420 Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
[not found] ` <1380046016-5811-1-git-send-email-abrestic-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2013-09-24 18:06 ` [PATCH V3 3/6] clk: exynos5250: add clock ID for div_pcm0 Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` [PATCH V3 6/6] ARM: dts: exynos5420: add input clocks to audss clock controller Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 18:06 ` Andrew Bresticker
2013-09-24 19:17 ` [PATCH V3 1/6] clk: exynos-audss: convert to platform device Tomasz Figa
2013-09-24 19:17 ` Tomasz Figa
2013-09-24 19:17 ` Tomasz Figa
2013-09-24 21:15 ` Sylwester Nawrocki
2013-09-24 21:15 ` Sylwester Nawrocki
2013-09-24 21:15 ` Sylwester Nawrocki
2013-09-24 22:12 ` Andrew Bresticker
2013-09-24 22:12 ` Andrew Bresticker
2013-09-24 22:12 ` Andrew Bresticker
[not found] ` <CAL1qeaEpu=YRasZpSvrCTNwC6OGWZgECjwDSFgkAN07eWObmrg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-09-24 22:31 ` Sylwester Nawrocki
2013-09-24 22:16 ` Stephen Boyd
2013-09-24 22:16 ` Stephen Boyd
2013-09-24 22:16 ` Stephen Boyd
2013-09-25 21:12 ` [PATCH V4 " Andrew Bresticker
2013-09-25 21:12 ` Andrew Bresticker
2013-09-25 21:12 ` [PATCH V4 2/6] clk: exynos-audss: allow input clocks to be specified in device tree Andrew Bresticker
2013-09-25 21:12 ` Andrew Bresticker
2013-09-25 21:12 ` [PATCH V4 3/6] clk: exynos5250: add clock ID for div_pcm0 Andrew Bresticker
2013-09-25 21:12 ` Andrew Bresticker
2013-09-25 21:12 ` [PATCH V4 4/6] ARM: dts: exynos5250: add input clocks to audss clock controller Andrew Bresticker
2013-09-25 21:12 ` Andrew Bresticker
2013-09-25 21:12 ` [PATCH V4 5/6] clk: exynos-audss: add support for Exynos 5420 Andrew Bresticker
2013-09-25 21:12 ` Andrew Bresticker
2013-09-25 21:12 ` [PATCH V4 6/6] ARM: dts: exynos5420: add input clocks to audss clock controller Andrew Bresticker
2013-09-25 21:12 ` Andrew Bresticker
2013-10-08 16:53 ` [PATCH V4 1/6] clk: exynos-audss: convert to platform device Andrew Bresticker
2013-10-08 16:53 ` Andrew Bresticker
2013-11-26 6:29 ` Padma Venkat
2013-11-26 6:29 ` Padma Venkat
2013-11-27 18:41 ` Mike Turquette
2013-11-27 18:41 ` Mike Turquette
2013-12-01 22:43 ` Kukjin Kim
2013-12-01 22:43 ` Kukjin Kim
2014-01-02 15:20 ` Tomasz Figa
2014-01-02 15:20 ` Tomasz Figa
2014-01-04 2:47 ` kgene
2014-01-04 2:47 ` kgene at kernel.org
2013-11-27 18:40 ` Mike Turquette
2013-11-27 18:40 ` Mike Turquette
2013-11-27 18:40 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1736317.9RH9hT0fWO@flatron \
--to=tomasz.figa@gmail.com \
--cc=abrestic@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jkosina@suse.cz \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=padma.v@samsung.com \
--cc=pawel.moll@arm.com \
--cc=rahul.sharma@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=sachin.kamat@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=t.figa@samsung.com \
--cc=tushar.behera@linaro.org \
--cc=yadi.brar@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.