[PATCH v2 0/4] ARM: config: stm32: Remove useless flags

[PATCH v2 0/4] ARM: config: stm32: Remove useless flags

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@foss.st.com>

Running "make savedefconfig" highlights that some flags are no more used,
remove them.
Remove some flags to reduce the kernel image size as STM32 MCU's board
embeds low amount of RAM.

Changes in V2:
  _ squash patches 2-7
  _ split patch 1 in three parts and add epxlanations about flags removal.

Patrice Chotard (4):
  ARM: configs: stm32: Remove FLASH_MEM_BASE and FLASH_SIZE in STM32
    defconfig
  ARM: configs: stm32: Clean STM32 defconfig
  ARM: configs: stm32: Remove CRYPTO in STM32 defconfig
  ARM: configs: stm32: Remove useless flags in STM32 defconfig

 arch/arm/configs/stm32_defconfig | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

-- 
2.25.1

[PATCH v2 1/4] ARM: configs: stm32: Remove FLASH_MEM_BASE and FLASH_SIZE in STM32 defconfig

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@foss.st.com>

Running make savedefconfig highlights some useless flags.

Remove FLASH_MEM_BASE and FLASH_SIZE as these 2 flags are only
used by CPU_ARM740T,CPU_ARM940T and CPU_ARM946E which is not the
case here for CPU_V7M.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 arch/arm/configs/stm32_defconfig | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index 3baec075d1ef..973bf7c8236b 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -18,8 +18,6 @@ CONFIG_ARCH_STM32=y
 CONFIG_CPU_V7M_NUM_IRQ=240
 CONFIG_SET_MEM_PARAM=y
 CONFIG_DRAM_BASE=0x90000000
-CONFIG_FLASH_MEM_BASE=0x08000000
-CONFIG_FLASH_SIZE=0x00200000
 # CONFIG_ATAGS is not set
 CONFIG_XIP_KERNEL=y
 CONFIG_XIP_PHYS_ADDR=0x08008000
-- 
2.25.1

[PATCH v2 2/4] ARM: configs: stm32: Clean STM32 defconfig

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@foss.st.com>

Running make savedefconfig highlights some useless flags.

Since 54a48aa3d558 ("Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK")
flag ENABLE_MUST_CHECK has been removed.

Since 35260cf54522 ("Kconfig.debug: fix SCHED_DEBUG dependency")
SCHED_DEBUG depends on DEBUG_KERNEL and PROC_FS.
As PROC_FS is not set, SCHED_DEBUG reference can be removed.

Since 78011042684d ("scsi: bsg: Move bsg_scsi_ops to drivers/scsi/")
BLK_DEV_BSG depends on SCSI. As SCSI is not set, BLK_DEV_BSG reference
can be removed.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 arch/arm/configs/stm32_defconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index 973bf7c8236b..be7b63036730 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -12,7 +12,6 @@ CONFIG_BASE_SMALL=y
 # CONFIG_SIGNALFD is not set
 # CONFIG_EVENTFD is not set
 # CONFIG_AIO is not set
-# CONFIG_BLK_DEV_BSG is not set
 # CONFIG_MMU is not set
 CONFIG_ARCH_STM32=y
 CONFIG_CPU_V7M_NUM_IRQ=240
@@ -72,10 +71,8 @@ CONFIG_NLS=y
 CONFIG_CRC_ITU_T=y
 CONFIG_CRC7=y
 CONFIG_PRINTK_TIME=y
-# CONFIG_ENABLE_MUST_CHECK is not set
 # CONFIG_DEBUG_BUGVERBOSE is not set
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SLUB_DEBUG is not set
-# CONFIG_SCHED_DEBUG is not set
 CONFIG_CRYPTO=y
-- 
2.25.1

[PATCH v2 3/4] ARM: configs: stm32: Remove CRYPTO in STM32 defconfig

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@foss.st.com>

Running make savedefconfig highlights some useless flags.

Since 1c92d4a0edcf ("ARM: configs: stm32: Enable MMC_ARMMMCI and EXT3_FS support")
CRYPTO is selected by EXT3_FS, so CRYPTO can be removed in stm32_defconfig.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 arch/arm/configs/stm32_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index be7b63036730..d62a0c0b7ce5 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -75,4 +75,3 @@ CONFIG_PRINTK_TIME=y
 CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
 CONFIG_MAGIC_SYSRQ=y
 # CONFIG_SLUB_DEBUG is not set
-CONFIG_CRYPTO=y
-- 
2.25.1

[PATCH v2 4/4] ARM: configs: stm32: Remove useless flags in STM32 defconfig

[patrice.chotard]

From: Patrice Chotard <patrice.chotard@foss.st.com>

As stm32_defconfig is dedicated to STM32 MCUs, disable
CONFIG_COMMON_CLK_STM32MP flag which is only used by STM32 MPUs.

Disable CONFIG_SUSPEND, CONFIG_ADVISE_SYSCALLS, CONFIG_IO_URING
CONFIG_POSIX_TIMERS, CONFIG_GCC_PLUGINS, it will reduce the kernel
image size for these platforms which embed a low amount of memory.

Tested on STM32F746-DISCO board which embeds 8MB of memory.

Signed-off-by: Patrice Chotard <patrice.chotard@foss.st.com>
---
 arch/arm/configs/stm32_defconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig
index d62a0c0b7ce5..77048b5e1ec4 100644
--- a/arch/arm/configs/stm32_defconfig
+++ b/arch/arm/configs/stm32_defconfig
@@ -6,12 +6,15 @@ CONFIG_BLK_DEV_INITRD=y
 CONFIG_CC_OPTIMIZE_FOR_SIZE=y
 CONFIG_EXPERT=y
 # CONFIG_UID16 is not set
+# CONFIG_POSIX_TIMERS is not set
 CONFIG_BASE_SMALL=y
 # CONFIG_FUTEX is not set
 # CONFIG_EPOLL is not set
 # CONFIG_SIGNALFD is not set
 # CONFIG_EVENTFD is not set
 # CONFIG_AIO is not set
+# CONFIG_IO_URING is not set
+# CONFIG_ADVISE_SYSCALLS is not set
 # CONFIG_MMU is not set
 CONFIG_ARCH_STM32=y
 CONFIG_CPU_V7M_NUM_IRQ=240
@@ -20,6 +23,8 @@ CONFIG_DRAM_BASE=0x90000000
 # CONFIG_ATAGS is not set
 CONFIG_XIP_KERNEL=y
 CONFIG_XIP_PHYS_ADDR=0x08008000
+# CONFIG_SUSPEND is not set
+# CONFIG_GCC_PLUGINS is not set
 CONFIG_BINFMT_FLAT=y
 # CONFIG_COREDUMP is not set
 # CONFIG_VM_EVENT_COUNTERS is not set
@@ -60,6 +65,7 @@ CONFIG_DMADEVICES=y
 CONFIG_STM32_DMA=y
 CONFIG_STM32_DMAMUX=y
 CONFIG_STM32_MDMA=y
+# CONFIG_COMMON_CLK_STM32MP is not set
 CONFIG_IIO=y
 CONFIG_STM32_ADC_CORE=y
 CONFIG_STM32_ADC=y
-- 
2.25.1

Re: [PATCH v2 4/4] ARM: configs: stm32: Remove useless flags in STM32 defconfig

[Arnd Bergmann]

On Fri, Dec 20, 2024, at 13:55, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> As stm32_defconfig is dedicated to STM32 MCUs, disable
> CONFIG_COMMON_CLK_STM32MP flag which is only used by STM32 MPUs.
>
> Disable CONFIG_SUSPEND, CONFIG_ADVISE_SYSCALLS, CONFIG_IO_URING
> CONFIG_POSIX_TIMERS, CONFIG_GCC_PLUGINS, it will reduce the kernel
> image size for these platforms which embed a low amount of memory.
>
> Tested on STM32F746-DISCO board which embeds 8MB of memory.

Out of curiosity, what is the smallest memory configuration that
you see people using on stm32f7/h7 these days? I know we had
configs that kind-of worked on 2MB in the past, but I assume there
has been a lot of bloat since.

       Arnd

Re: [PATCH v2 4/4] ARM: configs: stm32: Remove useless flags in STM32 defconfig

[Patrice CHOTARD]

On 12/20/24 18:06, Arnd Bergmann wrote:
> On Fri, Dec 20, 2024, at 13:55, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> As stm32_defconfig is dedicated to STM32 MCUs, disable
>> CONFIG_COMMON_CLK_STM32MP flag which is only used by STM32 MPUs.
>>
>> Disable CONFIG_SUSPEND, CONFIG_ADVISE_SYSCALLS, CONFIG_IO_URING
>> CONFIG_POSIX_TIMERS, CONFIG_GCC_PLUGINS, it will reduce the kernel
>> image size for these platforms which embed a low amount of memory.
>>
>> Tested on STM32F746-DISCO board which embeds 8MB of memory.
> 
> Out of curiosity, what is the smallest memory configuration that
> you see people using on stm32f7/h7 these days? I know we had
> configs that kind-of worked on 2MB in the past, but I assume there
> has been a lot of bloat since.
> 
>        Arnd

Hi Arnd

Currently, i have no idea about what is the smallest memory configuration on stm32f4/f7/h7
used by people using these SoCs. As you said, kernel Linux size is increasing version after version.

My goal was just to ensure that official ST boards are still booting a kernel Linux.

Patrice

Re: [PATCH v2 0/4] ARM: config: stm32: Remove useless flags

[Arnd Bergmann]

On Fri, Dec 20, 2024, at 13:55, patrice.chotard@foss.st.com wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
>
> Running "make savedefconfig" highlights that some flags are no more used,
> remove them.
> Remove some flags to reduce the kernel image size as STM32 MCU's board
> embeds low amount of RAM.
>
> Changes in V2:
>   _ squash patches 2-7
>   _ split patch 1 in three parts and add epxlanations about flags removal.

Looks good to me, thanks for the update. I assume the plan is to
have this in another pull request rather than me picking up the
patches directly, right?


Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH v2 0/4] ARM: config: stm32: Remove useless flags

[Olof Johansson]

On Fri, Dec 20, 2024 at 05:47:01PM +0100, Arnd Bergmann wrote:
> On Fri, Dec 20, 2024, at 13:55, patrice.chotard@foss.st.com wrote:
> > From: Patrice Chotard <patrice.chotard@foss.st.com>
> >
> > Running "make savedefconfig" highlights that some flags are no more used,
> > remove them.
> > Remove some flags to reduce the kernel image size as STM32 MCU's board
> > embeds low amount of RAM.
> >
> > Changes in V2:
> >   _ squash patches 2-7
> >   _ split patch 1 in three parts and add epxlanations about flags removal.
> 
> Looks good to me, thanks for the update. I assume the plan is to
> have this in another pull request rather than me picking up the
> patches directly, right?

On that note, I would *love* to no longer get patches into my inbox,
and I'll start to kindly request the senders of said patches to take
me off the recipients in the future. I'm not actively part of the soc
maintainer group any more, but I'm guessing that the others would benefit
from the same.

STM32 already has a maintainer, so there's no need to send these directly
to the soc-level maintainers, as far as I can tell. And certainly not
in the to: line (vs cc), at that.

If there's reason to send them directly, such as the platform maintainer
being unavailable or the patch being urgent as a fix, a justification
to make sure they're not missed would be useful.


-Olof

Re: [PATCH v2 0/4] ARM: config: stm32: Remove useless flags

[Alexandre TORGUE]

Hi Arnd

On 12/20/24 17:47, Arnd Bergmann wrote:
> On Fri, Dec 20, 2024, at 13:55, patrice.chotard@foss.st.com wrote:
>> From: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Running "make savedefconfig" highlights that some flags are no more used,
>> remove them.
>> Remove some flags to reduce the kernel image size as STM32 MCU's board
>> embeds low amount of RAM.
>>
>> Changes in V2:
>>    _ squash patches 2-7
>>    _ split patch 1 in three parts and add epxlanations about flags removal.
> 
> Looks good to me, thanks for the update. I assume the plan is to
> have this in another pull request rather than me picking up the
> patches directly, right?

I don't plan to send a second round so you can take it directly.

Thanks
Alex

> 
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Re: [PATCH v2 0/4] ARM: config: stm32: Remove useless flags

[patchwork-bot+linux-soc]

Hello:

This series was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Fri, 20 Dec 2024 13:55:02 +0100 you wrote:
> From: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Running "make savedefconfig" highlights that some flags are no more used,
> remove them.
> Remove some flags to reduce the kernel image size as STM32 MCU's board
> embeds low amount of RAM.
> 
> [...]

Here is the summary with links:
  - [v2,1/4] ARM: configs: stm32: Remove FLASH_MEM_BASE and FLASH_SIZE in STM32 defconfig
    https://git.kernel.org/soc/soc/c/8637f225c5e5
  - [v2,2/4] ARM: configs: stm32: Clean STM32 defconfig
    https://git.kernel.org/soc/soc/c/c556c3444acd
  - [v2,3/4] ARM: configs: stm32: Remove CRYPTO in STM32 defconfig
    https://git.kernel.org/soc/soc/c/c1bfeadfd8a2
  - [v2,4/4] ARM: configs: stm32: Remove useless flags in STM32 defconfig
    https://git.kernel.org/soc/soc/c/90d96a122748

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html