From: Shawn Lin <shawn.lin@rock-chips.com>
To: Rob Herring <robh+dt@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
YiFeng Zhao <zyf@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH v7 0/7] Initial support for RK3576 UFS controller
Date: Wed, 5 Feb 2025 14:15:49 +0800 [thread overview]
Message-ID: <1738736156-119203-1-git-send-email-shawn.lin@rock-chips.com> (raw)
This patchset adds initial UFS controller supprt for RK3576 SoC.
Patch 1 is the dt-bindings. Patch 2-4 deal with rpm and spm support
in advanced suggested by Ulf. Patch 5 exports two new APIs for host
driver. Patch 6 and 7 are the host driver and dtsi support.
Changes in v7:
- add definitions for all kinds of hex values if possible
- Misc log and comment improvement
- use udelay for less than 10us cases
- other improvements suggested by Mani
- Use 0x0 for consistency
- Collect Mani's acked-by tag
Changes in v6:
- fix indentation to 4 spaces suggested by Krzysztof
- export dev_pm_genpd_rpm_always_on()
- replace host drivers with glue drivers suggested by Mani
- add Main's review tag
- remove UFS_MAX_CLKS
- improve err log
- remove hardcoded clocks
- remove comment from ufs_rockchip_device_reset()
- remove pm_runtime_* from ufs_rockchip_remove()
- rebase to scsi/next
- move ufs_rockchip_set_pm_lvl to ufs_rockchip_rk3576_init()
- add comments about device_set_awake_path()
- remove comments suggested by Mani
Changes in v5:
- use ufshc for devicetree example suggested by Mani
- fix a compile warning
- use device_set_awake_path() and disable ref_out_clk in suspend
- remove pd_id from header
- reconstruct ufs_rockchip_hce_enable_notify() to workaround hce enable
without using new quirk
Changes in v4:
- properly describe reset-gpios
- deal with power domain of rpm and spm suggested by Ulf
- Fix typo and disable clks in ufs_rockchip_remove
- remove clk_disable_unprepare(host->ref_out_clk) from
ufs_rockchip_remove
Changes in v3:
- rename the file to rockchip,rk3576-ufshc.yaml
- add description for reset-gpios
- use rockchip,rk3576-ufshc as compatible
- reword Kconfig description
- elaborate more about controller in commit msg
- use rockchip,rk3576-ufshc for compatible
- remove useless header file
- remove inline for ufshcd_is_device_present
- use usleep_range instead
- remove initialization, reverse Xmas order
- remove useless varibles
- check vops for null
- other small fixes for err path
- remove pm_runtime_set_active
- fix the active and inactive reset-gpios logic
- fix rpm_lvl and spm_lvl to 5 and move to end of probe path
- remove unnecessary system PM callbacks
- use UFSHCI_QUIRK_DME_RESET_ENABLE_AFTER_HCE instead
of UFSHCI_QUIRK_BROKEN_HCE
Changes in v2:
- rename the file
- add reset-gpios
Shawn Lin (6):
dt-bindings: ufs: Document Rockchip UFS host controller
soc: rockchip: add header for suspend mode SIP interface
pmdomain: rockchip: Add smc call to inform firmware
scsi: ufs: core: Export ufshcd_dme_reset() and ufshcd_dme_enable()
scsi: ufs: rockchip: initial support for UFS
arm64: dts: rockchip: Add UFS support for RK3576 SoC
Ulf Hansson (1):
pmdomain: core: Introduce dev_pm_genpd_rpm_always_on()
.../bindings/ufs/rockchip,rk3576-ufshc.yaml | 105 ++++++
arch/arm64/boot/dts/rockchip/rk3576.dtsi | 24 ++
drivers/pmdomain/core.c | 35 ++
drivers/pmdomain/rockchip/pm-domains.c | 8 +
drivers/ufs/core/ufshcd.c | 6 +-
drivers/ufs/host/Kconfig | 12 +
drivers/ufs/host/Makefile | 1 +
drivers/ufs/host/ufs-rockchip.c | 353 +++++++++++++++++++++
drivers/ufs/host/ufs-rockchip.h | 90 ++++++
include/linux/pm_domain.h | 7 +
include/soc/rockchip/rockchip_sip.h | 3 +
include/ufs/ufshcd.h | 2 +
12 files changed, 644 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml
create mode 100644 drivers/ufs/host/ufs-rockchip.c
create mode 100644 drivers/ufs/host/ufs-rockchip.h
--
2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Lin <shawn.lin@rock-chips.com>
To: Rob Herring <robh+dt@kernel.org>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
"Rafael J . Wysocki" <rafael@kernel.org>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
Bart Van Assche <bvanassche@acm.org>,
YiFeng Zhao <zyf@rock-chips.com>, Liang Chen <cl@rock-chips.com>,
linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Shawn Lin <shawn.lin@rock-chips.com>
Subject: [PATCH v7 0/7] Initial support for RK3576 UFS controller
Date: Wed, 5 Feb 2025 14:15:49 +0800 [thread overview]
Message-ID: <1738736156-119203-1-git-send-email-shawn.lin@rock-chips.com> (raw)
This patchset adds initial UFS controller supprt for RK3576 SoC.
Patch 1 is the dt-bindings. Patch 2-4 deal with rpm and spm support
in advanced suggested by Ulf. Patch 5 exports two new APIs for host
driver. Patch 6 and 7 are the host driver and dtsi support.
Changes in v7:
- add definitions for all kinds of hex values if possible
- Misc log and comment improvement
- use udelay for less than 10us cases
- other improvements suggested by Mani
- Use 0x0 for consistency
- Collect Mani's acked-by tag
Changes in v6:
- fix indentation to 4 spaces suggested by Krzysztof
- export dev_pm_genpd_rpm_always_on()
- replace host drivers with glue drivers suggested by Mani
- add Main's review tag
- remove UFS_MAX_CLKS
- improve err log
- remove hardcoded clocks
- remove comment from ufs_rockchip_device_reset()
- remove pm_runtime_* from ufs_rockchip_remove()
- rebase to scsi/next
- move ufs_rockchip_set_pm_lvl to ufs_rockchip_rk3576_init()
- add comments about device_set_awake_path()
- remove comments suggested by Mani
Changes in v5:
- use ufshc for devicetree example suggested by Mani
- fix a compile warning
- use device_set_awake_path() and disable ref_out_clk in suspend
- remove pd_id from header
- reconstruct ufs_rockchip_hce_enable_notify() to workaround hce enable
without using new quirk
Changes in v4:
- properly describe reset-gpios
- deal with power domain of rpm and spm suggested by Ulf
- Fix typo and disable clks in ufs_rockchip_remove
- remove clk_disable_unprepare(host->ref_out_clk) from
ufs_rockchip_remove
Changes in v3:
- rename the file to rockchip,rk3576-ufshc.yaml
- add description for reset-gpios
- use rockchip,rk3576-ufshc as compatible
- reword Kconfig description
- elaborate more about controller in commit msg
- use rockchip,rk3576-ufshc for compatible
- remove useless header file
- remove inline for ufshcd_is_device_present
- use usleep_range instead
- remove initialization, reverse Xmas order
- remove useless varibles
- check vops for null
- other small fixes for err path
- remove pm_runtime_set_active
- fix the active and inactive reset-gpios logic
- fix rpm_lvl and spm_lvl to 5 and move to end of probe path
- remove unnecessary system PM callbacks
- use UFSHCI_QUIRK_DME_RESET_ENABLE_AFTER_HCE instead
of UFSHCI_QUIRK_BROKEN_HCE
Changes in v2:
- rename the file
- add reset-gpios
Shawn Lin (6):
dt-bindings: ufs: Document Rockchip UFS host controller
soc: rockchip: add header for suspend mode SIP interface
pmdomain: rockchip: Add smc call to inform firmware
scsi: ufs: core: Export ufshcd_dme_reset() and ufshcd_dme_enable()
scsi: ufs: rockchip: initial support for UFS
arm64: dts: rockchip: Add UFS support for RK3576 SoC
Ulf Hansson (1):
pmdomain: core: Introduce dev_pm_genpd_rpm_always_on()
.../bindings/ufs/rockchip,rk3576-ufshc.yaml | 105 ++++++
arch/arm64/boot/dts/rockchip/rk3576.dtsi | 24 ++
drivers/pmdomain/core.c | 35 ++
drivers/pmdomain/rockchip/pm-domains.c | 8 +
drivers/ufs/core/ufshcd.c | 6 +-
drivers/ufs/host/Kconfig | 12 +
drivers/ufs/host/Makefile | 1 +
drivers/ufs/host/ufs-rockchip.c | 353 +++++++++++++++++++++
drivers/ufs/host/ufs-rockchip.h | 90 ++++++
include/linux/pm_domain.h | 7 +
include/soc/rockchip/rockchip_sip.h | 3 +
include/ufs/ufshcd.h | 2 +
12 files changed, 644 insertions(+), 2 deletions(-)
create mode 100644 Documentation/devicetree/bindings/ufs/rockchip,rk3576-ufshc.yaml
create mode 100644 drivers/ufs/host/ufs-rockchip.c
create mode 100644 drivers/ufs/host/ufs-rockchip.h
--
2.7.4
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next reply other threads:[~2025-02-05 6:52 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 6:15 Shawn Lin [this message]
2025-02-05 6:15 ` [PATCH v7 0/7] Initial support for RK3576 UFS controller Shawn Lin
2025-02-05 6:15 ` [PATCH v7 1/7] dt-bindings: ufs: Document Rockchip UFS host controller Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-11 7:14 ` Manivannan Sadhasivam
2025-02-11 7:14 ` Manivannan Sadhasivam
2025-02-05 6:15 ` [PATCH v7 2/7] soc: rockchip: add header for suspend mode SIP interface Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-11 7:35 ` Heiko Stübner
2025-02-11 7:35 ` Heiko Stübner
2025-02-05 6:15 ` [PATCH v7 3/7] pmdomain: core: Introduce dev_pm_genpd_rpm_always_on() Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-11 7:15 ` Manivannan Sadhasivam
2025-02-11 7:15 ` Manivannan Sadhasivam
2025-02-05 6:15 ` [PATCH v7 4/7] pmdomain: rockchip: Add smc call to inform firmware Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-07 9:58 ` Ulf Hansson
2025-02-07 9:58 ` Ulf Hansson
2025-02-11 7:35 ` Heiko Stübner
2025-02-11 7:35 ` Heiko Stübner
2025-02-17 14:47 ` Steven Price
2025-02-17 14:47 ` Steven Price
2025-02-17 15:16 ` Heiko Stübner
2025-02-17 15:16 ` Heiko Stübner
2025-02-17 17:10 ` Steven Price
2025-02-17 17:10 ` Steven Price
2025-02-17 20:50 ` Heiko Stübner
2025-02-17 20:50 ` Heiko Stübner
2025-02-18 0:53 ` Shawn Lin
2025-02-18 0:53 ` Shawn Lin
2025-02-18 11:05 ` Ulf Hansson
2025-02-18 11:05 ` Ulf Hansson
2025-02-19 1:00 ` Shawn Lin
2025-02-19 1:00 ` Shawn Lin
2025-02-05 6:15 ` [PATCH v7 5/7] scsi: ufs: core: Export ufshcd_dme_reset() and ufshcd_dme_enable() Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-05 17:53 ` Bart Van Assche
2025-02-05 17:53 ` Bart Van Assche
2025-02-05 6:15 ` [PATCH v7 6/7] scsi: ufs: rockchip: initial support for UFS Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-07 10:09 ` Ulf Hansson
2025-02-07 10:09 ` Ulf Hansson
2025-02-11 7:18 ` Manivannan Sadhasivam
2025-02-11 7:18 ` Manivannan Sadhasivam
2025-02-05 6:15 ` [PATCH v7 7/7] arm64: dts: rockchip: Add UFS support for RK3576 SoC Shawn Lin
2025-02-05 6:15 ` Shawn Lin
2025-02-07 10:17 ` [PATCH v7 0/7] Initial support for RK3576 UFS controller Ulf Hansson
2025-02-07 10:17 ` Ulf Hansson
2025-02-08 1:01 ` Shawn Lin
2025-02-08 1:01 ` Shawn Lin
2025-02-12 21:56 ` Martin K. Petersen
2025-02-12 21:56 ` Martin K. Petersen
2025-02-13 15:20 ` Ulf Hansson
2025-02-13 15:20 ` Ulf Hansson
2025-02-19 11:57 ` Ulf Hansson
2025-02-19 11:57 ` Ulf Hansson
2025-02-19 14:49 ` Martin K. Petersen
2025-02-19 14:49 ` Martin K. Petersen
2025-03-04 3:19 ` Martin K. Petersen
2025-03-04 3:19 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1738736156-119203-1-git-send-email-shawn.lin@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=cl@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zyf@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.