From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: michal.swiatkowski@linux.intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, wojciech.drewek@intel.com,
jacob.e.keller@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH v2 net-next] ice: Fix signedness bug in ice_init_interrupt_scheme()
Date: Sat, 15 Feb 2025 03:50:31 +0000 [thread overview]
Message-ID: <173959143126.2183234.5450052888067824074.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <b16e4f01-4c85-46e2-b602-fce529293559@stanley.mountain>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 13 Feb 2025 09:31:41 +0300 you wrote:
> If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
> then it returns -ENOSPC so there is no need to check for that in the
> caller. In fact, because pf->msix.min is an unsigned int, it means that
> any negative error codes are type promoted to high positive values and
> treated as success. So here, the "return -ENOMEM;" is unreachable code.
> Check for negatives instead.
>
> [...]
Here is the summary with links:
- [v2,net-next] ice: Fix signedness bug in ice_init_interrupt_scheme()
https://git.kernel.org/netdev/net-next/c/c2ddb619fa8d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
WARNING: multiple messages have this Message-ID (diff)
From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: michal.swiatkowski@linux.intel.com, anthony.l.nguyen@intel.com,
przemyslaw.kitszel@intel.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, wojciech.drewek@intel.com,
jacob.e.keller@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 net-next] ice: Fix signedness bug in ice_init_interrupt_scheme()
Date: Sat, 15 Feb 2025 03:50:31 +0000 [thread overview]
Message-ID: <173959143126.2183234.5450052888067824074.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <b16e4f01-4c85-46e2-b602-fce529293559@stanley.mountain>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 13 Feb 2025 09:31:41 +0300 you wrote:
> If pci_alloc_irq_vectors() can't allocate the minimum number of vectors
> then it returns -ENOSPC so there is no need to check for that in the
> caller. In fact, because pf->msix.min is an unsigned int, it means that
> any negative error codes are type promoted to high positive values and
> treated as success. So here, the "return -ENOMEM;" is unreachable code.
> Check for negatives instead.
>
> [...]
Here is the summary with links:
- [v2,net-next] ice: Fix signedness bug in ice_init_interrupt_scheme()
https://git.kernel.org/netdev/net-next/c/c2ddb619fa8d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2025-02-15 3:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 6:31 [Intel-wired-lan] [PATCH v2 net-next] ice: Fix signedness bug in ice_init_interrupt_scheme() Dan Carpenter
2025-02-13 6:31 ` Dan Carpenter
2025-02-13 6:55 ` [Intel-wired-lan] " Michal Swiatkowski
2025-02-13 6:55 ` Michal Swiatkowski
2025-02-15 3:50 ` patchwork-bot+netdevbpf [this message]
2025-02-15 3:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173959143126.2183234.5450052888067824074.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.swiatkowski@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.