All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	linux@armlinux.org.uk, pabeni@redhat.com, leon@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
	srk@ti.com
Subject: Re: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver
Date: Thu, 19 Jan 2023 12:27:25 +0200	[thread overview]
Message-ID: <1739f5ba-6d73-cd2c-d088-39428fdb55a7@kernel.org> (raw)
In-Reply-To: <20230118095439.114222-1-s-vadapalli@ti.com>



On 18/01/2023 11:54, Siddharth Vadapalli wrote:
> Delete unreachable code in am65_cpsw_init_cpts() function, which was
> Reported-by: Leon Romanovsky <leon@kernel.org>
> at:
> https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal
> 
> Remove the devm action associated with am65_cpts_release() and invoke the
> function directly on the cleanup and exit paths.
> 
> Changes from v2:
> 1. Drop Reviewed-by tag from Roger Quadros.
> 2. Add cleanup patch for deleting unreachable error handling code in
>    am65_cpsw_init_cpts().
> 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke
>    am65_cpts_release().
> 
> Changes from v1:
> 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This
>    error was reported by kernel test robot <lkp@intel.com> at:
>    https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/
> 2. Collect Reviewed-by tag from Roger Quadros.
> 
> v2:
> https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/
> v1:
> https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/
> 
> Siddharth Vadapalli (2):
>   net: ethernet: ti: am65-cpsw: Delete unreachable error handling code
>   net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
> 
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c |  7 ++-----
>  drivers/net/ethernet/ti/am65-cpts.c      | 15 +++++----------
>  drivers/net/ethernet/ti/am65-cpts.h      |  5 +++++
>  3 files changed, 12 insertions(+), 15 deletions(-)
> 

Reviewed-by: Roger Quadros <rogerq@kernel.org>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@kernel.org>
To: Siddharth Vadapalli <s-vadapalli@ti.com>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	linux@armlinux.org.uk, pabeni@redhat.com, leon@kernel.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com,
	srk@ti.com
Subject: Re: [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver
Date: Thu, 19 Jan 2023 12:27:25 +0200	[thread overview]
Message-ID: <1739f5ba-6d73-cd2c-d088-39428fdb55a7@kernel.org> (raw)
In-Reply-To: <20230118095439.114222-1-s-vadapalli@ti.com>



On 18/01/2023 11:54, Siddharth Vadapalli wrote:
> Delete unreachable code in am65_cpsw_init_cpts() function, which was
> Reported-by: Leon Romanovsky <leon@kernel.org>
> at:
> https://lore.kernel.org/r/Y8aHwSnVK9+sAb24@unreal
> 
> Remove the devm action associated with am65_cpts_release() and invoke the
> function directly on the cleanup and exit paths.
> 
> Changes from v2:
> 1. Drop Reviewed-by tag from Roger Quadros.
> 2. Add cleanup patch for deleting unreachable error handling code in
>    am65_cpsw_init_cpts().
> 3. Drop am65_cpsw_cpts_cleanup() function and directly invoke
>    am65_cpts_release().
> 
> Changes from v1:
> 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This
>    error was reported by kernel test robot <lkp@intel.com> at:
>    https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/
> 2. Collect Reviewed-by tag from Roger Quadros.
> 
> v2:
> https://lore.kernel.org/r/20230116044517.310461-1-s-vadapalli@ti.com/
> v1:
> https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/
> 
> Siddharth Vadapalli (2):
>   net: ethernet: ti: am65-cpsw: Delete unreachable error handling code
>   net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action
> 
>  drivers/net/ethernet/ti/am65-cpsw-nuss.c |  7 ++-----
>  drivers/net/ethernet/ti/am65-cpts.c      | 15 +++++----------
>  drivers/net/ethernet/ti/am65-cpts.h      |  5 +++++
>  3 files changed, 12 insertions(+), 15 deletions(-)
> 

Reviewed-by: Roger Quadros <rogerq@kernel.org>

  parent reply	other threads:[~2023-01-19 10:28 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18  9:54 [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver Siddharth Vadapalli
2023-01-18  9:54 ` Siddharth Vadapalli
2023-01-18  9:54 ` [PATCH net-next v3 1/2] net: ethernet: ti: am65-cpsw: Delete unreachable error handling code Siddharth Vadapalli
2023-01-18  9:54   ` Siddharth Vadapalli
2023-01-18 11:30   ` Leon Romanovsky
2023-01-18 11:30     ` Leon Romanovsky
2023-01-18  9:54 ` [PATCH net-next v3 2/2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action Siddharth Vadapalli
2023-01-18  9:54   ` Siddharth Vadapalli
2023-01-18 11:29   ` Leon Romanovsky
2023-01-18 11:29     ` Leon Romanovsky
2023-01-19 13:06   ` Paolo Abeni
2023-01-19 13:06     ` Paolo Abeni
2023-01-20  4:42   ` [PATCH net-next v4 " Siddharth Vadapalli
2023-01-20  4:42     ` Siddharth Vadapalli
2023-01-20  5:48     ` Jakub Kicinski
2023-01-20  5:48       ` Jakub Kicinski
2023-01-20  5:52       ` Siddharth Vadapalli
2023-01-20  5:52         ` Siddharth Vadapalli
2023-01-18 21:24 ` [PATCH net-next v3 0/2] Fix CPTS release action in am65-cpts driver Tony Nguyen
2023-01-18 21:24   ` Tony Nguyen
2023-01-19 10:27 ` Roger Quadros [this message]
2023-01-19 10:27   ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1739f5ba-6d73-cd2c-d088-39428fdb55a7@kernel.org \
    --to=rogerq@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=s-vadapalli@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.