From: "Heiko Stübner" <heiko@sntech.de>
To: kgene.kim@samsung.com
Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()
Date: Wed, 12 Feb 2014 01:20:04 +0100 [thread overview]
Message-ID: <1740860.STngzZgRLl@phil> (raw)
In-Reply-To: <3865198.Kyn1P03kbU@phil>
Am Sonntag, 12. Januar 2014, 21:34:29 schrieb Heiko Stübner:
> The function is nearly empty and samsung_cpu_rev is static so already 0
> making the function obsolete, therefore remove it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
ping :-)
> ---
> arch/arm/mach-s3c24xx/common.c | 1 -
> arch/arm/plat-samsung/cpu.c | 7 -------
> arch/arm/plat-samsung/include/plat/cpu.h | 1 -
> 3 files changed, 9 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
> index bf57d4c..97edd4d 100644
> --- a/arch/arm/mach-s3c24xx/common.c
> +++ b/arch/arm/mach-s3c24xx/common.c
> @@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc,
> int size) } else {
> samsung_cpu_id = s3c24xx_read_idcode_v4();
> }
> - s3c24xx_init_cpu();
>
> s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
>
> diff --git a/arch/arm/plat-samsung/cpu.c b/arch/arm/plat-samsung/cpu.c
> index 46b426e..364963a 100644
> --- a/arch/arm/plat-samsung/cpu.c
> +++ b/arch/arm/plat-samsung/cpu.c
> @@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
> }
> EXPORT_SYMBOL(samsung_rev);
>
> -void __init s3c24xx_init_cpu(void)
> -{
> - /* nothing here yet */
> -
> - samsung_cpu_rev = 0;
> -}
> -
> void __init s3c64xx_init_cpu(void)
> {
> samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h
> b/arch/arm/plat-samsung/include/plat/cpu.h index 8f09488..262ef86 100644
> --- a/arch/arm/plat-samsung/include/plat/cpu.h
> +++ b/arch/arm/plat-samsung/include/plat/cpu.h
> @@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
>
> extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
>
> -extern void s3c24xx_init_cpu(void);
> extern void s3c64xx_init_cpu(void);
> extern void s5p_init_cpu(void __iomem *cpuid_addr);
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu()
Date: Wed, 12 Feb 2014 01:20:04 +0100 [thread overview]
Message-ID: <1740860.STngzZgRLl@phil> (raw)
In-Reply-To: <3865198.Kyn1P03kbU@phil>
Am Sonntag, 12. Januar 2014, 21:34:29 schrieb Heiko St?bner:
> The function is nearly empty and samsung_cpu_rev is static so already 0
> making the function obsolete, therefore remove it.
>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
ping :-)
> ---
> arch/arm/mach-s3c24xx/common.c | 1 -
> arch/arm/plat-samsung/cpu.c | 7 -------
> arch/arm/plat-samsung/include/plat/cpu.h | 1 -
> 3 files changed, 9 deletions(-)
>
> diff --git a/arch/arm/mach-s3c24xx/common.c b/arch/arm/mach-s3c24xx/common.c
> index bf57d4c..97edd4d 100644
> --- a/arch/arm/mach-s3c24xx/common.c
> +++ b/arch/arm/mach-s3c24xx/common.c
> @@ -232,7 +232,6 @@ void __init s3c24xx_init_io(struct map_desc *mach_desc,
> int size) } else {
> samsung_cpu_id = s3c24xx_read_idcode_v4();
> }
> - s3c24xx_init_cpu();
>
> s3c_init_cpu(samsung_cpu_id, cpu_ids, ARRAY_SIZE(cpu_ids));
>
> diff --git a/arch/arm/plat-samsung/cpu.c b/arch/arm/plat-samsung/cpu.c
> index 46b426e..364963a 100644
> --- a/arch/arm/plat-samsung/cpu.c
> +++ b/arch/arm/plat-samsung/cpu.c
> @@ -28,13 +28,6 @@ unsigned int samsung_rev(void)
> }
> EXPORT_SYMBOL(samsung_rev);
>
> -void __init s3c24xx_init_cpu(void)
> -{
> - /* nothing here yet */
> -
> - samsung_cpu_rev = 0;
> -}
> -
> void __init s3c64xx_init_cpu(void)
> {
> samsung_cpu_id = __raw_readl(S3C_VA_SYS + 0x118);
> diff --git a/arch/arm/plat-samsung/include/plat/cpu.h
> b/arch/arm/plat-samsung/include/plat/cpu.h index 8f09488..262ef86 100644
> --- a/arch/arm/plat-samsung/include/plat/cpu.h
> +++ b/arch/arm/plat-samsung/include/plat/cpu.h
> @@ -207,7 +207,6 @@ extern void s5p_init_irq(u32 *vic, u32 num_vic);
>
> extern void s3c24xx_init_io(struct map_desc *mach_desc, int size);
>
> -extern void s3c24xx_init_cpu(void);
> extern void s3c64xx_init_cpu(void);
> extern void s5p_init_cpu(void __iomem *cpuid_addr);
next prev parent reply other threads:[~2014-02-12 0:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-12 20:34 [PATCH] ARM: SAMSUNG: remove unneeded s3c24xx_init_cpu() Heiko Stübner
2014-01-12 20:34 ` Heiko Stübner
2014-02-12 0:20 ` Heiko Stübner [this message]
2014-02-12 0:20 ` Heiko Stübner
2014-02-13 22:19 ` Kukjin Kim
2014-02-13 22:19 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1740860.STngzZgRLl@phil \
--to=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.