From: Heiko Stuebner <heiko@sntech.de>
To: Marc Zyngier <marc.zyngier@arm.com>
Cc: David Airlie <airlied@linux.ie>,
linux-rockchip@lists.infradead.org,
Mark Yao <markyao0591@gmail.com>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context
Date: Sat, 10 Feb 2018 17:23:06 +0100 [thread overview]
Message-ID: <1742402.LPvxsQ5ymm@phil> (raw)
In-Reply-To: <20180210143501.30407-1-marc.zyngier@arm.com>
Hi Marc,
Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier:
> The rockchip DRM driver is quite careful to disable interrupts
> when taking a lock that is also taken in interrupt context,
> which is a good thing.
>
> What is a bit over the top is to use spin_lock_irqsave when
> already in interrupt context, as you cannot take another
> interrupt again, and disabling interrupt is just pure
> overhead.
>
> Switching to the non _irqsave version in interrupt context is
> more logical, and less heavy handed.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
please note, that we had a maintainer swap for the Rockchip drm-component,
where Sandy replaced Mark [0] ... with me acting as sort-of (and not yet
up to speed) backup.
So I guess Rockchip drm patches should also include
Sandy Huang <hjc@rock-chips.com>
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b415b79529391abd29b6a30b93697821f01e082f
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context
Date: Sat, 10 Feb 2018 17:23:06 +0100 [thread overview]
Message-ID: <1742402.LPvxsQ5ymm@phil> (raw)
In-Reply-To: <20180210143501.30407-1-marc.zyngier@arm.com>
Hi Marc,
Am Samstag, 10. Februar 2018, 15:35:01 CET schrieb Marc Zyngier:
> The rockchip DRM driver is quite careful to disable interrupts
> when taking a lock that is also taken in interrupt context,
> which is a good thing.
>
> What is a bit over the top is to use spin_lock_irqsave when
> already in interrupt context, as you cannot take another
> interrupt again, and disabling interrupt is just pure
> overhead.
>
> Switching to the non _irqsave version in interrupt context is
> more logical, and less heavy handed.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
please note, that we had a maintainer swap for the Rockchip drm-component,
where Sandy replaced Mark [0] ... with me acting as sort-of (and not yet
up to speed) backup.
So I guess Rockchip drm patches should also include
Sandy Huang <hjc@rock-chips.com>
Heiko
[0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=b415b79529391abd29b6a30b93697821f01e082f
next prev parent reply other threads:[~2018-02-10 16:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-10 14:35 [PATCH] drm/rockchip: Don't use spin_lock_irqsave in interrupt context Marc Zyngier
2018-02-10 14:35 ` Marc Zyngier
2018-02-10 16:23 ` Heiko Stuebner [this message]
2018-02-10 16:23 ` Heiko Stuebner
2018-02-12 9:28 ` Marc Zyngier
2018-02-12 9:28 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1742402.LPvxsQ5ymm@phil \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marc.zyngier@arm.com \
--cc=markyao0591@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.