[PATCH v1] Bluetooth: MGMT: Add LL Privacy Setting

[PATCH v1] Bluetooth: MGMT: Add LL Privacy Setting

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This adds LL Privacy (bit 22) to Read Controller Information so the likes
of bluetoothd(1) can detect when the controller supports it or not.

Fixes: e209e5ccc5ac ("Bluetooth: MGMT: Mark LL Privacy as stable")
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
 include/net/bluetooth/mgmt.h | 1 +
 net/bluetooth/mgmt.c         | 6 ++++++
 2 files changed, 7 insertions(+)

diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index affac861efdc..3575cd16049a 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -113,6 +113,7 @@ struct mgmt_rp_read_index_list {
 #define MGMT_SETTING_CIS_PERIPHERAL	BIT(19)
 #define MGMT_SETTING_ISO_BROADCASTER	BIT(20)
 #define MGMT_SETTING_ISO_SYNC_RECEIVER	BIT(21)
+#define MGMT_SETTING_LL_PRIVACY		BIT(22)
 
 #define MGMT_OP_READ_INFO		0x0004
 #define MGMT_READ_INFO_SIZE		0
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 4fd30ba243be..c1e1e529e26c 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -851,6 +851,9 @@ static u32 get_supported_settings(struct hci_dev *hdev)
 	if (cis_peripheral_capable(hdev))
 		settings |= MGMT_SETTING_CIS_PERIPHERAL;
 
+	if (ll_privacy_capable(hdev))
+		settings |= MGMT_SETTING_LL_PRIVACY;
+
 	settings |= MGMT_SETTING_PHY_CONFIGURATION;
 
 	return settings;
@@ -933,6 +936,9 @@ static u32 get_current_settings(struct hci_dev *hdev)
 	if (sync_recv_capable(hdev))
 		settings |= MGMT_SETTING_ISO_SYNC_RECEIVER;
 
+	if (ll_privacy_capable(hdev))
+		settings |= MGMT_SETTING_LL_PRIVACY;
+
 	return settings;
 }
 
-- 
2.48.1

RE: [v1] Bluetooth: MGMT: Add LL Privacy Setting

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 3081 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=946405

---Test result---

Test Summary:
CheckPatch                    PENDING   0.26 seconds
GitLint                       PENDING   0.24 seconds
SubjectPrefix                 PASS      0.13 seconds
BuildKernel                   PASS      23.99 seconds
CheckAllWarning               PASS      26.46 seconds
CheckSparse                   PASS      30.06 seconds
BuildKernel32                 PASS      24.18 seconds
TestRunnerSetup               PASS      426.50 seconds
TestRunner_l2cap-tester       PASS      20.69 seconds
TestRunner_iso-tester         PASS      28.38 seconds
TestRunner_bnep-tester        PASS      4.70 seconds
TestRunner_mgmt-tester        FAIL      119.02 seconds
TestRunner_rfcomm-tester      PASS      7.76 seconds
TestRunner_sco-tester         PASS      12.32 seconds
TestRunner_ioctl-tester       PASS      8.21 seconds
TestRunner_mesh-tester        PASS      5.96 seconds
TestRunner_smp-tester         PASS      7.06 seconds
TestRunner_userchan-tester    PASS      4.89 seconds
IncrementalBuild              PENDING   0.75 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 490, Passed: 471 (96.1%), Failed: 15, Not Run: 4

Failed Test Cases
Add Ext Advertising - Success 2 (!Powered, Add Adv Inst) Failed       0.113 seconds
Add Ext Advertising - Success 3 (!Powered, Adv Enable) Failed       0.105 seconds
Add Ext Advertising - Success 4 (Set Adv on override) Failed       0.128 seconds
Add Ext Advertising - Success 5 (Set Adv off override) Failed       0.136 seconds
Add Ext Advertising - Success 16 (Connectable -> on) Failed       0.115 seconds
Add Ext Advertising - Success 17 (Connectable -> off) Failed       0.115 seconds
Add Ext Advertising - Success 22 (LE -> off, Remove) Failed       0.112 seconds
Add Ext Advertising - Success (1m Connectable -> on) Failed       0.110 seconds
Add Ext Advertising - Success (1m Connectable -> off) Failed       0.115 seconds
Multi Ext Advertising - Success 6 (Add w/o power on) Failed       0.132 seconds
Set Device ID - Power off and Power on               Failed       0.104 seconds
Set Device ID - SSP off and Power on                 Failed       0.100 seconds
LL Privacy - Add Device 3 (AL is full)               Failed       0.183 seconds
LL Privacy - Start Discovery 2 (Disable RL)          Failed       0.189 seconds
LL Privacy - Set Device Flag 1 (Device Privacy)      Failed       0.150 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Re: [PATCH v1] Bluetooth: MGMT: Add LL Privacy Setting

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Fri, 21 Mar 2025 15:46:27 -0400 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This adds LL Privacy (bit 22) to Read Controller Information so the likes
> of bluetoothd(1) can detect when the controller supports it or not.
> 
> Fixes: e209e5ccc5ac ("Bluetooth: MGMT: Mark LL Privacy as stable")
> Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> [...]

Here is the summary with links:
  - [v1] Bluetooth: MGMT: Add LL Privacy Setting
    https://git.kernel.org/bluetooth/bluetooth-next/c/402f42938757

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html