All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: sound/atmel/ac97c.c: remove unused variable
@ 2015-05-19 15:20 Arnd Bergmann
  2015-05-19 15:38 ` Alexander Stein
  2015-05-20  4:21 ` Takashi Iwai
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-05-19 15:20 UTC (permalink / raw)
  To: alsa-devel, Takashi Iwai
  Cc: Alexander Stein, Nicolas Ferre, broonie, Alexandre Belloni

The recently added DT support for the ac97 driver is causing
a gcc warning:

sound/atmel/ac97c.c: In function 'atmel_ac97c_probe_dt':
sound/atmel/ac97c.c:919:29: warning: unused variable 'match' [-Wunused-variable]
  const struct of_device_id *match;

The variable is clearly unused, so we can remove it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
index cf4cedf2b420..6dad042630d8 100644
--- a/sound/atmel/ac97c.c
+++ b/sound/atmel/ac97c.c
@@ -916,7 +916,6 @@ static struct ac97c_platform_data *atmel_ac97c_probe_dt(struct device *dev)
 {
 	struct ac97c_platform_data *pdata;
 	struct device_node *node = dev->of_node;
-	const struct of_device_id *match;
 
 	if (!node) {
 		dev_err(dev, "Device does not have associated DT data\n");

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: sound/atmel/ac97c.c: remove unused variable
  2015-05-19 15:20 [PATCH] ALSA: sound/atmel/ac97c.c: remove unused variable Arnd Bergmann
@ 2015-05-19 15:38 ` Alexander Stein
  2015-05-20  4:21 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Stein @ 2015-05-19 15:38 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Takashi Iwai, Nicolas Ferre, alsa-devel, broonie,
	Alexandre Belloni

On Tuesday 19 May 2015 17:20:36, Arnd Bergmann wrote:
> The recently added DT support for the ac97 driver is causing
> a gcc warning:
> 
> sound/atmel/ac97c.c: In function 'atmel_ac97c_probe_dt':
> sound/atmel/ac97c.c:919:29: warning: unused variable 'match' [-Wunused-variable]
>   const struct of_device_id *match;
> 
> The variable is clearly unused, so we can remove it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Acked-by: Alexander Stein <alexanders83@web.de>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ALSA: sound/atmel/ac97c.c: remove unused variable
  2015-05-19 15:20 [PATCH] ALSA: sound/atmel/ac97c.c: remove unused variable Arnd Bergmann
  2015-05-19 15:38 ` Alexander Stein
@ 2015-05-20  4:21 ` Takashi Iwai
  1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2015-05-20  4:21 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Alexander Stein, Nicolas Ferre, alsa-devel, broonie,
	Alexandre Belloni

At Tue, 19 May 2015 17:20:36 +0200,
Arnd Bergmann wrote:
> 
> The recently added DT support for the ac97 driver is causing
> a gcc warning:
> 
> sound/atmel/ac97c.c: In function 'atmel_ac97c_probe_dt':
> sound/atmel/ac97c.c:919:29: warning: unused variable 'match' [-Wunused-variable]
>   const struct of_device_id *match;
> 
> The variable is clearly unused, so we can remove it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks.


Takashi

> 
> diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c
> index cf4cedf2b420..6dad042630d8 100644
> --- a/sound/atmel/ac97c.c
> +++ b/sound/atmel/ac97c.c
> @@ -916,7 +916,6 @@ static struct ac97c_platform_data *atmel_ac97c_probe_dt(struct device *dev)
>  {
>  	struct ac97c_platform_data *pdata;
>  	struct device_node *node = dev->of_node;
> -	const struct of_device_id *match;
>  
>  	if (!node) {
>  		dev_err(dev, "Device does not have associated DT data\n");
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-20  4:21 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-19 15:20 [PATCH] ALSA: sound/atmel/ac97c.c: remove unused variable Arnd Bergmann
2015-05-19 15:38 ` Alexander Stein
2015-05-20  4:21 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.