Re: [PATCH 5/5] arm: dovetail: Helper functions for signal frame setup and restore

[Richard Weinberger <richard@sigma-star.at>]

On Dienstag, 8. April 2025 15:12 Florian Bezdeka wrote:
> The different code style here (and below) is by intention?

Too many different persons have worked on this and things got
copy&pasted.

> > 
> > +
> > +	frame = (struct rt_sigframe __user *)regs->ARM_sp;
> > +
> > +	pagefault_disable();
> > +
> > +	if (!access_ok(frame, sizeof (*frame))) {
> > +		goto out_pfe;
> > +	}
> > +
> > +	if (restore_sigframe(regs, &frame->sig)) {
> > +		goto out_pfe;
> > +	}
> > +
> > +	if (copy_from_user(&sig, &frame->info.si_signo, sizeof(sig)))
> > +		goto out_pfe;
> 
> Hm... Switched the style again... I assume checkpatch would have
> complained... No?

checkpatch issues a warning, so it is a matter of taste.
But I agree, we should be consistent. :-S

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT UID/VAT Nr:
ATU 66964118 | FN: 374287y