All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@sigma-star.at>
To: Nikolaus Funk <nikolaus.funk@sigmatek.at>,
	xenomai@lists.linux.dev,
	Florian Bezdeka <florian.bezdeka@siemens.com>
Cc: Richard Weinberger <richard@nod.at>,
	Johannes Kirchmair <johannes.kirchmair@sigmatek.at>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	Lorenz Kofler <lorenz@sigma-star.at>
Subject: Re: [PATCH 3/5] arm64: dovetail: Allow early return from traps
Date: Tue, 08 Apr 2025 15:24:46 +0200	[thread overview]
Message-ID: <4088969.M3a2QDmDih@anvil> (raw)
In-Reply-To: <b7a88e1a195a47892cb40e29ced523cda043d533.camel@siemens.com>

On Dienstag, 8. April 2025 14:58 Florian Bezdeka wrote:
> On Tue, 2025-04-08 at 14:34 +0200, Nikolaus Funk wrote:
> >  void do_sp_pc_abort(unsigned long addr, unsigned long esr, struct pt_regs *regs)
> >  {
> > -	mark_trap_entry(ARM64_TRAP_ALIGN, regs);
> > +	if (!mark_cond_trap_entry(ARM64_TRAP_ACCESS, regs))
> > +		return;
> >  
> >  	arm64_notify_die("SP/PC alignment exception", regs, SIGBUS, BUS_ADRALN,
> >  			 addr, esr);
> 
> This hunk looks odd: ARM64_TRAP_ALIGN vs. ARM64_TRAP_ACCESS?

Hmm, yes. Looks like a copy&paste error.
Should be ARM64_TRAP_ALIGN to pair with mark_trap_exit().

Thanks,
//richard

-- 
​​​​​sigma star gmbh | Eduard-Bodem-Gasse 6, 6020 Innsbruck, AUT UID/VAT Nr:
ATU 66964118 | FN: 374287y



  reply	other threads:[~2025-04-08 13:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 12:34 [RFC PATCH 0/5] Dovetail: Real-time Exception Handling Nikolaus Funk
2025-04-08 12:34 ` [PATCH 1/5] arm: dovetail: Fix user mode UND exception handling Nikolaus Funk
2025-04-08 12:34 ` [PATCH 2/5] x86: dovetail: Helper functions for signal frame setup and restore Nikolaus Funk
2025-04-08 12:34 ` [PATCH 3/5] arm64: dovetail: Allow early return from traps Nikolaus Funk
2025-04-08 12:58   ` Florian Bezdeka
2025-04-08 13:24     ` Richard Weinberger [this message]
2025-04-08 17:06   ` Jan Kiszka
2025-04-09  9:47     ` Richard Weinberger
2025-04-09 14:25       ` Jan Kiszka
2025-04-08 12:34 ` [PATCH 4/5] arm64: dovetail: Helper functions for signal frame setup and restore Nikolaus Funk
2025-04-08 13:05   ` Florian Bezdeka
2025-04-08 13:16     ` Richard Weinberger
2025-04-08 12:34 ` [PATCH 5/5] arm: " Nikolaus Funk
2025-04-08 13:12   ` Florian Bezdeka
2025-04-08 13:18     ` Richard Weinberger
2025-04-08 16:58 ` [RFC PATCH 0/5] Dovetail: Real-time Exception Handling Jan Kiszka
2025-04-08 17:55   ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4088969.M3a2QDmDih@anvil \
    --to=richard@sigma-star.at \
    --cc=florian.bezdeka@siemens.com \
    --cc=jan.kiszka@siemens.com \
    --cc=johannes.kirchmair@sigmatek.at \
    --cc=lorenz@sigma-star.at \
    --cc=nikolaus.funk@sigmatek.at \
    --cc=richard@nod.at \
    --cc=xenomai@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.