[PATCH net] pldmfw: Select CRC32 when PLDMFW is selected

[PATCH net] pldmfw: Select CRC32 when PLDMFW is selected

[Simon Horman]

pldmfw calls crc32 code and depends on it being enabled, else
there is a link error as follows. So PLDMFW should select CRC32.

  lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
  pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'

This problem was introduced by commit b8265621f488 ("Add pldmfw library
for PLDM firmware update").

It manifests as of commit d69ea414c9b4 ("ice: implement device flash
update via devlink").

And is more likely to occur as of commit 9ad19171b6d6 ("lib/crc: remove
unnecessary prompt for CONFIG_CRC32 and drop 'default y'").

Found by chance while exercising builds based on tinyconfig.

Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
Signed-off-by: Simon Horman <horms@kernel.org>
---
 lib/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/Kconfig b/lib/Kconfig
index 6c1b8f184267..37db228f70a9 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -716,6 +716,7 @@ config GENERIC_LIB_DEVMEM_IS_ALLOWED
 
 config PLDMFW
 	bool
+	select CRC32
 	default n
 
 config ASN1_ENCODER

RE: [PATCH net] pldmfw: Select CRC32 when PLDMFW is selected

[Keller, Jacob E]

> -----Original Message-----
> From: Simon Horman <horms@kernel.org>
> Sent: Friday, June 13, 2025 9:46 AM
> To: David S. Miller <davem@davemloft.net>; Eric Dumazet
> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
> <pabeni@redhat.com>
> Cc: Keller, Jacob E <jacob.e.keller@intel.com>; Eric Biggers
> <ebiggers@google.com>; Simon Horman <horms@kernel.org>;
> netdev@vger.kernel.org
> Subject: [PATCH net] pldmfw: Select CRC32 when PLDMFW is selected
> 
> pldmfw calls crc32 code and depends on it being enabled, else
> there is a link error as follows. So PLDMFW should select CRC32.
> 
>   lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
>   pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'
> 
> This problem was introduced by commit b8265621f488 ("Add pldmfw library
> for PLDM firmware update").
> 
> It manifests as of commit d69ea414c9b4 ("ice: implement device flash
> update via devlink").
> 
> And is more likely to occur as of commit 9ad19171b6d6 ("lib/crc: remove
> unnecessary prompt for CONFIG_CRC32 and drop 'default y'").
> 
> Found by chance while exercising builds based on tinyconfig.
> 
> Fixes: b8265621f488 ("Add pldmfw library for PLDM firmware update")
> Signed-off-by: Simon Horman <horms@kernel.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Thanks!

>  lib/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig b/lib/Kconfig
> index 6c1b8f184267..37db228f70a9 100644
> --- a/lib/Kconfig
> +++ b/lib/Kconfig
> @@ -716,6 +716,7 @@ config GENERIC_LIB_DEVMEM_IS_ALLOWED
> 
>  config PLDMFW
>  	bool
> +	select CRC32
>  	default n
> 
>  config ASN1_ENCODER

Re: [PATCH net] pldmfw: Select CRC32 when PLDMFW is selected

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri, 13 Jun 2025 17:46:20 +0100 you wrote:
> pldmfw calls crc32 code and depends on it being enabled, else
> there is a link error as follows. So PLDMFW should select CRC32.
> 
>   lib/pldmfw/pldmfw.o: In function `pldmfw_flash_image':
>   pldmfw.c:(.text+0x70f): undefined reference to `crc32_le_base'
> 
> This problem was introduced by commit b8265621f488 ("Add pldmfw library
> for PLDM firmware update").
> 
> [...]

Here is the summary with links:
  - [net] pldmfw: Select CRC32 when PLDMFW is selected
    https://git.kernel.org/netdev/net/c/1224b218a4b9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html