[PATCH net-next v2] net: pcs: xpcs: Use devm_clk_get_optional

[PATCH net-next v2] net: pcs: xpcs: Use devm_clk_get_optional

[Jack Ping CHNG]

Synopsys DesignWare XPCS CSR clock is optional,
so it is better to use devm_clk_get_optional
instead of devm_clk_get.

Signed-off-by: Jack Ping CHNG <jchng@maxlinear.com>
---
v2:
  - indicate net-next in the subject line
v1: https://lore.kernel.org/netdev/20250714022348.2147396-1-jchng@maxlinear.com/
---
 drivers/net/pcs/pcs-xpcs-plat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pcs/pcs-xpcs-plat.c b/drivers/net/pcs/pcs-xpcs-plat.c
index 629315f1e57c..137d91038fb4 100644
--- a/drivers/net/pcs/pcs-xpcs-plat.c
+++ b/drivers/net/pcs/pcs-xpcs-plat.c
@@ -280,7 +280,7 @@ static int xpcs_plat_init_clk(struct dw_xpcs_plat *pxpcs)
 	struct device *dev = &pxpcs->pdev->dev;
 	int ret;
 
-	pxpcs->cclk = devm_clk_get(dev, "csr");
+	pxpcs->cclk = devm_clk_get_optional(dev, "csr");
 	if (IS_ERR(pxpcs->cclk))
 		return dev_err_probe(dev, PTR_ERR(pxpcs->cclk),
 				     "Failed to get CSR clock\n");
-- 
2.43.0

Re: [PATCH net-next v2] net: pcs: xpcs: Use devm_clk_get_optional

[Andrew Lunn]

On Tue, Jul 15, 2025 at 10:19:56AM +0800, Jack Ping CHNG wrote:
> Synopsys DesignWare XPCS CSR clock is optional,
> so it is better to use devm_clk_get_optional
> instead of devm_clk_get.
> 
> Signed-off-by: Jack Ping CHNG <jchng@maxlinear.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

Re: [PATCH net-next v2] net: pcs: xpcs: Use devm_clk_get_optional

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue, 15 Jul 2025 10:19:56 +0800 you wrote:
> Synopsys DesignWare XPCS CSR clock is optional,
> so it is better to use devm_clk_get_optional
> instead of devm_clk_get.
> 
> Signed-off-by: Jack Ping CHNG <jchng@maxlinear.com>
> ---
> v2:
>   - indicate net-next in the subject line
> v1: https://lore.kernel.org/netdev/20250714022348.2147396-1-jchng@maxlinear.com/
> 
> [...]

Here is the summary with links:
  - [net-next,v2] net: pcs: xpcs: Use devm_clk_get_optional
    https://git.kernel.org/netdev/net-next/c/8a2a6bb01664

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html