Re: Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

Re: Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

[Jingoo Han]

T24gVHVlc2RheSwgTWFyY2ggMDUsIDIwMTMgNTozMCBBTSwgQXJuZCBCZXJnbWFubiB3cm90ZToN
Cj4gDQo+IE9uIE1vbmRheSAwNCBNYXJjaCAyMDEzLCBUaG9tYXMgUGV0YXp6b25pIHdyb3RlOg0K
PiA+IEZXSVcsIGEgcGF0Y2ggdGhhdCBpcyBkb2luZyB3aGF0IEkgd2FzIGluaXRpYWxseSBwcm9w
b3NpbmcgaGFzIGJlZW4NCj4gPiBtZXJnZWQgZm9yIDMuOSwgYW5kIGl0IGRvZXNuJ3QgY29udGFp
biB0aGUNCj4gPiBJU19FTkFCTEVEKENPTkZJR19IQVNfSU9QT1JUKSB0ZXN0IHlvdSB3ZXJlIHBy
b3Bvc2luZyAoYW5kIHdoaWNoIEkNCj4gPiB0aGluayB3YXMgY29ycmVjdCkuIFNlZToNCj4gPg0K
PiA+IGNvbW1pdCA5ZWQ4YTMwZjM0NzEzNDdjMWI3NjNiZDA2MmZhNzhhZTgwZjE4ZWFlDQo+ID4g
QXV0aG9yOiBKaW5nb28gSGFuIDxqZzEuaGFuQHNhbXN1bmcuY29tPg0KPiA+IERhdGU6ICAgV2Vk
IEZlYiAyNyAxNzowMjo0MiAyMDEzIC0wODAwDQo+ID4NCj4gDQo+IFNpZ2guDQo+IA0KPiBJJ2xs
IHRha2UgaXQgYXMgYW4gYWRkaXRpb25hbCBpbmNlbnRpdmUgdG8gZmluYWxseSBjbGVhbiB1cCB0
aGUgbG9naWMgYmVoaW5kDQo+IENPTkZJR19IQVNfSU9QT1JUIGJ5IGludHJvZHVjaW5nIGEgQ09O
RklHX0hBU19JT1BPUlRfTUFQIHN5bWJvbCB0byByZXBsYWNlIGl0Lg0KPiANCj4gVGhhbmtzIGZv
ciB0aGUgaGVhZHMgdXAuDQoNCg0KSGkgVGhvbWFzIFBldGF6em9uaQ0KU29ycnksIEkgZGlkIG5v
dCBrbm93IHRoYXQgeW91IHN1Ym1pdHRlZCB0aGUgcGF0Y2guDQpMaWtlIHlvdSwgSSBhbSBkZXZl
bG9waW5nIFBDSWUgSG9zdCBkcml2ZXIuDQpBbHNvLCBJIGV4cGVyaWVuY2VkIHRoZSBhbm5veWlu
ZyBidWlsZCBlcnJvciByZWxhdGVkIHRvDQpDT05GSUdfSEFTX0lPUE9SVC4NCg0KSGkgQXJuZCBC
ZXJnbWFubiwNCkkgaGF2ZSBqdXN0IHJlYWQgdGhlIG1haWxpbmcgdGhyZWFkLg0KSWYgeW91IHJl
c29sdmUgdGhpcyBzaXR1YXRpb24gcHJvcGVybHksIGl0IHdpbGwgYmUgdmVyeSBoZWxwZnVsLg0K
VGhhbmsgeW91Lg0KDQpCZXN0IHJlZ2FyZHMsDQpKaW5nb28gSGFuDQoNCj4gDQo+IAlBcm5kDQo+
IC0tDQo+IFRvIHVuc3Vic2NyaWJlIGZyb20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1
YnNjcmliZSBsaW51eC1wY2kiIGluDQo+IHRoZSBib2R5IG9mIGEgbWVzc2FnZSB0byBtYWpvcmRv
bW9Admdlci5rZXJuZWwub3JnDQo+IE1vcmUgbWFqb3Jkb21vIGluZm8gYXQgIGh0dHA6Ly92Z2Vy
Lmtlcm5lbC5vcmcvbWFqb3Jkb21vLWluZm8uaHRtbA0K

Re: Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

[Jingoo Han]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1406 bytes --]

On Tuesday, March 05, 2013 5:30 AM, Arnd Bergmann wrote:
> 
> On Monday 04 March 2013, Thomas Petazzoni wrote:
> > FWIW, a patch that is doing what I was initially proposing has been
> > merged for 3.9, and it doesn't contain the
> > IS_ENABLED(CONFIG_HAS_IOPORT) test you were proposing (and which I
> > think was correct). See:
> >
> > commit 9ed8a30f3471347c1b763bd062fa78ae80f18eae
> > Author: Jingoo Han <jg1.han@samsung.com>
> > Date:   Wed Feb 27 17:02:42 2013 -0800
> >
> 
> Sigh.
> 
> I'll take it as an additional incentive to finally clean up the logic behind
> CONFIG_HAS_IOPORT by introducing a CONFIG_HAS_IOPORT_MAP symbol to replace it.
> 
> Thanks for the heads up.


Hi Thomas Petazzoni
Sorry, I did not know that you submitted the patch.
Like you, I am developing PCIe Host driver.
Also, I experienced the annoying build error related to
CONFIG_HAS_IOPORT.

Hi Arnd Bergmann,
I have just read the mailing thread.
If you resolve this situation properly, it will be very helpful.
Thank you.

Best regards,
Jingoo Han

> 
> 	Arnd
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

[Thomas Petazzoni]

Dear Jingoo Han,

On Wed, 06 Mar 2013 06:28:08 +0000 (GMT), Jingoo Han wrote:

> Sorry, I did not know that you submitted the patch.

No problem, I'm happy to have one less patch to carry in my PCIe patch
set :)

> Like you, I am developing PCIe Host driver.

Just curious, do you already have some code? Thierry Reding and myself
have been looking at each other's PCIe host driver since a while in
order to make some consistent choices where possible. It would be good
to see your code as well.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 05/32] lib: devres: don't enclose pcim_*() functions in CONFIG_HAS_IOPORT

[Thomas Petazzoni]

Dear Jingoo Han,

On Wed, 06 Mar 2013 06:28:08 +0000 (GMT), Jingoo Han wrote:

> Sorry, I did not know that you submitted the patch.

No problem, I'm happy to have one less patch to carry in my PCIe patch
set :)

> Like you, I am developing PCIe Host driver.

Just curious, do you already have some code? Thierry Reding and myself
have been looking at each other's PCIe host driver since a while in
order to make some consistent choices where possible. It would be good
to see your code as well.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com