All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: akolli@qti.qualcomm.com, linux-wireless@vger.kernel.org,
	ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: Fix reported HT MCS rates with NSS > 1
Date: Thu, 11 May 2017 12:08:37 +0200	[thread overview]
Message-ID: <1754114.EBhbnoIm2s@bentobox> (raw)
In-Reply-To: <6e066fe4-35e0-981a-a86e-d9dcaf6ec3b1@broadcom.com>


[-- Attachment #1.1: Type: text/plain, Size: 1541 bytes --]

On Donnerstag, 11. Mai 2017 11:39:46 CEST Arend Van Spriel wrote:
[...]
> So you leave VHT as is. Did you check with 11ac device? I am wondering
> if it needs the same change.

VHT MCS rates are reported by drivers with NSS + MCS rates 0-9 [1] as 
separated values. So I would say that the code is correct to report them as 
separate values. But no, I haven't tested with an 802.11ac capable device 
which I can fully trust because I didn't have one in arms reach (and I would 
have to compile a new firmware for it). But the output for a second ath10k 
based device looks ok'ish:

    Station ac:86:74:61:6b:30 (on wlan1)
            inactive time:  700 ms
            rx bytes:       10741
            rx packets:     95
            tx bytes:       9886
            tx packets:     86
            tx retries:     0
            tx failed:      0
            rx drop misc:   1
            signal:         -22 dBm
            signal avg:     -21 dBm
            tx bitrate:     780.0 MBit/s VHT-MCS 8 80MHz short GI VHT-NSS 2
            rx bitrate:     780.0 MBit/s VHT-MCS 8 80MHz short GI VHT-NSS 2
            rx duration:    8172 us
            authorized:     yes
            authenticated:  yes
            associated:     yes
            preamble:       long
            WMM/WME:        yes
            MFP:            no
            TDLS peer:      no
            DTIM period:    2
            beacon interval:100
            short slot time:yes
            connected time: 106 seconds

Kind regards,
	Sven

[1] http://mcsindex.com/

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 146 bytes --]

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	akolli@qti.qualcomm.com
Subject: Re: [PATCH] ath10k: Fix reported HT MCS rates with NSS > 1
Date: Thu, 11 May 2017 12:08:37 +0200	[thread overview]
Message-ID: <1754114.EBhbnoIm2s@bentobox> (raw)
In-Reply-To: <6e066fe4-35e0-981a-a86e-d9dcaf6ec3b1@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

On Donnerstag, 11. Mai 2017 11:39:46 CEST Arend Van Spriel wrote:
[...]
> So you leave VHT as is. Did you check with 11ac device? I am wondering
> if it needs the same change.

VHT MCS rates are reported by drivers with NSS + MCS rates 0-9 [1] as 
separated values. So I would say that the code is correct to report them as 
separate values. But no, I haven't tested with an 802.11ac capable device 
which I can fully trust because I didn't have one in arms reach (and I would 
have to compile a new firmware for it). But the output for a second ath10k 
based device looks ok'ish:

    Station ac:86:74:61:6b:30 (on wlan1)
            inactive time:  700 ms
            rx bytes:       10741
            rx packets:     95
            tx bytes:       9886
            tx packets:     86
            tx retries:     0
            tx failed:      0
            rx drop misc:   1
            signal:         -22 dBm
            signal avg:     -21 dBm
            tx bitrate:     780.0 MBit/s VHT-MCS 8 80MHz short GI VHT-NSS 2
            rx bitrate:     780.0 MBit/s VHT-MCS 8 80MHz short GI VHT-NSS 2
            rx duration:    8172 us
            authorized:     yes
            authenticated:  yes
            associated:     yes
            preamble:       long
            WMM/WME:        yes
            MFP:            no
            TDLS peer:      no
            DTIM period:    2
            beacon interval:100
            short slot time:yes
            connected time: 106 seconds

Kind regards,
	Sven

[1] http://mcsindex.com/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-05-11 10:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-11  9:09 [PATCH] ath10k: Fix reported HT MCS rates with NSS > 1 Sven Eckelmann
2017-05-11  9:09 ` Sven Eckelmann
2017-05-11  9:39 ` Arend Van Spriel
2017-05-11  9:39   ` Arend Van Spriel
2017-05-11 10:08   ` Sven Eckelmann [this message]
2017-05-11 10:08     ` Sven Eckelmann
2017-05-23 15:28 ` Kalle Valo
2017-05-23 15:28   ` Kalle Valo
2017-11-05  9:22   ` Sebastian Gottschall
2017-11-05  9:22     ` Sebastian Gottschall
2017-11-06  8:23     ` Sven Eckelmann
2017-11-06  8:23       ` Sven Eckelmann
2017-11-06  8:28       ` Sebastian Gottschall
2017-11-06  8:28         ` Sebastian Gottschall
2017-11-06  9:02         ` Sven Eckelmann
2017-11-06  9:02           ` Sven Eckelmann
2017-11-06 21:25           ` Peter Oh
2017-11-06 21:25             ` Peter Oh
2017-11-20 12:10             ` Kalle Valo
2017-11-20 12:10               ` Kalle Valo
2017-11-21  6:13               ` akolli
2017-11-21  6:13                 ` akolli
2017-12-05  9:16                 ` Sven Eckelmann
2017-12-05  9:16                   ` Sven Eckelmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1754114.EBhbnoIm2s@bentobox \
    --to=sven.eckelmann@openmesh.com \
    --cc=akolli@qti.qualcomm.com \
    --cc=arend.vanspriel@broadcom.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.