All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Xiangzhi Tang <xiangzhi.tang@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org,  linux-remoteproc@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Jjian Zhou <Jjian.Zhou@mediatek.com>,
	 Xiangzhi Tang <Xiangzhi.Tang@mediatek.com>,
	 linux-mediatek@lists.infradead.org,
	Conor Dooley <conor+dt@kernel.org>,
	 AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	 Hailong Fan <Hailong.Fan@mediatek.com>,
	linux-kernel@vger.kernel.org,
	 linux-arm-kernel@lists.infradead.org,
	 Bjorn Andersson <andersson@kernel.org>,
	 Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v2 1/4] dt-bindings: remoteproc: Add VCP support for mt8196
Date: Sun, 14 Sep 2025 16:57:39 -0500	[thread overview]
Message-ID: <175788697866.1955455.17302760216827607004.robh@kernel.org> (raw)
In-Reply-To: <20250914122943.10412-2-xiangzhi.tang@mediatek.com>


On Sun, 14 Sep 2025 20:29:24 +0800, Xiangzhi Tang wrote:
> Add the new binding document for MediaTek Video Companion
> Processor(VCP) on MediaTek mt8196.
> 
> Signed-off-by: Xiangzhi Tang <xiangzhi.tang@mediatek.com>
> ---
>  .../remoteproc/mediatek,mt8196-vcp.yaml       | 165 ++++++++++++++++++
>  1 file changed, 165 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.yaml: patternProperties:^vcp@[a-f0-9]+$:properties:mtk,vcp-core-twohart: 'anyOf' conditional failed, one must be fixed:
	'description' is a dependency of '$ref'
	'/schemas/types.yaml#/definitions/uint32' does not match '^#/(definitions|\\$defs)/'
		hint: A vendor property can have a $ref to a a $defs schema
	hint: Vendor specific properties must have a type and description unless they have a defined, common suffix.
	from schema $id: http://devicetree.org/meta-schemas/vendor-props.yaml#
Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.example.dts:26:18: fatal error: dt-bindings/power/mt8196-power.h: No such file or directory
   26 |         #include <dt-bindings/power/mt8196-power.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:132: Documentation/devicetree/bindings/remoteproc/mediatek,mt8196-vcp.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1525: dt_binding_check] Error 2
make: *** [Makefile:248: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250914122943.10412-2-xiangzhi.tang@mediatek.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.



  parent reply	other threads:[~2025-09-14 21:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-14 12:29 [PATCH v2 0/4] ASoC: mediatek: Add support of VCP on Mediatek mt8196 SoC Xiangzhi Tang
2025-09-14 12:29 ` [PATCH v2 1/4] dt-bindings: remoteproc: Add VCP support for mt8196 Xiangzhi Tang
2025-09-14 13:18   ` Krzysztof Kozlowski
2025-09-14 21:57   ` Rob Herring (Arm) [this message]
2025-09-15  7:48   ` AngeloGioacchino Del Regno
2025-09-14 12:29 ` [PATCH v2 2/4] remoterpoc: mediatek: vcp: Add vcp remoteproc driver Xiangzhi Tang
2025-09-14 13:28   ` Krzysztof Kozlowski
2025-09-15  9:14   ` AngeloGioacchino Del Regno
2025-09-14 12:29 ` [PATCH v2 3/4] remoterpoc: mediatek: vcp: Add ipi-mbox communication Xiangzhi Tang
2025-09-14 13:30   ` Krzysztof Kozlowski
2025-09-14 12:29 ` [PATCH v2 4/4] remoterpoc: mediatek: vcp: Add vcp suspned and resume feature Xiangzhi Tang
2025-09-14 13:16 ` [PATCH v2 0/4] ASoC: mediatek: Add support of VCP on Mediatek mt8196 SoC Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175788697866.1955455.17302760216827607004.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Hailong.Fan@mediatek.com \
    --cc=Jjian.Zhou@mediatek.com \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=xiangzhi.tang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.