* [PATCH iproute] mptcp: fix event attributes type
@ 2025-09-16 9:24 Matthieu Baerts (NGI0)
2025-09-17 15:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Matthieu Baerts (NGI0) @ 2025-09-16 9:24 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: MPTCP Linux, netdev, Matthieu Baerts (NGI0)
The 'backup' and 'error' attributes are unsigned.
Even if, for the moment, >2^7 values are not expected, they should be
printed as unsigned (%u) and not as signed (%d).
Fixes: ff619e4f ("mptcp: add support for event monitoring")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
ip/ipmptcp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index 118bac4a42a1ea3ce9710510df1353683eb29c89..2415cac8a36089da0e1c42995c06535a08305de7 100644
--- a/ip/ipmptcp.c
+++ b/ip/ipmptcp.c
@@ -522,9 +522,9 @@ static int mptcp_monitor_msg(struct rtnl_ctrl_data *ctrl,
if (tb[MPTCP_ATTR_DPORT])
printf(" dport=%u", rta_getattr_be16(tb[MPTCP_ATTR_DPORT]));
if (tb[MPTCP_ATTR_BACKUP])
- printf(" backup=%d", rta_getattr_u8(tb[MPTCP_ATTR_BACKUP]));
+ printf(" backup=%u", rta_getattr_u8(tb[MPTCP_ATTR_BACKUP]));
if (tb[MPTCP_ATTR_ERROR])
- printf(" error=%d", rta_getattr_u8(tb[MPTCP_ATTR_ERROR]));
+ printf(" error=%u", rta_getattr_u8(tb[MPTCP_ATTR_ERROR]));
if (tb[MPTCP_ATTR_FLAGS])
printf(" flags=%x", rta_getattr_u16(tb[MPTCP_ATTR_FLAGS]));
if (tb[MPTCP_ATTR_TIMEOUT])
---
base-commit: bd63ac4980f3d405f4b785fdfe45ba9284b052af
change-id: 20250916-mptcp-attr-sign-f723450dbfa9
Best regards,
--
Matthieu Baerts (NGI0) <matttbe@kernel.org>
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH iproute] mptcp: fix event attributes type
2025-09-16 9:24 [PATCH iproute] mptcp: fix event attributes type Matthieu Baerts (NGI0)
@ 2025-09-17 15:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-09-17 15:40 UTC (permalink / raw)
To: Matthieu Baerts; +Cc: stephen, mptcp, netdev
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Tue, 16 Sep 2025 11:24:33 +0200 you wrote:
> The 'backup' and 'error' attributes are unsigned.
>
> Even if, for the moment, >2^7 values are not expected, they should be
> printed as unsigned (%u) and not as signed (%d).
>
> Fixes: ff619e4f ("mptcp: add support for event monitoring")
> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>
> [...]
Here is the summary with links:
- [iproute] mptcp: fix event attributes type
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=ccbd9b64d666
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-17 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-16 9:24 [PATCH iproute] mptcp: fix event attributes type Matthieu Baerts (NGI0)
2025-09-17 15:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.