* [PATCH] drm/bridge: PTN3460 needs DRM_KMS_HELPER
@ 2014-03-25 11:06 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2014-03-25 11:06 UTC (permalink / raw)
To: linux-arm-kernel
The recently added PTN3460 device driver uses interfaces that
are provided by the KMS helper infrastructure, so we should
explicitly select that to avoid this linker error:
ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
We have to drop the I2C dependency to avoid a circular dependency
chain, but that's ok because DRM already selects I2C.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I found this today doing randconfig builds on linux-next.
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index f8db069..884923f 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -1,4 +1,5 @@
config DRM_PTN3460
tristate "PTN3460 DP/LVDS bridge"
- depends on DRM && I2C
+ depends on DRM
+ select DRM_KMS_HELPER
---help---
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: PTN3460 needs DRM_KMS_HELPER
@ 2014-03-25 11:06 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2014-03-25 11:06 UTC (permalink / raw)
To: Dave Airlie, dri-devel, linux-arm-kernel
The recently added PTN3460 device driver uses interfaces that
are provided by the KMS helper infrastructure, so we should
explicitly select that to avoid this linker error:
ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
We have to drop the I2C dependency to avoid a circular dependency
chain, but that's ok because DRM already selects I2C.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
I found this today doing randconfig builds on linux-next.
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index f8db069..884923f 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -1,4 +1,5 @@
config DRM_PTN3460
tristate "PTN3460 DP/LVDS bridge"
- depends on DRM && I2C
+ depends on DRM
+ select DRM_KMS_HELPER
---help---
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/bridge: PTN3460 needs DRM_KMS_HELPER
2014-03-25 11:06 ` Arnd Bergmann
@ 2014-03-25 11:15 ` Inki Dae
-1 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2014-03-25 11:15 UTC (permalink / raw)
To: linux-arm-kernel
2014-03-25 20:06 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The recently added PTN3460 device driver uses interfaces that
> are provided by the KMS helper infrastructure, so we should
> explicitly select that to avoid this linker error:
>
> ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
> ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
>
Ah, right. Exynos drm selects DRM_KMS_HELPER so I cannot see build error.
Thanks,
Inki Dae
> We have to drop the I2C dependency to avoid a circular dependency
> chain, but that's ok because DRM already selects I2C.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I found this today doing randconfig builds on linux-next.
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index f8db069..884923f 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -1,4 +1,5 @@
> config DRM_PTN3460
> tristate "PTN3460 DP/LVDS bridge"
> - depends on DRM && I2C
> + depends on DRM
> + select DRM_KMS_HELPER
> ---help---
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: PTN3460 needs DRM_KMS_HELPER
@ 2014-03-25 11:15 ` Inki Dae
0 siblings, 0 replies; 4+ messages in thread
From: Inki Dae @ 2014-03-25 11:15 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Dave Airlie, linux-arm-kernel@lists.infradead.org,
DRI mailing list
2014-03-25 20:06 GMT+09:00 Arnd Bergmann <arnd@arndb.de>:
> The recently added PTN3460 device driver uses interfaces that
> are provided by the KMS helper infrastructure, so we should
> explicitly select that to avoid this linker error:
>
> ERROR: "drm_helper_probe_single_connector_modes" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
> ERROR: "drm_helper_connector_dpms" [drivers/gpu/drm/bridge/ptn3460.ko] undefined!
>
Ah, right. Exynos drm selects DRM_KMS_HELPER so I cannot see build error.
Thanks,
Inki Dae
> We have to drop the I2C dependency to avoid a circular dependency
> chain, but that's ok because DRM already selects I2C.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I found this today doing randconfig builds on linux-next.
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index f8db069..884923f 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -1,4 +1,5 @@
> config DRM_PTN3460
> tristate "PTN3460 DP/LVDS bridge"
> - depends on DRM && I2C
> + depends on DRM
> + select DRM_KMS_HELPER
> ---help---
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-25 11:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-25 11:06 [PATCH] drm/bridge: PTN3460 needs DRM_KMS_HELPER Arnd Bergmann
2014-03-25 11:06 ` Arnd Bergmann
2014-03-25 11:15 ` Inki Dae
2014-03-25 11:15 ` Inki Dae
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.