[PATCH] tracing: wprobe: Use a new seq_print_ip_sym_offset() wrapper

[PATCH] tracing: wprobe: Use a new seq_print_ip_sym_offset() wrapper

[Masami Hiramatsu (Google)]

From: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Use a new seq_print_ip_sym_offset() wrapper function instead of
using TRACE_ITER(SYM_OFFSET) mask directly.

Signed-off-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
---
 kernel/trace/trace_wprobe.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kernel/trace/trace_wprobe.c b/kernel/trace/trace_wprobe.c
index 98605b207f43..eae952a4f9e9 100644
--- a/kernel/trace/trace_wprobe.c
+++ b/kernel/trace/trace_wprobe.c
@@ -20,6 +20,7 @@
 #include <asm/ptrace.h>
 
 #include "trace_dynevent.h"
+#include "trace_output.h"
 #include "trace_probe.h"
 #include "trace_probe_kernel.h"
 #include "trace_probe_tmpl.h"
@@ -260,7 +261,7 @@ print_wprobe_event(struct trace_iterator *iter, int flags,
 
 	trace_seq_printf(s, "%s: (", trace_probe_name(tp));
 
-	if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))
+	if (!seq_print_ip_sym_offset(s, field->ip, flags))
 		goto out;
 
 	trace_seq_putc(s, ')');

Re: [PATCH] tracing: wprobe: Use a new seq_print_ip_sym_offset() wrapper

[kernel test robot]

Hi Masami,

kernel test robot noticed the following build errors:

[auto build test ERROR on trace/for-next]
[also build test ERROR on next-20251106]
[cannot apply to linus/master v6.18-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Masami-Hiramatsu-Google/tracing-wprobe-Use-a-new-seq_print_ip_sym_offset-wrapper/20251104-221949
base:   https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link:    https://lore.kernel.org/r/176226550596.59499.18020648957674458755.stgit%40devnote2
patch subject: [PATCH] tracing: wprobe: Use a new seq_print_ip_sym_offset() wrapper
config: i386-randconfig-063-20251105 (https://download.01.org/0day-ci/archive/20251107/202511070042.0X3oQDrB-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251107/202511070042.0X3oQDrB-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511070042.0X3oQDrB-lkp@intel.com/

All errors (new ones prefixed by >>):

>> kernel/trace/trace_wprobe.c:264:7: error: call to undeclared function 'seq_print_ip_sym_offset'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     264 |         if (!seq_print_ip_sym_offset(s, field->ip, flags))
         |              ^
   kernel/trace/trace_wprobe.c:264:7: note: did you mean 'seq_print_ip_sym'?
   kernel/trace/trace_output.h:16:1: note: 'seq_print_ip_sym' declared here
      16 | seq_print_ip_sym(struct trace_seq *s, unsigned long ip,
         | ^
   1 error generated.


vim +/seq_print_ip_sym_offset +264 kernel/trace/trace_wprobe.c

   247	
   248	static enum print_line_t
   249	print_wprobe_event(struct trace_iterator *iter, int flags,
   250			   struct trace_event *event)
   251	{
   252		struct wprobe_trace_entry_head *field;
   253		struct trace_seq *s = &iter->seq;
   254		struct trace_probe *tp;
   255	
   256		field = (struct wprobe_trace_entry_head *)iter->ent;
   257		tp = trace_probe_primary_from_call(
   258			container_of(event, struct trace_event_call, event));
   259		if (WARN_ON_ONCE(!tp))
   260			goto out;
   261	
   262		trace_seq_printf(s, "%s: (", trace_probe_name(tp));
   263	
 > 264		if (!seq_print_ip_sym_offset(s, field->ip, flags))
   265			goto out;
   266	
   267		trace_seq_putc(s, ')');
   268	
   269		if (trace_probe_print_args(s, tp->args, tp->nr_args,
   270				     (u8 *)&field[1], field) < 0)
   271			goto out;
   272	
   273		trace_seq_putc(s, '\n');
   274	out:
   275		return trace_handle_return(s);
   276	}
   277	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki