From: Jens Axboe <axboe@kernel.dk>
To: Ming Lei <ming.lei@redhat.com>,
Caleb Sander Mateos <csander@purestorage.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] ublk: simplify user copy
Date: Thu, 06 Nov 2025 16:30:10 -0700 [thread overview]
Message-ID: <176247181033.292880.16085659049514901290.b4-ty@kernel.dk> (raw)
In-Reply-To: <20251106171647.2590074-1-csander@purestorage.com>
On Thu, 06 Nov 2025 10:16:45 -0700, Caleb Sander Mateos wrote:
> Use copy_page_{to,from}_user() and rq_for_each_segment() to simplify the
> implementation of ublk_copy_user_pages(). Avoiding the page pinning and
> unpinning saves expensive atomic increments and decrements of the page
> reference counts. And copying via user virtual addresses avoids needing
> to split the copy at user page boundaries. Ming reports a 40% throughput
> improvement when issuing I/O to the selftests null ublk server with
> zero-copy disabled.
>
> [...]
Applied, thanks!
[1/2] ublk: use copy_{to,from}_iter() for user copy
commit: 2299ceec364eecdc0a5b4ec80c757551d130389c
[2/2] ublk: use rq_for_each_segment() for user copy
commit: e87d66ab27ac89494b75ddc3fed697b5aa8417f1
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2025-11-06 23:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 17:16 [PATCH v3 0/2] ublk: simplify user copy Caleb Sander Mateos
2025-11-06 17:16 ` [PATCH v3 1/2] ublk: use copy_{to,from}_iter() for " Caleb Sander Mateos
2025-11-06 17:16 ` [PATCH v3 2/2] ublk: use rq_for_each_segment() " Caleb Sander Mateos
2025-11-07 0:10 ` Ming Lei
2025-11-06 23:30 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176247181033.292880.16085659049514901290.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.