From: Ming Lei <ming.lei@redhat.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] ublk: use rq_for_each_segment() for user copy
Date: Fri, 7 Nov 2025 08:10:41 +0800 [thread overview]
Message-ID: <aQ05AQOlm4pDnELt@fedora> (raw)
In-Reply-To: <20251106171647.2590074-3-csander@purestorage.com>
On Thu, Nov 06, 2025 at 10:16:47AM -0700, Caleb Sander Mateos wrote:
> ublk_advance_io_iter() and ublk_copy_io_pages() currently open-code the
> iteration over the request's bvecs. Switch to the rq_for_each_segment()
> macro provided by blk-mq to avoid reaching into the bio internals and
> simplify the code.
>
> Suggested-by: Ming Lei <ming.lei@redhat.com>
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Nice cleanup:
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2025-11-07 0:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 17:16 [PATCH v3 0/2] ublk: simplify user copy Caleb Sander Mateos
2025-11-06 17:16 ` [PATCH v3 1/2] ublk: use copy_{to,from}_iter() for " Caleb Sander Mateos
2025-11-06 17:16 ` [PATCH v3 2/2] ublk: use rq_for_each_segment() " Caleb Sander Mateos
2025-11-07 0:10 ` Ming Lei [this message]
2025-11-06 23:30 ` [PATCH v3 0/2] ublk: simplify " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aQ05AQOlm4pDnELt@fedora \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=csander@purestorage.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.