All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: David Howells <dhowells@redhat.com>,
	torvalds@osdl.org, steved@redhat.com, sct@redhat.com,
	aviro@redhat.com, linux-fsdevel@vger.kernel.org,
	linux-cachefs@redhat.com, nfsv4@linux-nfs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/7] FS-Cache: Generic filesystem caching facility
Date: Fri, 21 Apr 2006 20:33:49 +0100	[thread overview]
Message-ID: <17634.1145648029@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060421113805.2ec6fd74.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:

> > Modules that might depend on fscache need to know that it's there,
> 
> In theory, module A isn't supposed to care whether module B was configured,
> because module B might be compiled separately, or dowloaded from elsewhere
> or whatever.

In this case it's sort of necessary - unless you're suggesting I make FS-Cache
mandatory...

The problem is that I don't want NFS or whatever to be carrying around the
cookie pointers if FS-Cache isn't compiled as that saves memory.  But that
involves conditionally changing the composition of structures, something
that's most clearly done with cpp-conditionals.

David

WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: aviro@redhat.com, nfsv4@linux-nfs.org,
	linux-kernel@vger.kernel.org, torvalds@osdl.org,
	linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 5/7] FS-Cache: Generic filesystem caching facility
Date: Fri, 21 Apr 2006 20:33:49 +0100	[thread overview]
Message-ID: <17634.1145648029@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060421113805.2ec6fd74.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:

> > Modules that might depend on fscache need to know that it's there,
> 
> In theory, module A isn't supposed to care whether module B was configured,
> because module B might be compiled separately, or dowloaded from elsewhere
> or whatever.

In this case it's sort of necessary - unless you're suggesting I make FS-Cache
mandatory...

The problem is that I don't want NFS or whatever to be carrying around the
cookie pointers if FS-Cache isn't compiled as that saves memory.  But that
involves conditionally changing the composition of structures, something
that's most clearly done with cpp-conditionals.

David

  reply	other threads:[~2006-04-21 19:34 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-20 16:59 [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit David Howells
2006-04-20 16:59 ` [PATCH 2/7] FS-Cache: Add notification of page becoming writable to VMA ops David Howells
2006-04-20 17:40   ` Zach Brown
2006-04-20 18:27     ` Anton Altaparmakov
2006-04-20 16:59 ` [PATCH 3/7] FS-Cache: Avoid ENFILE checking for kernel-specific open files David Howells
2006-04-20 17:18   ` Christoph Hellwig
2006-04-20 18:06     ` David Howells
2006-04-20 18:06       ` David Howells
2006-04-21  0:11       ` Andrew Morton
2006-04-21  0:11         ` Andrew Morton
2006-04-21 10:57         ` David Howells
2006-04-21 10:57           ` David Howells
2006-04-21  0:07   ` Andrew Morton
2006-04-21  0:07     ` Andrew Morton
2006-04-21 12:33     ` David Howells
2006-04-21 12:33       ` David Howells
2006-04-21 18:22       ` Andrew Morton
2006-04-21 18:22         ` Andrew Morton
2006-04-21 19:29         ` David Howells
2006-04-21 19:29           ` David Howells
2006-04-20 16:59 ` [PATCH 4/7] FS-Cache: Export find_get_pages() David Howells
2006-04-20 17:19   ` Christoph Hellwig
2006-04-20 17:19     ` Christoph Hellwig
2006-04-20 17:45     ` David Howells
2006-04-20 17:45       ` David Howells
2006-04-21  0:15       ` Andrew Morton
2006-04-21  0:15         ` Andrew Morton
2006-04-21 13:02         ` David Howells
2006-04-21 13:02           ` David Howells
2006-04-20 16:59 ` [PATCH 5/7] FS-Cache: Generic filesystem caching facility David Howells
2006-04-21  0:46   ` Andrew Morton
2006-04-21  0:46     ` Andrew Morton
2006-04-21 14:15     ` David Howells
2006-04-21 14:15       ` David Howells
2006-04-21 18:38       ` Andrew Morton
2006-04-21 18:38         ` Andrew Morton
2006-04-21 19:33         ` David Howells [this message]
2006-04-21 19:33           ` David Howells
2006-04-20 16:59 ` [PATCH 6/7] FS-Cache: Make kAFS use FS-Cache David Howells
2006-04-20 16:59 ` [PATCH 7/7] FS-Cache: CacheFiles: A cache that backs onto a mounted filesystem David Howells
2006-04-21  0:57   ` Andrew Morton
2006-04-21  0:57     ` Andrew Morton
2006-04-21  1:16   ` Andrew Morton
2006-04-21  1:16     ` Andrew Morton
2006-04-21 14:49     ` David Howells
2006-04-21 14:49       ` David Howells
2006-04-21  0:12 ` [PATCH 1/7] FS-Cache: Provide a filesystem-specific sync'able page bit Andrew Morton
2006-04-21  0:12   ` Andrew Morton
2006-04-21 10:22   ` David Howells
2006-04-21 10:22     ` David Howells
2006-04-21 10:33     ` Andrew Morton
2006-04-21 10:33       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17634.1145648029@warthog.cambridge.redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=aviro@redhat.com \
    --cc=linux-cachefs@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=sct@redhat.com \
    --cc=steved@redhat.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.