* [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name
@ 2025-11-17 9:53 Alok Tiwari
2025-11-17 13:30 ` Andrew Lunn
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Alok Tiwari @ 2025-11-17 9:53 UTC (permalink / raw)
To: linus.walleij, andrew, olteanv, kuba, davem, edumazet, pabeni,
horms, netdev
Cc: alok.a.tiwarilinux, alok.a.tiwari
The driver declares an OF match table named ks8895_spi_of_match, even
though it describes compatible strings for the KS8995 and related Micrel
switches. This is a leftover typo, the correct name should match the
chip family handled by this driver ks8995, and also match the variable
used in spi_driver.of_match_table.
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
---
drivers/net/dsa/ks8995.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/ks8995.c b/drivers/net/dsa/ks8995.c
index 5c4c83e00477..77d8b842693c 100644
--- a/drivers/net/dsa/ks8995.c
+++ b/drivers/net/dsa/ks8995.c
@@ -203,13 +203,13 @@ static const struct spi_device_id ks8995_id[] = {
};
MODULE_DEVICE_TABLE(spi, ks8995_id);
-static const struct of_device_id ks8895_spi_of_match[] = {
+static const struct of_device_id ks8995_spi_of_match[] = {
{ .compatible = "micrel,ks8995" },
{ .compatible = "micrel,ksz8864" },
{ .compatible = "micrel,ksz8795" },
{ },
};
-MODULE_DEVICE_TABLE(of, ks8895_spi_of_match);
+MODULE_DEVICE_TABLE(of, ks8995_spi_of_match);
static inline u8 get_chip_id(u8 val)
{
@@ -842,7 +842,7 @@ static void ks8995_remove(struct spi_device *spi)
static struct spi_driver ks8995_driver = {
.driver = {
.name = "spi-ks8995",
- .of_match_table = ks8895_spi_of_match,
+ .of_match_table = ks8995_spi_of_match,
},
.probe = ks8995_probe,
.remove = ks8995_remove,
--
2.50.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name
2025-11-17 9:53 [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name Alok Tiwari
@ 2025-11-17 13:30 ` Andrew Lunn
2025-11-18 22:39 ` Linus Walleij
2025-11-19 2:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2025-11-17 13:30 UTC (permalink / raw)
To: Alok Tiwari
Cc: linus.walleij, olteanv, kuba, davem, edumazet, pabeni, horms,
netdev, alok.a.tiwarilinux
On Mon, Nov 17, 2025 at 01:53:50AM -0800, Alok Tiwari wrote:
> The driver declares an OF match table named ks8895_spi_of_match, even
> though it describes compatible strings for the KS8995 and related Micrel
> switches. This is a leftover typo, the correct name should match the
> chip family handled by this driver ks8995, and also match the variable
> used in spi_driver.of_match_table.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name
2025-11-17 9:53 [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name Alok Tiwari
2025-11-17 13:30 ` Andrew Lunn
@ 2025-11-18 22:39 ` Linus Walleij
2025-11-19 2:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2025-11-18 22:39 UTC (permalink / raw)
To: Alok Tiwari
Cc: andrew, olteanv, kuba, davem, edumazet, pabeni, horms, netdev,
alok.a.tiwarilinux
On Mon, Nov 17, 2025 at 10:54 AM Alok Tiwari <alok.a.tiwari@oracle.com> wrote:
> The driver declares an OF match table named ks8895_spi_of_match, even
> though it describes compatible strings for the KS8995 and related Micrel
> switches. This is a leftover typo, the correct name should match the
> chip family handled by this driver ks8995, and also match the variable
> used in spi_driver.of_match_table.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name
2025-11-17 9:53 [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name Alok Tiwari
2025-11-17 13:30 ` Andrew Lunn
2025-11-18 22:39 ` Linus Walleij
@ 2025-11-19 2:40 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-19 2:40 UTC (permalink / raw)
To: Alok Tiwari
Cc: linus.walleij, andrew, olteanv, kuba, davem, edumazet, pabeni,
horms, netdev, alok.a.tiwarilinux
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 17 Nov 2025 01:53:50 -0800 you wrote:
> The driver declares an OF match table named ks8895_spi_of_match, even
> though it describes compatible strings for the KS8995 and related Micrel
> switches. This is a leftover typo, the correct name should match the
> chip family handled by this driver ks8995, and also match the variable
> used in spi_driver.of_match_table.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
>
> [...]
Here is the summary with links:
- [net-next] net: dsa: ks8995: Fix incorrect OF match table name
https://git.kernel.org/netdev/net-next/c/eb74ae2f87d2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-19 2:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-17 9:53 [PATCH net-next] net: dsa: ks8995: Fix incorrect OF match table name Alok Tiwari
2025-11-17 13:30 ` Andrew Lunn
2025-11-18 22:39 ` Linus Walleij
2025-11-19 2:40 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.