All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Nicolau, Radu" <radu.nicolau@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] app/testpmd: fix build without ixgbe
Date: Fri, 16 Jun 2017 16:09:04 +0200	[thread overview]
Message-ID: <1764991.rUGqORsVcK@xps> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CF493@shsmsx102.ccr.corp.intel.com>

16/06/2017 03:29, Lu, Wenzhuo:
> From: Nicolau, Radu
> > 
> > Looks ok to me, but why would one enable IXGBE_BYPASS without enabling
> > IXGBE?
> 
> Although the scenario doesn't make sense, I think it's better to add more check to avoid the users making any mistake.

Applied

  reply	other threads:[~2017-06-16 14:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  9:54 [PATCH] app/testpmd: fix build without ixgbe Thomas Monjalon
2017-06-15 11:37 ` Radu Nicolau
2017-06-15 12:48   ` Thomas Monjalon
2017-06-16  1:29   ` Lu, Wenzhuo
2017-06-16 14:09     ` Thomas Monjalon [this message]
  -- strict thread matches above, loose matches on Subject: below --
2017-06-15  7:26 cmdline.c: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function) Jan Viktorin
2017-06-15 10:17 ` [PATCH] app/testpmd: fix build without ixgbe Thomas Monjalon
2017-06-15 16:35   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1764991.rUGqORsVcK@xps \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=radu.nicolau@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.