From: Thomas Monjalon <thomas@monjalon.net>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: wenzhuo.lu@intel.com, dev@dpdk.org
Subject: Re: [PATCH] app/testpmd: fix build without ixgbe
Date: Thu, 15 Jun 2017 14:48:32 +0200 [thread overview]
Message-ID: <5294711.b1ZTK55eI0@xps> (raw)
In-Reply-To: <ff6185d5-5d11-3c1b-4138-7b040ae35394@intel.com>
15/06/2017 13:37, Radu Nicolau:
> Looks ok to me, but why would one enable IXGBE_BYPASS without enabling
> IXGBE?
[...]
> > -#ifdef RTE_LIBRTE_IXGBE_BYPASS
> > +#if defined RTE_LIBRTE_IXGBE_PMD && defined RTE_LIBRTE_IXGBE_BYPASS
RTE_LIBRTE_IXGBE_BYPASS should not be enabled if RTE_LIBRTE_IXGBE_PMD is disabled.
But it can happen in some scripted configuration like test-build.sh does.
Anyway we should drop the RTE_LIBRTE_IXGBE_BYPASS configuration option
and enables it always.
next prev parent reply other threads:[~2017-06-15 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 9:54 [PATCH] app/testpmd: fix build without ixgbe Thomas Monjalon
2017-06-15 11:37 ` Radu Nicolau
2017-06-15 12:48 ` Thomas Monjalon [this message]
2017-06-16 1:29 ` Lu, Wenzhuo
2017-06-16 14:09 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2017-06-15 7:26 cmdline.c: error: ‘cmd_set_vf_rxmode’ undeclared here (not in a function) Jan Viktorin
2017-06-15 10:17 ` [PATCH] app/testpmd: fix build without ixgbe Thomas Monjalon
2017-06-15 16:35 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5294711.b1ZTK55eI0@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=radu.nicolau@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.