* [PATCH BlueZ v1] l2cap-test: Add tests for LE 2M and Coded PHYs
@ 2025-12-11 20:39 Luiz Augusto von Dentz
2025-12-11 21:36 ` [BlueZ,v1] " bluez.test.bot
2025-12-12 15:30 ` [PATCH BlueZ v1] " patchwork-bot+bluetooth
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2025-12-11 20:39 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This adds the following tests that uses BT_PHY to retrieve the ACL/LE
connection supported LE 2M and Coded PHYs:
L2CAP LE Client - PHY 2M/Coded
L2CAP LE Server - PHY 2M/Coded
L2CAP Ext-Flowctl Client - PHY 2M/Coded
L2CAP Ext-Flowctl Server - PHY 2M/Coded
---
tools/l2cap-tester.c | 110 +++++++++++++++++++++++++++++++++----------
1 file changed, 86 insertions(+), 24 deletions(-)
diff --git a/tools/l2cap-tester.c b/tools/l2cap-tester.c
index 2706a4b33f7b..4cb56e98078a 100644
--- a/tools/l2cap-tester.c
+++ b/tools/l2cap-tester.c
@@ -265,13 +265,13 @@ static void test_data_free(void *test_data)
free(data);
}
-#define test_l2cap_bredr(name, data, setup, func) \
+#define test_l2cap(name, type, data, setup, func) \
do { \
struct test_data *user; \
user = malloc(sizeof(struct test_data)); \
if (!user) \
break; \
- user->hciemu_type = HCIEMU_TYPE_BREDR; \
+ user->hciemu_type = type; \
user->io_id = 0; \
user->err_io_id = 0; \
user->test_data = data; \
@@ -280,20 +280,14 @@ static void test_data_free(void *test_data)
test_post_teardown, 2, user, test_data_free); \
} while (0)
+#define test_l2cap_bredr(name, data, setup, func) \
+ test_l2cap(name, HCIEMU_TYPE_BREDR, data, setup, func)
+
#define test_l2cap_le(name, data, setup, func) \
- do { \
- struct test_data *user; \
- user = malloc(sizeof(struct test_data)); \
- if (!user) \
- break; \
- user->hciemu_type = HCIEMU_TYPE_LE; \
- user->io_id = 0; \
- user->err_io_id = 0; \
- user->test_data = data; \
- tester_add_full(name, data, \
- test_pre_setup, setup, func, NULL, \
- test_post_teardown, 2, user, test_data_free); \
- } while (0)
+ test_l2cap(name, HCIEMU_TYPE_LE, data, setup, func)
+
+#define test_l2cap_le_52(name, data, setup, func) \
+ test_l2cap(name, HCIEMU_TYPE_BREDRLE52, data, setup, func)
static uint8_t pair_device_pin[] = { 0x30, 0x30, 0x30, 0x30 }; /* "0000" */
@@ -704,6 +698,14 @@ static const struct l2cap_data le_client_connect_phy_test_1 = {
.phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX),
};
+static const struct l2cap_data le_client_connect_phy_2m_coded_test_1 = {
+ .client_psm = 0x0080,
+ .server_psm = 0x0080,
+ .phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX |
+ BT_PHY_LE_2M_TX | BT_PHY_LE_2M_RX |
+ BT_PHY_LE_CODED_TX | BT_PHY_LE_CODED_RX),
+};
+
static uint8_t nonexisting_bdaddr[] = {0x00, 0xAA, 0x01, 0x02, 0x03, 0x00};
static const struct l2cap_data le_client_close_socket_test_1 = {
.client_psm = 0x0080,
@@ -792,6 +794,19 @@ static const struct l2cap_data le_server_phy_test = {
.phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX),
};
+static const struct l2cap_data le_server_phy_2m_coded_test = {
+ .server_psm = 0x0080,
+ .send_cmd_code = BT_L2CAP_PDU_LE_CONN_REQ,
+ .send_cmd = le_connect_req,
+ .send_cmd_len = sizeof(le_connect_req),
+ .expect_cmd_code = BT_L2CAP_PDU_LE_CONN_RSP,
+ .expect_cmd = le_connect_rsp,
+ .expect_cmd_len = sizeof(le_connect_rsp),
+ .phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX |
+ BT_PHY_LE_2M_TX | BT_PHY_LE_2M_RX |
+ BT_PHY_LE_CODED_TX | BT_PHY_LE_CODED_RX),
+};
+
static const uint8_t ecred_connect_req[] = { 0x80, 0x00, /* PSM */
0x40, 0x00, /* MTU */
0x40, 0x00, /* MPS */
@@ -861,6 +876,19 @@ static const struct l2cap_data ext_flowctl_server_phy_test = {
.phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX),
};
+static const struct l2cap_data ext_flowctl_server_phy_2m_coded_test = {
+ .server_psm = 0x0080,
+ .send_cmd_code = BT_L2CAP_PDU_ECRED_CONN_REQ,
+ .send_cmd = ecred_connect_req,
+ .send_cmd_len = sizeof(ecred_connect_req),
+ .expect_cmd_code = BT_L2CAP_PDU_ECRED_CONN_RSP,
+ .expect_cmd = ecred_connect_rsp,
+ .expect_cmd_len = sizeof(ecred_connect_rsp),
+ .phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX |
+ BT_PHY_LE_2M_TX | BT_PHY_LE_2M_RX |
+ BT_PHY_LE_CODED_TX | BT_PHY_LE_CODED_RX),
+};
+
static const struct l2cap_data le_att_client_connect_success_test_1 = {
.cid = 0x0004,
.sec_level = BT_SECURITY_LOW,
@@ -994,6 +1022,15 @@ static const struct l2cap_data ext_flowctl_client_connect_phy_test_1 = {
.phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX),
};
+static const struct l2cap_data ext_flowctl_client_phy_2m_coded_test_1 = {
+ .client_psm = 0x0080,
+ .server_psm = 0x0080,
+ .mode = BT_MODE_EXT_FLOWCTL,
+ .phys = (BT_PHY_LE_1M_TX | BT_PHY_LE_1M_RX |
+ BT_PHY_LE_2M_TX | BT_PHY_LE_2M_RX |
+ BT_PHY_LE_CODED_TX | BT_PHY_LE_CODED_RX),
+};
+
static void client_cmd_complete(uint16_t opcode, uint8_t status,
const void *param, uint8_t len,
void *user_data)
@@ -1007,6 +1044,7 @@ static void client_cmd_complete(uint16_t opcode, uint8_t status,
switch (opcode) {
case BT_HCI_CMD_WRITE_SCAN_ENABLE:
case BT_HCI_CMD_LE_SET_ADV_ENABLE:
+ case BT_HCI_CMD_LE_SET_EXT_ADV_ENABLE:
tester_print("Client set connectable status 0x%02x", status);
if (!status && test && test->enable_ssp) {
bthost_write_ssp_mode(bthost, 0x01);
@@ -1067,10 +1105,14 @@ static void setup_powered_client_callback(uint8_t status, uint16_t length,
bthost = hciemu_client_get_host(data->hciemu);
bthost_set_cmd_complete_cb(bthost, client_cmd_complete, user_data);
- if (data->hciemu_type == HCIEMU_TYPE_LE) {
- if (!l2data || !l2data->server_not_advertising)
- bthost_set_adv_enable(bthost, 0x01);
- else
+ if (data->hciemu_type >= HCIEMU_TYPE_LE) {
+ if (!l2data || !l2data->server_not_advertising) {
+ if (data->hciemu_type > HCIEMU_TYPE_LE) {
+ bthost_set_ext_adv_params(bthost, 0x00);
+ bthost_set_ext_adv_enable(bthost, 0x01);
+ } else
+ bthost_set_adv_enable(bthost, 0x01);
+ } else
tester_setup_complete();
} else {
bthost_write_scan_enable(bthost, 0x03);
@@ -1182,7 +1224,7 @@ static void send_rsp_new_conn(uint16_t handle, void *user_data)
data->handle = handle;
- if (data->hciemu_type == HCIEMU_TYPE_LE)
+ if (data->hciemu_type >= HCIEMU_TYPE_LE)
data->dcid = 0x0005;
else
data->dcid = 0x0001;
@@ -1217,7 +1259,7 @@ static void setup_powered_common(void)
if (test && test->reject_ssp)
bthost_set_reject_user_confirm(bthost, true);
- if (data->hciemu_type == HCIEMU_TYPE_LE)
+ if (data->hciemu_type >= HCIEMU_TYPE_LE)
mgmt_send(data->mgmt, MGMT_OP_SET_LE, data->mgmt_index,
sizeof(param), param, NULL, NULL, NULL);
@@ -1249,6 +1291,10 @@ static void setup_powered_client(const void *test_data)
data->mgmt_index, sizeof(param), param,
NULL, NULL, NULL);
+ if (data->hciemu_type > HCIEMU_TYPE_LE)
+ mgmt_send(data->mgmt, MGMT_OP_SET_LE, data->mgmt_index,
+ sizeof(param), param, NULL, NULL, NULL);
+
mgmt_send(data->mgmt, MGMT_OP_SET_POWERED, data->mgmt_index,
sizeof(param), param, setup_powered_client_callback,
NULL, NULL);
@@ -1266,6 +1312,10 @@ static void setup_powered_server(const void *test_data)
mgmt_send(data->mgmt, MGMT_OP_SET_CONNECTABLE, data->mgmt_index,
sizeof(param), param, NULL, NULL, NULL);
+ if (data->hciemu_type > HCIEMU_TYPE_LE)
+ mgmt_send(data->mgmt, MGMT_OP_SET_LE, data->mgmt_index,
+ sizeof(param), param, NULL, NULL, NULL);
+
if (data->hciemu_type != HCIEMU_TYPE_BREDR)
mgmt_send(data->mgmt, MGMT_OP_SET_ADVERTISING,
data->mgmt_index, sizeof(param), param, NULL,
@@ -1403,7 +1453,7 @@ static bool check_mtu(struct test_data *data, int sk)
memset(&data->l2o, 0, sizeof(data->l2o));
- if (data->hciemu_type == HCIEMU_TYPE_LE &&
+ if (data->hciemu_type >= HCIEMU_TYPE_LE &&
(l2data->client_psm || l2data->server_psm)) {
/* LE CoC enabled kernels should support BT_RCVMTU and
* BT_SNDMTU.
@@ -1701,7 +1751,7 @@ static int create_l2cap_sock(struct test_data *data, uint16_t psm,
if (l2data && l2data->addr_type_avail)
addr.l2_bdaddr_type = l2data->addr_type;
- else if (data->hciemu_type == HCIEMU_TYPE_LE)
+ else if (data->hciemu_type >= HCIEMU_TYPE_LE )
addr.l2_bdaddr_type = BDADDR_LE_PUBLIC;
else
addr.l2_bdaddr_type = BDADDR_BREDR;
@@ -1792,7 +1842,7 @@ static int connect_l2cap_sock(struct test_data *data, int sk, uint16_t psm,
if (l2data && l2data->addr_type_avail)
bdaddr_type = l2data->addr_type;
- else if (data->hciemu_type == HCIEMU_TYPE_LE)
+ else if (data->hciemu_type >= HCIEMU_TYPE_LE)
bdaddr_type = BDADDR_LE_PUBLIC;
else
bdaddr_type = BDADDR_BREDR;
@@ -2810,6 +2860,9 @@ int main(int argc, char *argv[])
test_l2cap_le("L2CAP LE Client - PHY",
&le_client_connect_phy_test_1,
setup_powered_client, test_connect);
+ test_l2cap_le_52("L2CAP LE Client - PHY 2M/Coded",
+ &le_client_connect_phy_2m_coded_test_1,
+ setup_powered_client, test_connect);
test_l2cap_le("L2CAP LE Client - Close socket 1",
&le_client_close_socket_test_1,
@@ -2840,6 +2893,9 @@ int main(int argc, char *argv[])
setup_powered_server, test_server);
test_l2cap_le("L2CAP LE Server - PHY", &le_server_phy_test,
setup_powered_server, test_server);
+ test_l2cap_le_52("L2CAP LE Server - PHY 2M/Coded",
+ &le_server_phy_2m_coded_test,
+ setup_powered_server, test_server);
test_l2cap_le("L2CAP Ext-Flowctl Client - Success",
&ext_flowctl_client_connect_success_test_1,
@@ -2873,6 +2929,9 @@ int main(int argc, char *argv[])
test_l2cap_le("L2CAP Ext-Flowctl Client - PHY",
&ext_flowctl_client_connect_phy_test_1,
setup_powered_client, test_connect);
+ test_l2cap_le_52("L2CAP Ext-Flowctl Client - PHY 2M/Coded",
+ &ext_flowctl_client_phy_2m_coded_test_1,
+ setup_powered_client, test_connect);
test_l2cap_le("L2CAP Ext-Flowctl Server - Success",
&ext_flowctl_server_success_test,
@@ -2883,6 +2942,9 @@ int main(int argc, char *argv[])
test_l2cap_le("L2CAP Ext-Flowctl Server - PHY",
&ext_flowctl_server_phy_test,
setup_powered_server, test_server);
+ test_l2cap_le_52("L2CAP Ext-Flowctl Server - PHY 2M/Coded",
+ &ext_flowctl_server_phy_2m_coded_test,
+ setup_powered_server, test_server);
test_l2cap_le("L2CAP LE ATT Client - Success",
&le_att_client_connect_success_test_1,
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [BlueZ,v1] l2cap-test: Add tests for LE 2M and Coded PHYs
2025-12-11 20:39 [PATCH BlueZ v1] l2cap-test: Add tests for LE 2M and Coded PHYs Luiz Augusto von Dentz
@ 2025-12-11 21:36 ` bluez.test.bot
2025-12-12 15:30 ` [PATCH BlueZ v1] " patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: bluez.test.bot @ 2025-12-11 21:36 UTC (permalink / raw)
To: linux-bluetooth, luiz.dentz
[-- Attachment #1: Type: text/plain, Size: 1262 bytes --]
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=1032433
---Test result---
Test Summary:
CheckPatch PENDING 0.28 seconds
GitLint PENDING 0.26 seconds
BuildEll PASS 21.43 seconds
BluezMake PASS 666.14 seconds
MakeCheck PASS 21.83 seconds
MakeDistcheck PASS 249.66 seconds
CheckValgrind PASS 308.70 seconds
CheckSmatch PASS 361.49 seconds
bluezmakeextell PASS 187.80 seconds
IncrementalBuild PENDING 0.32 seconds
ScanBuild PASS 1059.70 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:
---
Regards,
Linux Bluetooth
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ v1] l2cap-test: Add tests for LE 2M and Coded PHYs
2025-12-11 20:39 [PATCH BlueZ v1] l2cap-test: Add tests for LE 2M and Coded PHYs Luiz Augusto von Dentz
2025-12-11 21:36 ` [BlueZ,v1] " bluez.test.bot
@ 2025-12-12 15:30 ` patchwork-bot+bluetooth
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+bluetooth @ 2025-12-12 15:30 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth
Hello:
This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Thu, 11 Dec 2025 15:39:27 -0500 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> This adds the following tests that uses BT_PHY to retrieve the ACL/LE
> connection supported LE 2M and Coded PHYs:
>
> L2CAP LE Client - PHY 2M/Coded
> L2CAP LE Server - PHY 2M/Coded
> L2CAP Ext-Flowctl Client - PHY 2M/Coded
> L2CAP Ext-Flowctl Server - PHY 2M/Coded
>
> [...]
Here is the summary with links:
- [BlueZ,v1] l2cap-test: Add tests for LE 2M and Coded PHYs
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=44a1d0c73ab5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-12-12 15:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-11 20:39 [PATCH BlueZ v1] l2cap-test: Add tests for LE 2M and Coded PHYs Luiz Augusto von Dentz
2025-12-11 21:36 ` [BlueZ,v1] " bluez.test.bot
2025-12-12 15:30 ` [PATCH BlueZ v1] " patchwork-bot+bluetooth
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.