From: Peter Wu <lekensteyn@gmail.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Francois Romieu <romieu@fr.zoreil.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: [PATCH v2] r8169: remove "PHY reset until link up" log spam
Date: Tue, 23 Jul 2013 14:38:46 +0200 [thread overview]
Message-ID: <1765554.SGJMeyexPP@al> (raw)
In-Reply-To: <51EE75A1.3070804@cogentembedded.com>
This message was added in commit a7154cb8 (June 2004, [PATCH] r8169:
link handling and phy reset rework) and is printed every ten seconds
when no cable is connected. (Before that commit, "Reset RTL8169s PHY"
would be printed instead.)
Signed-off-by: Peter Wu <lekensteyn@gmail.com>
---
On Tuesday 23 July 2013 16:22:57 Sergei Shtylyov wrote:
> On 23-07-2013 13:55, Peter Wu wrote:
> > This message was added in commit a7154cb8 (June 2004) and is printed
>
> Please also specify that commit's summary line in parens.
Done, while at it I have also noted that an other spam message would be
logged.
---
drivers/net/ethernet/realtek/r8169.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 880015c..63f04af 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -3689,8 +3689,6 @@ static void rtl_phy_work(struct rtl8169_private *tp)
if (tp->link_ok(ioaddr))
return;
- netif_warn(tp, link, tp->dev, "PHY reset until link up\n");
-
tp->phy_reset_enable(tp);
out_mod_timer:
--
1.8.3.3
next prev parent reply other threads:[~2013-07-23 12:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 9:55 r8169: remove "PHY reset until link up" log spam Peter Wu
2013-07-23 12:22 ` Sergei Shtylyov
2013-07-23 12:38 ` Peter Wu [this message]
2013-07-23 20:23 ` [PATCH v2] " Francois Romieu
2013-07-23 20:48 ` Peter Wu
2013-07-23 21:50 ` Francois Romieu
2013-07-23 15:54 ` Stephen Hemminger
2013-07-23 16:07 ` Peter Wu
2013-07-23 16:17 ` Stephen Hemminger
2013-07-23 21:18 ` Stephen Hemminger
2013-07-23 20:23 ` Francois Romieu
2013-07-23 20:59 ` Peter Wu
2013-07-23 21:51 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1765554.SGJMeyexPP@al \
--to=lekensteyn@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.