From: Peter Wu <lekensteyn@gmail.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, nic_swsd@realtek.com
Subject: Re: [PATCH v2] r8169: remove "PHY reset until link up" log spam
Date: Tue, 23 Jul 2013 22:48:51 +0200 [thread overview]
Message-ID: <7176161.ct75f9bf8d@al> (raw)
In-Reply-To: <20130723202312.GA31567@electric-eye.fr.zoreil.com>
On Tuesday 23 July 2013 22:23:12 Francois Romieu wrote:
> Peter Wu <lekensteyn@gmail.com> :
> > This message was added in commit a7154cb8 (June 2004, [PATCH] r8169:
> > link handling and phy reset rework) and is printed every ten seconds
> > when no cable is connected.
>
> + and runtime power management is disabled.
> It isn't completely academic: Fedora has it enabled.
I have not really considered runtime PM before, aren't the ethtool operations
actually broken with runtime PM enabled? Or does the ethtool core take care of
waking devices (which I doubt)? I don't see any attempt to wake devices in the
r8169 ethtool operations.
> You have the implicit ack of David, so please keep the facts right.
I am not trying to hide details, before I send the third revision of third
commit message, what other details may I have overseen? If you want to, you
can also create a patch with an appropriate commit message, I don't mind.
Regards,
Peter
next prev parent reply other threads:[~2013-07-23 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 9:55 r8169: remove "PHY reset until link up" log spam Peter Wu
2013-07-23 12:22 ` Sergei Shtylyov
2013-07-23 12:38 ` [PATCH v2] " Peter Wu
2013-07-23 20:23 ` Francois Romieu
2013-07-23 20:48 ` Peter Wu [this message]
2013-07-23 21:50 ` Francois Romieu
2013-07-23 15:54 ` Stephen Hemminger
2013-07-23 16:07 ` Peter Wu
2013-07-23 16:17 ` Stephen Hemminger
2013-07-23 21:18 ` Stephen Hemminger
2013-07-23 20:23 ` Francois Romieu
2013-07-23 20:59 ` Peter Wu
2013-07-23 21:51 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7176161.ct75f9bf8d@al \
--to=lekensteyn@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=romieu@fr.zoreil.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.