From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Network Development <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
LKML <linux-kernel@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h
Date: Fri, 15 Dec 2017 12:48:39 +0100 [thread overview]
Message-ID: <1780732.fBLghQceHc@bentobox> (raw)
In-Reply-To: <2907097.8HHYkPN8Gn@bentobox>
[-- Attachment #1: Type: text/plain, Size: 1223 bytes --]
On Freitag, 15. Dezember 2017 11:32:05 CET Sven Eckelmann wrote:
> On Mittwoch, 6. Dezember 2017 11:58:14 CET Willem de Bruijn wrote:
> [...]
> > >> > ---
> > >> > MAINTAINERS | 2 +-
> > >> > include/uapi/linux/{batman_adv.h => batadv_genl.h} | 6 +++---
> > >>
> > >> This and the previous patch changes uapi. That might break userspace
> > >> applications that rely on it.
> > >
> > > I am not aware of any application because all (alfred, batctl and some gluon
> > > integration) of them currently ship their own copy because distribution didn't
> > > catch up. And this is also the reason why I want to do it now - not later.
> >
> > That assumes that you know all applications, including those not
> > publicly available. It may be true in this instance, but it is not
> > possible to be certain.
>
> I've just talked with Simon. Because you have a problem with these two
> changes, he suggested that I should drop these two patches and merge packet.h
> with the uapi batadv genl header batman_adv.h
No, this is also bad because batman_adv.h is MIT license and packet.h is
GPL-2. So what other name would you suggest for packet.h? batman_adv_packet.h?
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-12-15 11:48 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 14:35 [B.A.T.M.A.N.] [RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 1/6] batman-adv: Change nl references to genl Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-06 16:42 ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-06 16:42 ` Willem de Bruijn
2017-12-06 16:55 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-06 16:58 ` Willem de Bruijn
2017-12-06 16:58 ` Willem de Bruijn
2017-12-15 10:32 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-15 11:48 ` Sven Eckelmann [this message]
2017-12-15 16:57 ` Willem de Bruijn
2017-12-15 17:18 ` Sven Eckelmann
2017-12-15 17:18 ` Sven Eckelmann
2017-12-15 17:23 ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 3/6] batman-adv: Let packet.h include its headers directly Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 5/6] batman-adv: Convert packet.h to uapi header Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 17:19 ` [B.A.T.M.A.N.] " Tom Herbert
2017-12-05 17:19 ` Tom Herbert
2017-12-06 10:26 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-06 10:26 ` Sven Eckelmann
2017-12-06 16:54 ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-06 16:54 ` Willem de Bruijn
2017-12-06 16:54 ` Willem de Bruijn
2017-12-06 17:10 ` [B.A.T.M.A.N.] " Tom Herbert
2017-12-06 17:10 ` Tom Herbert
2017-12-06 17:27 ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-06 17:27 ` Sven Eckelmann
2017-12-06 17:27 ` Sven Eckelmann
2017-12-06 18:24 ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-06 18:24 ` Willem de Bruijn
2017-12-06 18:24 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1780732.fBLghQceHc@bentobox \
--to=sven.eckelmann@openmesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.