All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Tom Herbert <tom@herbertland.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jiri Pirko <jiri@mellanox.com>,
	Eric Dumazet <edumazet@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers
Date: Wed, 06 Dec 2017 18:27:37 +0100	[thread overview]
Message-ID: <7082766.sOGqpe4oL6@bentobox> (raw)
In-Reply-To: <CAF=yD-LR5WSQt5jwN-+T-1iWyrxovk0qZ1cb-QUO6_+Wy8Ci-A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote:
> Perhaps it can even be behind a static key depending on whether any
> devices are active, adjusted in batadv_hardif_(en|dis)able_interface.

I don't like that because we don't need batman-adv loaded to simply forward 
(bridge) traffic between interfaces. And not being able to use RPS with 
multiple cores just because the batman-adv module (and interfaces) is not 
enabled seems to be counter-intuitive.


> Please implement FLOW_DISSECTOR_F_STOP_AT_ENCAP. It may
> be used in more flow dissector paths in the future.
> 
> The features are also used by GRE, which can encap Ethernet, for an example
> that is closer to this protocol.

Thanks for the feedback. I have it now implemented like in GRE.

The change can already be found in
 https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/ecsv/flowdissector

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven.eckelmann@openmesh.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Tom Herbert <tom@herbertland.com>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Jiri Pirko <jiri@mellanox.com>,
	Eric Dumazet <edumazet@google.com>,
	LKML <linux-kernel@vger.kernel.org>,
	b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers
Date: Wed, 06 Dec 2017 18:27:37 +0100	[thread overview]
Message-ID: <7082766.sOGqpe4oL6@bentobox> (raw)
In-Reply-To: <CAF=yD-LR5WSQt5jwN-+T-1iWyrxovk0qZ1cb-QUO6_+Wy8Ci-A@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote:
> Perhaps it can even be behind a static key depending on whether any
> devices are active, adjusted in batadv_hardif_(en|dis)able_interface.

I don't like that because we don't need batman-adv loaded to simply forward 
(bridge) traffic between interfaces. And not being able to use RPS with 
multiple cores just because the batman-adv module (and interfaces) is not 
enabled seems to be counter-intuitive.


> Please implement FLOW_DISSECTOR_F_STOP_AT_ENCAP. It may
> be used in more flow dissector paths in the future.
> 
> The features are also used by GRE, which can encap Ethernet, for an example
> that is closer to this protocol.

Thanks for the feedback. I have it now implemented like in GRE.

The change can already be found in
 https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/ecsv/flowdissector

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven.eckelmann-lv6y7wLVQPlWk0Htik3J/w@public.gmane.org>
To: Willem de Bruijn
	<willemdebruijn.kernel-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Eric Dumazet <edumazet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	Tom Herbert <tom-BjP2VixgY4xUbtYUoyoikg@public.gmane.org>,
	b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Jiri Pirko <jiri-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Linux Kernel Network Developers
	<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"David S . Miller"
	<davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
Subject: Re: [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers
Date: Wed, 06 Dec 2017 18:27:37 +0100	[thread overview]
Message-ID: <7082766.sOGqpe4oL6@bentobox> (raw)
In-Reply-To: <CAF=yD-LR5WSQt5jwN-+T-1iWyrxovk0qZ1cb-QUO6_+Wy8Ci-A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 907 bytes --]

On Mittwoch, 6. Dezember 2017 11:54:13 CET Willem de Bruijn wrote:
> Perhaps it can even be behind a static key depending on whether any
> devices are active, adjusted in batadv_hardif_(en|dis)able_interface.

I don't like that because we don't need batman-adv loaded to simply forward 
(bridge) traffic between interfaces. And not being able to use RPS with 
multiple cores just because the batman-adv module (and interfaces) is not 
enabled seems to be counter-intuitive.


> Please implement FLOW_DISSECTOR_F_STOP_AT_ENCAP. It may
> be used in more flow dissector paths in the future.
> 
> The features are also used by GRE, which can encap Ethernet, for an example
> that is closer to this protocol.

Thanks for the feedback. I have it now implemented like in GRE.

The change can already be found in
 https://git.open-mesh.org/linux-merge.git/shortlog/refs/heads/ecsv/flowdissector

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2017-12-06 17:27 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-05 14:35 [B.A.T.M.A.N.] [RFC v2 0/6] flow_dissector: Provide basic batman-adv unicast handling Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 1/6] batman-adv: Change nl references to genl Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 2/6] batman-adv: Rename batman-adv.h to batadv_genl.h Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-06 16:42   ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-06 16:42     ` Willem de Bruijn
2017-12-06 16:55     ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-06 16:58       ` Willem de Bruijn
2017-12-06 16:58         ` Willem de Bruijn
2017-12-15 10:32         ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-15 11:48           ` Sven Eckelmann
2017-12-15 16:57             ` Willem de Bruijn
2017-12-15 17:18               ` Sven Eckelmann
2017-12-15 17:18                 ` Sven Eckelmann
2017-12-15 17:23                 ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 3/6] batman-adv: Let packet.h include its headers directly Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 4/6] batman-adv: Remove usage of BIT(x) in packet.h Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 5/6] batman-adv: Convert packet.h to uapi header Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 14:35 ` [B.A.T.M.A.N.] [RFC v2 6/6] flow_dissector: Parse batman-adv unicast headers Sven Eckelmann
2017-12-05 14:35   ` Sven Eckelmann
2017-12-05 17:19   ` [B.A.T.M.A.N.] " Tom Herbert
2017-12-05 17:19     ` Tom Herbert
2017-12-06 10:26     ` [B.A.T.M.A.N.] " Sven Eckelmann
2017-12-06 10:26       ` Sven Eckelmann
2017-12-06 16:54       ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-06 16:54         ` Willem de Bruijn
2017-12-06 16:54         ` Willem de Bruijn
2017-12-06 17:10         ` [B.A.T.M.A.N.] " Tom Herbert
2017-12-06 17:10           ` Tom Herbert
2017-12-06 17:27         ` Sven Eckelmann [this message]
2017-12-06 17:27           ` Sven Eckelmann
2017-12-06 17:27           ` Sven Eckelmann
2017-12-06 18:24           ` [B.A.T.M.A.N.] " Willem de Bruijn
2017-12-06 18:24             ` Willem de Bruijn
2017-12-06 18:24             ` Willem de Bruijn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7082766.sOGqpe4oL6@bentobox \
    --to=sven.eckelmann@openmesh.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.