From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Tobias Schramm <t.schramm-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Emmanuel Vadot <manu-h+KGxgPPiopAfugRpC6u6w@public.gmane.org>,
Alexis Ballier <aballier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>,
Katsuhiro Suzuki
<katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Douglas Anderson
<dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Kever Yang <kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Jagan Teki
<jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>,
Nick Xie <nick-XW3xCAIBE2TQT0dZR+AlfA@public.gmane.org>,
Andy Yan <andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Johan Jonker <jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Matthias Kaehlcke <mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Vivek Unune
<npcomplete13-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 06 Mar 2020 20:09:05 +0100 [thread overview]
Message-ID: <1783248.GgDFSgCcj8@diego> (raw)
In-Reply-To: <b30fef29-6667-9200-178b-4d0e9fc63c12-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
Hi Tobias,
Am Freitag, 6. März 2020, 19:58:45 CET schrieb Tobias Schramm:
> Hi Heiko,
>
> >> This commit adds initial dt support for the rk3399 based Pinebook Pro.
> >>
> >> Signed-off-by: Tobias Schramm <t.schramm-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
> >
> > applied for 5.7
> >
>
> any chance you can squeeze in another small fix? Somewhere in the
> process the vmcc and vqmmc supplies of the sdmmc controller were removed
> in error. Those should be added to the sdmmc controller like this:
>
> &sdmmc {
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> sd-uhs-sdr104;
> + vmmc-supply = <&vcc3v0_sd>;
> + vqmmc-supply = <&vcc_sdio>;
> status = "okay";
> };
I've amended the commit with these two properties.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Markus Reichl <m.reichl@fivetechno.de>,
Alexis Ballier <aballier@gentoo.org>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Emmanuel Vadot <manu@freebsd.org>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Kever Yang <kever.yang@rock-chips.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Nick Xie <nick@khadas.com>, Andy Yan <andy.yan@rock-chips.com>,
Johan Jonker <jbx6244@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Vivek Unune <npcomplete13@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 06 Mar 2020 20:09:05 +0100 [thread overview]
Message-ID: <1783248.GgDFSgCcj8@diego> (raw)
In-Reply-To: <b30fef29-6667-9200-178b-4d0e9fc63c12@manjaro.org>
Hi Tobias,
Am Freitag, 6. März 2020, 19:58:45 CET schrieb Tobias Schramm:
> Hi Heiko,
>
> >> This commit adds initial dt support for the rk3399 based Pinebook Pro.
> >>
> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> >
> > applied for 5.7
> >
>
> any chance you can squeeze in another small fix? Somewhere in the
> process the vmcc and vqmmc supplies of the sdmmc controller were removed
> in error. Those should be added to the sdmmc controller like this:
>
> &sdmmc {
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> sd-uhs-sdr104;
> + vmmc-supply = <&vcc3v0_sd>;
> + vqmmc-supply = <&vcc_sdio>;
> status = "okay";
> };
I've amended the commit with these two properties.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Tobias Schramm <t.schramm@manjaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Emmanuel Vadot <manu@freebsd.org>,
Alexis Ballier <aballier@gentoo.org>,
Katsuhiro Suzuki <katsuhiro@katsuster.net>,
linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Kever Yang <kever.yang@rock-chips.com>,
Markus Reichl <m.reichl@fivetechno.de>,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Jagan Teki <jagan@amarulasolutions.com>,
Nick Xie <nick@khadas.com>, Andy Yan <andy.yan@rock-chips.com>,
Johan Jonker <jbx6244@gmail.com>,
Matthias Kaehlcke <mka@chromium.org>,
Vivek Unune <npcomplete13@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for Pinebook Pro
Date: Fri, 06 Mar 2020 20:09:05 +0100 [thread overview]
Message-ID: <1783248.GgDFSgCcj8@diego> (raw)
In-Reply-To: <b30fef29-6667-9200-178b-4d0e9fc63c12@manjaro.org>
Hi Tobias,
Am Freitag, 6. März 2020, 19:58:45 CET schrieb Tobias Schramm:
> Hi Heiko,
>
> >> This commit adds initial dt support for the rk3399 based Pinebook Pro.
> >>
> >> Signed-off-by: Tobias Schramm <t.schramm@manjaro.org>
> >
> > applied for 5.7
> >
>
> any chance you can squeeze in another small fix? Somewhere in the
> process the vmcc and vqmmc supplies of the sdmmc controller were removed
> in error. Those should be added to the sdmmc controller like this:
>
> &sdmmc {
> pinctrl-names = "default";
> pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
> sd-uhs-sdr104;
> + vmmc-supply = <&vcc3v0_sd>;
> + vqmmc-supply = <&vcc_sdio>;
> status = "okay";
> };
I've amended the commit with these two properties.
Heiko
next prev parent reply other threads:[~2020-03-06 19:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 21:30 [PATCH v4 1/2] dt-bindings: Add doc for Pine64 Pinebook Pro Tobias Schramm
2020-03-04 21:30 ` Tobias Schramm
2020-03-04 21:30 ` [PATCH v4 2/2] arm64: dts: rockchip: Add initial support for " Tobias Schramm
2020-03-04 21:30 ` Tobias Schramm
[not found] ` <20200304213023.689983-3-t.schramm-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
2020-03-06 0:23 ` Heiko Stuebner
2020-03-06 0:23 ` Heiko Stuebner
2020-03-06 0:23 ` Heiko Stuebner
2020-03-06 7:22 ` Johan Jonker
2020-03-06 7:22 ` Johan Jonker
[not found] ` <7a799284-92ab-ea04-285e-37d655064118-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-03-06 9:27 ` Heiko Stübner
2020-03-06 9:27 ` Heiko Stübner
2020-03-06 9:27 ` Heiko Stübner
2020-03-06 18:58 ` Tobias Schramm
2020-03-06 18:58 ` Tobias Schramm
2020-03-06 18:58 ` Tobias Schramm
[not found] ` <b30fef29-6667-9200-178b-4d0e9fc63c12-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
2020-03-06 19:09 ` Heiko Stübner [this message]
2020-03-06 19:09 ` Heiko Stübner
2020-03-06 19:09 ` Heiko Stübner
[not found] ` <20200304213023.689983-2-t.schramm-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org>
2020-03-06 0:22 ` [PATCH v4 1/2] dt-bindings: Add doc for Pine64 " Heiko Stuebner
2020-03-06 0:22 ` Heiko Stuebner
2020-03-06 0:22 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1783248.GgDFSgCcj8@diego \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=aballier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org \
--cc=andy.yan-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
--cc=jbx6244-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=katsuhiro-WKCMddiH/C4xsqv6Oivclw@public.gmane.org \
--cc=kever.yang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org \
--cc=manu-h+KGxgPPiopAfugRpC6u6w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mka-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=nick-XW3xCAIBE2TQT0dZR+AlfA@public.gmane.org \
--cc=npcomplete13-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=t.schramm-x9ov/VOV9nNAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.