All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: ixp4xx: Drop the reg-offset hack
@ 2026-07-24  7:50 Linus Walleij
  2026-07-24 16:40 ` patchwork-bot+linux-soc
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2026-07-24  7:50 UTC (permalink / raw)
  To: soc, Arnd Bergmann, Krzysztof Kozlowski, Alexandre Belloni,
	Drew Fustini, linux-arm-kernel
  Cc: Linus Walleij

The reg-offset hack only works when the IXP4xx platform is
running in big endian mode, and it is there to byte-offset
the byte where the serial registers appear in the BE config.

This is clearly wrong, workarounds need to be in the
drivers. Drop the reg-offset.

Signed-off-by: Linus Walleij <linusw@kernel.org>
---
SoC folks: please apply this directly for DTS for v7.3.
The prerequisite patch to serial is already merged by Greg.
---
 arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi b/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi
index 0adeccabd4fe..b0f98da8def4 100644
--- a/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi
+++ b/arch/arm/boot/dts/intel/ixp/intel-ixp4xx.dtsi
@@ -84,11 +84,6 @@ pci@c0000000 {
 		uart0: serial@c8000000 {
 			compatible = "intel,xscale-uart";
 			reg = <0xc8000000 0x1000>;
-			/*
-			 * The reg-offset and reg-shift is a side effect
-			 * of running the platform in big endian mode.
-			 */
-			reg-offset = <3>;
 			reg-shift = <2>;
 			interrupts = <15 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <14745600>;
@@ -98,11 +93,6 @@ uart0: serial@c8000000 {
 		uart1: serial@c8001000 {
 			compatible = "intel,xscale-uart";
 			reg = <0xc8001000 0x1000>;
-			/*
-			 * The reg-offset and reg-shift is a side effect
-			 * of running the platform in big endian mode.
-			 */
-			reg-offset = <3>;
 			reg-shift = <2>;
 			interrupts = <13 IRQ_TYPE_LEVEL_HIGH>;
 			clock-frequency = <14745600>;

---
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
change-id: 20260724-ixp4xx-dts-fix-8ebb1198cffd

Best regards,
--  
Linus Walleij <linusw@kernel.org>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: ixp4xx: Drop the reg-offset hack
  2026-07-24  7:50 [PATCH] ARM: dts: ixp4xx: Drop the reg-offset hack Linus Walleij
@ 2026-07-24 16:40 ` patchwork-bot+linux-soc
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+linux-soc @ 2026-07-24 16:40 UTC (permalink / raw)
  To: Linus Walleij; +Cc: soc

Hello:

This patch was applied to soc/soc.git (for-next)
by Arnd Bergmann <arnd@arndb.de>:

On Fri, 24 Jul 2026 09:50:04 +0200 you wrote:
> The reg-offset hack only works when the IXP4xx platform is
> running in big endian mode, and it is there to byte-offset
> the byte where the serial registers appear in the BE config.
> 
> This is clearly wrong, workarounds need to be in the
> drivers. Drop the reg-offset.
> 
> [...]

Here is the summary with links:
  - ARM: dts: ixp4xx: Drop the reg-offset hack
    https://git.kernel.org/soc/soc/c/8a78168e98a9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-07-24 16:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-24  7:50 [PATCH] ARM: dts: ixp4xx: Drop the reg-offset hack Linus Walleij
2026-07-24 16:40 ` patchwork-bot+linux-soc

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.