From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Andrea Gelmini <andrea.gelmini-PT7Us6ch6G9eoWH0uzbU5w@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 0114/1529] Fix typo
Date: Sat, 21 May 2016 14:14:27 +0200 [thread overview]
Message-ID: <1785036.RoNATgRSre@phil> (raw)
In-Reply-To: <20160521115109.5318-1-andrea.gelmini-PT7Us6ch6G9eoWH0uzbU5w@public.gmane.org>
Hi Andrea,
Am Samstag, 21. Mai 2016, 13:51:09 schrieb Andrea Gelmini:
> Signed-off-by: Andrea Gelmini <andrea.gelmini-PT7Us6ch6G9eoWH0uzbU5w@public.gmane.org>
A series of 1529 patches? That's a bit extreme.
Also in future please use a sane subject line and additionally see comment
below making the patch not valid.
> ---
> arch/arm/mach-rockchip/pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c
> index bee8c80..309d672 100644
> --- a/arch/arm/mach-rockchip/pm.c
> +++ b/arch/arm/mach-rockchip/pm.c
> @@ -280,7 +280,7 @@ static int rk3288_suspend_init(struct device_node *np)
>
> rk3288_config_bootdata();
>
> - /* copy resume code and data to bootsram */
> + /* copy resume code and data to bootram */
this is _not_ a typo, it is sram not regular ram
> memcpy(rk3288_bootram_base, rockchip_slp_cpu_resume,
> rk3288_bootram_sz);
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stuebner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0114/1529] Fix typo
Date: Sat, 21 May 2016 14:14:27 +0200 [thread overview]
Message-ID: <1785036.RoNATgRSre@phil> (raw)
In-Reply-To: <20160521115109.5318-1-andrea.gelmini@gelma.net>
Hi Andrea,
Am Samstag, 21. Mai 2016, 13:51:09 schrieb Andrea Gelmini:
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
A series of 1529 patches? That's a bit extreme.
Also in future please use a sane subject line and additionally see comment
below making the patch not valid.
> ---
> arch/arm/mach-rockchip/pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-rockchip/pm.c b/arch/arm/mach-rockchip/pm.c
> index bee8c80..309d672 100644
> --- a/arch/arm/mach-rockchip/pm.c
> +++ b/arch/arm/mach-rockchip/pm.c
> @@ -280,7 +280,7 @@ static int rk3288_suspend_init(struct device_node *np)
>
> rk3288_config_bootdata();
>
> - /* copy resume code and data to bootsram */
> + /* copy resume code and data to bootram */
this is _not_ a typo, it is sram not regular ram
> memcpy(rk3288_bootram_base, rockchip_slp_cpu_resume,
> rk3288_bootram_sz);
next prev parent reply other threads:[~2016-05-21 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-21 11:51 [PATCH 0114/1529] Fix typo Andrea Gelmini
2016-05-21 11:51 ` Andrea Gelmini
[not found] ` <20160521115109.5318-1-andrea.gelmini-PT7Us6ch6G9eoWH0uzbU5w@public.gmane.org>
2016-05-21 12:14 ` Heiko Stuebner [this message]
2016-05-21 12:14 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1785036.RoNATgRSre@phil \
--to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
--cc=andrea.gelmini-PT7Us6ch6G9eoWH0uzbU5w@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=trivial-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.