[PATCH net v2] net: hisilicon: hix5hd2_gmac: remove redundant NAPI delete

[PATCH net v2] net: hisilicon: hix5hd2_gmac: remove redundant NAPI delete

[Jiawen Liu]

hix5hd2_dev_remove() calls netif_napi_del() before unregister_netdev().
This is not needed because unregister_netdev() deletes all NAPI instances
attached to the net_device.

Remove the redundant call and let the networking core tear down the NAPI
instance during unregister_netdev(). The probe error path still keeps its
explicit netif_napi_del(), because the device has not been registered
there.

Fixes: 57c5bc9ad7d7 ("net: hisilicon: add hix5hd2 mac driver")
Signed-off-by: Jiawen Liu <1298662399@qq.com>
---
 drivers/net/ethernet/hisilicon/hix5hd2_gmac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
index e3e7f2270560..02282dc86faf 100644
--- a/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
+++ b/drivers/net/ethernet/hisilicon/hix5hd2_gmac.c
@@ -1282,7 +1282,6 @@ static void hix5hd2_dev_remove(struct platform_device *pdev)
 	struct net_device *ndev = platform_get_drvdata(pdev);
 	struct hix5hd2_priv *priv = netdev_priv(ndev);
 
-	netif_napi_del(&priv->napi);
 	unregister_netdev(ndev);
 	mdiobus_unregister(priv->bus);
 	mdiobus_free(priv->bus);
-- 
2.34.1

Re: [PATCH net v2] net: hisilicon: hix5hd2_gmac: remove redundant NAPI delete

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 28 Jul 2026 12:17:10 +0400 you wrote:
> hix5hd2_dev_remove() calls netif_napi_del() before unregister_netdev().
> This is not needed because unregister_netdev() deletes all NAPI instances
> attached to the net_device.
> 
> Remove the redundant call and let the networking core tear down the NAPI
> instance during unregister_netdev(). The probe error path still keeps its
> explicit netif_napi_del(), because the device has not been registered
> there.
> 
> [...]

Here is the summary with links:
  - [net,v2] net: hisilicon: hix5hd2_gmac: remove redundant NAPI delete
    https://git.kernel.org/netdev/net/c/f307a7dc3209

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html