* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2015-11-05 21:25 Michael Chan
2015-11-05 21:35 ` David Miller
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2015-11-05 21:25 UTC (permalink / raw)
To: davem; +Cc: netdev
Miscellaneous small bug fixes.
Michael Chan (5):
bnxt_en: Change sp events definitions to represent bit position.
bnxt_en: Determine tcp/ipv6 RSS hash type correctly.
bnxt_en: map CAG_REG_LEGACY_INT_STATUS_MASK to GRC window #4
bnxt_en: Fix comparison of u16 sw_id against negative value.
bnxt_en: More robust SRIOV cleanup sequence.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++++++++++++-----
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 26 +++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 40 +++++++++++++++++--------
3 files changed, 64 insertions(+), 30 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2015-11-05 21:25 Michael Chan
@ 2015-11-05 21:35 ` David Miller
0 siblings, 0 replies; 31+ messages in thread
From: David Miller @ 2015-11-05 21:35 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: Michael Chan <mchan@broadcom.com>
Date: Thu, 5 Nov 2015 16:25:46 -0500
> Miscellaneous small bug fixes.
This looks fine, series applied, thanks.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2016-02-10 22:33 Michael Chan
2016-02-16 20:51 ` David Miller
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2016-02-10 22:33 UTC (permalink / raw)
To: davem; +Cc: netdev
Fixed autoneg logic and some related cleanups, fixed tx push operation,
and reduced default ring sizes.
Michael Chan (5):
bnxt_en: Fix ethtool autoneg logic.
bnxt_en: Cleanup and Fix flow control setup logic
bnxt_en: Remove 20G support and advertise only 40GbaseCR4.
bnxt_en: Fix implementation of tx push operation.
bnxt_en: Reduce default ring sizes.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 62 ++++++++++++-----------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++--
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 46 +++++------------
3 files changed, 56 insertions(+), 67 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2016-02-10 22:33 Michael Chan
@ 2016-02-16 20:51 ` David Miller
0 siblings, 0 replies; 31+ messages in thread
From: David Miller @ 2016-02-16 20:51 UTC (permalink / raw)
To: mchan; +Cc: netdev
From: Michael Chan <mchan@broadcom.com>
Date: Wed, 10 Feb 2016 17:33:45 -0500
> Fixed autoneg logic and some related cleanups, fixed tx push operation,
> and reduced default ring sizes.
Series applied, thanks Michael.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2019-06-29 15:16 Michael Chan
2019-06-30 23:01 ` David Miller
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2019-06-29 15:16 UTC (permalink / raw)
To: davem; +Cc: netdev
Miscellaneous bug fix patches, including two resource handling fixes for
the RDMA driver, a PCI shutdown patch to add pci_disable_device(), a patch
to fix ethtool selftest crash, and the last one suppresses an unnecessry
error message.
Please also queue patches 1, 2, and 3 for -stable. Thanks.
Michael Chan (5):
bnxt_en: Disable bus master during PCI shutdown and driver unload.
bnxt_en: Fix ethtool selftest crash under error conditions.
bnxt_en: Fix statistics context reservation logic for RDMA driver.
bnxt_en: Cap the returned MSIX vectors to the RDMA driver.
bnxt_en: Suppress error messages when querying DSCP DCB capabilities.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++---
drivers/net/ethernet/broadcom/bnxt/bnxt_ulp.c | 4 +++-
4 files changed, 20 insertions(+), 12 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2019-06-29 15:16 Michael Chan
@ 2019-06-30 23:01 ` David Miller
0 siblings, 0 replies; 31+ messages in thread
From: David Miller @ 2019-06-30 23:01 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sat, 29 Jun 2019 11:16:43 -0400
> Miscellaneous bug fix patches, including two resource handling fixes for
> the RDMA driver, a PCI shutdown patch to add pci_disable_device(), a patch
> to fix ethtool selftest crash, and the last one suppresses an unnecessry
> error message.
Series applied.
> Please also queue patches 1, 2, and 3 for -stable. Thanks.
Queued up.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2019-10-21 5:34 Michael Chan
2019-10-22 20:29 ` Jakub Kicinski
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2019-10-21 5:34 UTC (permalink / raw)
To: davem; +Cc: netdev, vasundhara-v.volam
Devlink and error recovery bug fix patches. Most of the work is by
Vasundhara Volam. Please queue patch 1 and 2 for -stable also. Thanks.
Michael Chan (1):
bnxt_en: Fix devlink NVRAM related byte order related issues.
Vasundhara Volam (4):
bnxt_en: Fix the size of devlink MSIX parameters.
bnxt_en: Adjust the time to wait before polling firmware readiness.
bnxt_en: Minor formatting changes in FW devlink_health_reporter
bnxt_en: Avoid disabling pci device in bnxt_remove_one() for already
disabled device.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 10 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 112 +++++++++++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 3 +-
3 files changed, 73 insertions(+), 52 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2019-10-21 5:34 Michael Chan
@ 2019-10-22 20:29 ` Jakub Kicinski
0 siblings, 0 replies; 31+ messages in thread
From: Jakub Kicinski @ 2019-10-22 20:29 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, vasundhara-v.volam
On Mon, 21 Oct 2019 01:34:24 -0400, Michael Chan wrote:
> Devlink and error recovery bug fix patches. Most of the work is by
> Vasundhara Volam.
Thanks, applied.
> Please queue patch 1 and 2 for -stable also. Thanks.
FWIW these will likely only reach 5.3 since it looks like the bug dates
to 5.1 but 5.1 and 5.2 branches of stable are already EOL.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-03-22 20:40 Michael Chan
2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
0 siblings, 2 replies; 31+ messages in thread
From: Michael Chan @ 2020-03-22 20:40 UTC (permalink / raw)
To: davem; +Cc: netdev
5 bug fix patches covering an indexing bug for priority counters, memory
leak when retrieving DCB ETS settings, error path return code, proper
disabling of PCI before freeing context memory, and proper ring accounting
in error path.
Please also apply these to -stable. Thanks.
Edwin Peer (1):
bnxt_en: fix memory leaks in bnxt_dcbnl_ieee_getets()
Michael Chan (3):
bnxt_en: Fix Priority Bytes and Packets counters in ethtool -S.
bnxt_en: Return error if bnxt_alloc_ctx_mem() fails.
bnxt_en: Free context memory after disabling PCI in probe error path.
Vasundhara Volam (1):
bnxt_en: Reset rings if ring reservation fails during open()
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 28 ++++++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 15 ++++++++----
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 8 +++----
4 files changed, 35 insertions(+), 18 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-03-22 20:40 Michael Chan
@ 2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
1 sibling, 0 replies; 31+ messages in thread
From: Jakub Kicinski @ 2020-03-23 17:27 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev
On Sun, 22 Mar 2020 16:40:00 -0400 Michael Chan wrote:
> 5 bug fix patches covering an indexing bug for priority counters, memory
> leak when retrieving DCB ETS settings, error path return code, proper
> disabling of PCI before freeing context memory, and proper ring accounting
> in error path.
>
> Please also apply these to -stable. Thanks.
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-03-22 20:40 Michael Chan
2020-03-23 17:27 ` Jakub Kicinski
@ 2020-03-24 4:43 ` David Miller
1 sibling, 0 replies; 31+ messages in thread
From: David Miller @ 2020-03-24 4:43 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 22 Mar 2020 16:40:00 -0400
> 5 bug fix patches covering an indexing bug for priority counters, memory
> leak when retrieving DCB ETS settings, error path return code, proper
> disabling of PCI before freeing context memory, and proper ring accounting
> in error path.
Series applied.
> Please also apply these to -stable. Thanks.
Queued up, thanks.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-04-26 20:24 Michael Chan
2020-04-27 18:45 ` David Miller
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2020-04-26 20:24 UTC (permalink / raw)
To: davem; +Cc: netdev
A collection of 5 miscellaneous bug fixes covering VF anti-spoof setup
issues, devlink MSIX max value, AER, context memory allocation error
path, and VLAN acceleration logic.
Please queue for -stable. Thanks.
Michael Chan (4):
bnxt_en: Fix VF anti-spoof filter setup.
bnxt_en: Improve AER slot reset.
bnxt_en: Return error when allocating zero size context memory.
bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features().
Vasundhara Volam (1):
bnxt_en: Reduce BNXT_MSIX_VEC_MAX value to supported CQs per PF.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 20 +++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 -
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.h | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c | 10 ++--------
4 files changed, 16 insertions(+), 17 deletions(-)
--
2.5.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-04-26 20:24 Michael Chan
@ 2020-04-27 18:45 ` David Miller
0 siblings, 0 replies; 31+ messages in thread
From: David Miller @ 2020-04-27 18:45 UTC (permalink / raw)
To: michael.chan; +Cc: netdev
From: Michael Chan <michael.chan@broadcom.com>
Date: Sun, 26 Apr 2020 16:24:37 -0400
> A collection of 5 miscellaneous bug fixes covering VF anti-spoof setup
> issues, devlink MSIX max value, AER, context memory allocation error
> path, and VLAN acceleration logic.
>
> Please queue for -stable. Thanks.
Applied and queued up for -stable, thanks.
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes.
@ 2020-10-26 4:18 Michael Chan
2020-10-27 1:36 ` Jakub Kicinski
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2020-10-26 4:18 UTC (permalink / raw)
To: kuba; +Cc: netdev, gospo
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
These 5 bug fixes are all related to the firmware reset or AER recovery.
2 patches fix the cleanup logic for the workqueue used to handle firmware
reset and recovery. 1 patch ensures that the chip will have the proper
BAR addresses latched after fatal AER recovery. 1 patch fixes the
open path to check for firmware reset abort error. The last one
sends the fw reset command unconditionally to fix the AER reset logic.
Please queue these for -stable as well. Thanks.
Michael Chan (1):
bnxt_en: Check abort error state in bnxt_open_nic().
Vasundhara Volam (4):
bnxt_en: Fix regression in workqueue cleanup logic in
bnxt_remove_one().
bnxt_en: Invoke cancel_delayed_work_sync() for PFs also.
bnxt_en: Re-write PCI BARs after PCI fatal error.
bnxt_en: Send HWRM_FUNC_RESET fw command unconditionally.
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 49 ++++++++++++++---------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 32 insertions(+), 18 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4166 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes.
2020-10-26 4:18 Michael Chan
@ 2020-10-27 1:36 ` Jakub Kicinski
0 siblings, 0 replies; 31+ messages in thread
From: Jakub Kicinski @ 2020-10-27 1:36 UTC (permalink / raw)
To: Michael Chan; +Cc: netdev, gospo
On Mon, 26 Oct 2020 00:18:16 -0400 Michael Chan wrote:
> These 5 bug fixes are all related to the firmware reset or AER recovery.
> 2 patches fix the cleanup logic for the workqueue used to handle firmware
> reset and recovery. 1 patch ensures that the chip will have the proper
> BAR addresses latched after fatal AER recovery. 1 patch fixes the
> open path to check for firmware reset abort error. The last one
> sends the fw reset command unconditionally to fix the AER reset logic.
>
> Please queue these for -stable as well. Thanks.
Applied, thanks!
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2021-09-05 18:10 Michael Chan
2021-09-05 19:50 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2021-09-05 18:10 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edwin.peer, gospo
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
This series includes 3 fixes related to devlink firmware and chip
versions. The other 2 patches fix a UDP tunneling issue and an
error recovery issue.
Edwin Peer (2):
bnxt_en: fix stored FW_PSID version masks
bnxt_en: fix read of stored FW_PSID version on P5 devices
Michael Chan (3):
bnxt_en: Fix asic.rev in devlink dev info command
bnxt_en: Fix UDP tunnel logic
bnxt_en: Fix possible unintended driver initiated error recovery
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 53 ++++++++++++-------
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 51 ++++++++++++------
.../net/ethernet/broadcom/bnxt/bnxt_devlink.h | 4 +-
3 files changed, 72 insertions(+), 36 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2021-09-05 18:10 Michael Chan
@ 2021-09-05 19:50 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 31+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-09-05 19:50 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edwin.peer, gospo
Hello:
This series was applied to netdev/net.git (refs/heads/master):
On Sun, 5 Sep 2021 14:10:54 -0400 you wrote:
> This series includes 3 fixes related to devlink firmware and chip
> versions. The other 2 patches fix a UDP tunneling issue and an
> error recovery issue.
>
> Edwin Peer (2):
> bnxt_en: fix stored FW_PSID version masks
> bnxt_en: fix read of stored FW_PSID version on P5 devices
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix stored FW_PSID version masks
https://git.kernel.org/netdev/net/c/1656db67233e
- [net,2/5] bnxt_en: fix read of stored FW_PSID version on P5 devices
https://git.kernel.org/netdev/net/c/beb55fcf950f
- [net,3/5] bnxt_en: Fix asic.rev in devlink dev info command
https://git.kernel.org/netdev/net/c/6fdab8a3ade2
- [net,4/5] bnxt_en: Fix UDP tunnel logic
https://git.kernel.org/netdev/net/c/7ae9dc356f24
- [net,5/5] bnxt_en: Fix possible unintended driver initiated error recovery
https://git.kernel.org/netdev/net/c/1b2b91831983
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2022-12-27 3:19 Michael Chan
2022-12-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2022-12-27 3:19 UTC (permalink / raw)
To: davem; +Cc: netdev, kuba, edumazet, pabeni, bpf, gospo
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
This series fixes a devlink bug and several XDP related bugs. The
devlink bug causes a kernel crash on VF devices. The XDP driver
patches fix and clean up the RX XDP path and re-enable header-data
split that was disabled by mistake when adding the XDP multi-buffer
support.
Michael Chan (4):
bnxt_en: Simplify bnxt_xdp_buff_init()
bnxt_en: Fix XDP RX path
bnxt_en: Fix first buffer size calculations for XDP multi-buffer
bnxt_en: Fix HDS and jumbo thresholds for RX packets
Vikas Gupta (1):
bnxt_en: fix devlink port registration to netdev
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 27 +++++++++++--------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 15 ++++++++---
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 20 +++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 6 ++---
4 files changed, 39 insertions(+), 29 deletions(-)
--
2.18.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2022-12-27 3:19 Michael Chan
@ 2022-12-28 10:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 31+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-12-28 10:20 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, kuba, edumazet, pabeni, bpf, gospo
Hello:
This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Mon, 26 Dec 2022 22:19:35 -0500 you wrote:
> This series fixes a devlink bug and several XDP related bugs. The
> devlink bug causes a kernel crash on VF devices. The XDP driver
> patches fix and clean up the RX XDP path and re-enable header-data
> split that was disabled by mistake when adding the XDP multi-buffer
> support.
>
> Michael Chan (4):
> bnxt_en: Simplify bnxt_xdp_buff_init()
> bnxt_en: Fix XDP RX path
> bnxt_en: Fix first buffer size calculations for XDP multi-buffer
> bnxt_en: Fix HDS and jumbo thresholds for RX packets
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: fix devlink port registration to netdev
https://git.kernel.org/netdev/net/c/0020ae2a4aa8
- [net,2/5] bnxt_en: Simplify bnxt_xdp_buff_init()
https://git.kernel.org/netdev/net/c/bbfc17e50ba2
- [net,3/5] bnxt_en: Fix XDP RX path
https://git.kernel.org/netdev/net/c/9b3e607871ea
- [net,4/5] bnxt_en: Fix first buffer size calculations for XDP multi-buffer
https://git.kernel.org/netdev/net/c/1abeacc1979f
- [net,5/5] bnxt_en: Fix HDS and jumbo thresholds for RX packets
https://git.kernel.org/netdev/net/c/a056ebcc30e2
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2024-01-17 23:45 Michael Chan
2024-01-19 2:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2024-01-17 23:45 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, kuba, pabeni, andrew.gospodarek
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
This series contains 5 miscellaneous fixes. The fixes include adding
delay for FLR, buffer memory leak, RSS table size calculation,
ethtool self test kernel warning, and mqprio crash.
Michael Chan (5):
bnxt_en: Wait for FLR to complete during probe
bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
bnxt_en: Prevent kernel warning when running offline self test
bnxt_en: Fix possible crash after creating sw mqprio TCs
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 49 +++++++++++++------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +-
.../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 7 +--
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 2 +-
5 files changed, 42 insertions(+), 19 deletions(-)
--
2.30.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2024-01-17 23:45 Michael Chan
@ 2024-01-19 2:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 31+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-19 2:10 UTC (permalink / raw)
To: Michael Chan; +Cc: davem, netdev, edumazet, kuba, pabeni, andrew.gospodarek
Hello:
This series was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Wed, 17 Jan 2024 15:45:10 -0800 you wrote:
> This series contains 5 miscellaneous fixes. The fixes include adding
> delay for FLR, buffer memory leak, RSS table size calculation,
> ethtool self test kernel warning, and mqprio crash.
>
> Michael Chan (5):
> bnxt_en: Wait for FLR to complete during probe
> bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
> bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
> bnxt_en: Prevent kernel warning when running offline self test
> bnxt_en: Fix possible crash after creating sw mqprio TCs
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: Wait for FLR to complete during probe
https://git.kernel.org/netdev/net/c/e6602b3c07d8
- [net,2/5] bnxt_en: Fix memory leak in bnxt_hwrm_get_rings()
https://git.kernel.org/netdev/net/c/a261fd41f44f
- [net,3/5] bnxt_en: Fix RSS table entries calculation for P5_PLUS chips
https://git.kernel.org/netdev/net/c/602801d18667
- [net,4/5] bnxt_en: Prevent kernel warning when running offline self test
https://git.kernel.org/netdev/net/c/7d544a01450e
- [net,5/5] bnxt_en: Fix possible crash after creating sw mqprio TCs
https://git.kernel.org/netdev/net/c/bb89cf26f515
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2025-11-04 0:56 Michael Chan
2025-11-05 1:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 31+ messages in thread
From: Michael Chan @ 2025-11-04 0:56 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
andrew.gospodarek
Patches 1, 3, and 4 are bug fixes related to the FW log tracing driver
coredump feature recently added in 6.13. Patch #1 adds the necessary
call to shutdown the FW logging DMA during PCI shutdown. Patch #3 fixes
a possible null pointer derefernce when using early versions of the FW
with this feature. Patch #4 adds the coredump header information
unconditionally to make it more robust.
Patch #2 fixes a possible memory leak during PTP shutdown. Patch #5
eliminates a dmesg warning when doing devlink reload.
Gautam R A (1):
bnxt_en: Fix null pointer dereference in bnxt_bs_trace_check_wrap()
Kalesh AP (1):
bnxt_en: Fix a possible memory leak in bnxt_ptp_init
Kashyap Desai (1):
bnxt_en: Always provide max entry and entry size in coredump segments
Michael Chan (1):
bnxt_en: Shutdown FW DMA in bnxt_shutdown()
Shantiprasad Shettar (1):
bnxt_en: Fix warning in bnxt_dl_reload_down()
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 6 +++++-
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 3 ++-
drivers/net/ethernet/broadcom/bnxt/bnxt_coredump.c | 5 +++--
drivers/net/ethernet/broadcom/bnxt/bnxt_devlink.c | 2 +-
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 4 ++--
5 files changed, 13 insertions(+), 7 deletions(-)
--
2.51.0
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2025-11-04 0:56 Michael Chan
@ 2025-11-05 1:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 31+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-11-05 1:30 UTC (permalink / raw)
To: Michael Chan
Cc: davem, netdev, edumazet, kuba, pabeni, andrew+netdev,
pavan.chebbi, andrew.gospodarek
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 3 Nov 2025 16:56:54 -0800 you wrote:
> Patches 1, 3, and 4 are bug fixes related to the FW log tracing driver
> coredump feature recently added in 6.13. Patch #1 adds the necessary
> call to shutdown the FW logging DMA during PCI shutdown. Patch #3 fixes
> a possible null pointer derefernce when using early versions of the FW
> with this feature. Patch #4 adds the coredump header information
> unconditionally to make it more robust.
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: Shutdown FW DMA in bnxt_shutdown()
https://git.kernel.org/netdev/net/c/bc7208ca805a
- [net,2/5] bnxt_en: Fix a possible memory leak in bnxt_ptp_init
https://git.kernel.org/netdev/net/c/deb8eb391643
- [net,3/5] bnxt_en: Fix null pointer dereference in bnxt_bs_trace_check_wrap()
https://git.kernel.org/netdev/net/c/ff02be05f783
- [net,4/5] bnxt_en: Always provide max entry and entry size in coredump segments
https://git.kernel.org/netdev/net/c/28d9a84ef0ce
- [net,5/5] bnxt_en: Fix warning in bnxt_dl_reload_down()
https://git.kernel.org/netdev/net/c/5204943a4c6e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 0/5] bnxt_en: Bug fixes
@ 2026-07-31 19:09 Michael Chan
2026-07-31 19:09 ` [PATCH net 1/5] bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss() Michael Chan
` (6 more replies)
0 siblings, 7 replies; 31+ messages in thread
From: Michael Chan @ 2026-07-31 19:09 UTC (permalink / raw)
To: davem; +Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi
This series include 3 bug fixes:
1. queue start bug fix on the VNIC's default ring. 2 refactoring
patches preceed the actual bug fix.
2. Bug fix for TPA data corruption seen on some ARM systems.
3. PTP PPS setting bug fix.
Keegan Freyhof (1):
bnxt_en: Fix PTP PPS setting bug
Michael Chan (1):
bnxt_en: Disable EOP for TPA on all chips to prevent data corruption
Shravya KN (3):
bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss()
bnxt_en: Determine and store default RX ring in vnic structure
bnxt_en: Refresh VNIC default ring on queue restart if needed
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 61 ++++++++++++-------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 7 ++-
3 files changed, 46 insertions(+), 23 deletions(-)
--
2.51.0
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCH net 1/5] bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss()
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
@ 2026-07-31 19:09 ` Michael Chan
2026-07-31 19:09 ` [PATCH net 2/5] bnxt_en: Determine and store default RX ring in vnic structure Michael Chan
` (5 subsequent siblings)
6 siblings, 0 replies; 31+ messages in thread
From: Michael Chan @ 2026-07-31 19:09 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
Shravya KN, Kalesh AP
From: Shravya KN <shravya.k-n@broadcom.com>
This is a refactor patch with no change in behavior. The caller
will now fill the RSS table before calling __bnxt_hwrm_vnic_set_rss().
In the next patch, we'll add code to determine the default ring for
the VNIC when we fill the RSS table.
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Shravya KN <shravya.k-n@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 7513618793da..48f4e38ad78d 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6706,6 +6706,9 @@ static void bnxt_fill_hw_rss_tbl(struct bnxt *bp, struct bnxt_vnic_info *vnic)
bool no_rss = !(vnic->flags & BNXT_VNIC_RSS_FLAG);
u16 i, j;
+ if (!vnic->rss_table)
+ return;
+
/* Fill the RSS indirection table with ring group ids */
for (i = 0, j = 0; i < HW_HASH_INDEX_SIZE; i++) {
if (!no_rss)
@@ -6745,13 +6748,8 @@ static void
__bnxt_hwrm_vnic_set_rss(struct bnxt *bp, struct hwrm_vnic_rss_cfg_input *req,
struct bnxt_vnic_info *vnic)
{
- if (bp->flags & BNXT_FLAG_CHIP_P5_PLUS) {
- bnxt_fill_hw_rss_tbl_p5(bp, vnic);
- if (bp->flags & BNXT_FLAG_CHIP_P7)
- req->flags |= VNIC_RSS_CFG_REQ_FLAGS_IPSEC_HASH_TYPE_CFG_SUPPORT;
- } else {
- bnxt_fill_hw_rss_tbl(bp, vnic);
- }
+ if (bp->flags & BNXT_FLAG_CHIP_P7)
+ req->flags |= VNIC_RSS_CFG_REQ_FLAGS_IPSEC_HASH_TYPE_CFG_SUPPORT;
if (bp->rss_hash_delta) {
req->hash_type = cpu_to_le32(bp->rss_hash_delta);
@@ -6803,6 +6801,7 @@ static int bnxt_hwrm_vnic_set_rss_p5(struct bnxt *bp,
if (!set_rss)
return hwrm_req_send(bp, req);
+ bnxt_fill_hw_rss_tbl_p5(bp, vnic);
__bnxt_hwrm_vnic_set_rss(bp, req, vnic);
ring_tbl_map = vnic->rss_table_dma_addr;
nr_ctxs = bnxt_get_nr_rss_ctxs(bp, bp->rx_nr_rings);
@@ -10866,6 +10865,7 @@ static int __bnxt_setup_vnic(struct bnxt *bp, struct bnxt_vnic_info *vnic)
}
skip_rss_ctx:
+ bnxt_fill_hw_rss_tbl(bp, vnic);
/* configure default vnic, ring grp */
rc = bnxt_hwrm_vnic_cfg(bp, vnic);
if (rc) {
--
2.51.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH net 2/5] bnxt_en: Determine and store default RX ring in vnic structure
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2026-07-31 19:09 ` [PATCH net 1/5] bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss() Michael Chan
@ 2026-07-31 19:09 ` Michael Chan
2026-07-31 19:09 ` [PATCH net 3/5] bnxt_en: Refresh VNIC default ring on queue restart if needed Michael Chan
` (4 subsequent siblings)
6 siblings, 0 replies; 31+ messages in thread
From: Michael Chan @ 2026-07-31 19:09 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
Shravya KN, Kalesh AP
From: Shravya KN <shravya.k-n@broadcom.com>
Each VNIC has a default RX ring. The purpose of the default RX ring
is to provide a destination for any packets that cannot be parsed by
the RSS logic. Up until now, the default RX ring is always Ring 0.
We neglected to take care of this default RX ring when adding the
queue restart feature. If ring 0 (default ring) is re-started, it
may now have a new FW ring ID after freeing the old one and
allocating a new one. The VNIC now may have a stale default ring
and it may generate an internal exception. This exception may
appear in dmesg:
FW reported unknown error type 10
The best way to resolve this issue is to use a more appropriate
ring for the default ring instead of always ring 0. Ring 0 may not
even be in the RSS table, especially on a new RSS context.
This patch adds the logic to determine and store the proper default
RX ring for a VNIC. For an RSS VNIC, the default ring is the lowest
ring number in the RSS table. The next patch will add proper logic
to update the VNIC if the default ring changes after queue restart.
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Shravya KN <shravya.k-n@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 33 +++++++++++++++--------
drivers/net/ethernet/broadcom/bnxt/bnxt.h | 1 +
2 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 48f4e38ad78d..ff098d959741 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -6704,25 +6704,36 @@ int bnxt_get_nr_rss_ctxs(struct bnxt *bp, int rx_rings)
static void bnxt_fill_hw_rss_tbl(struct bnxt *bp, struct bnxt_vnic_info *vnic)
{
bool no_rss = !(vnic->flags & BNXT_VNIC_RSS_FLAG);
- u16 i, j;
+ u16 i, j, min_j = bp->rx_nr_rings - 1;
if (!vnic->rss_table)
- return;
+ goto skip_rss_tbl;
/* Fill the RSS indirection table with ring group ids */
for (i = 0, j = 0; i < HW_HASH_INDEX_SIZE; i++) {
if (!no_rss)
j = bp->rss_indir_tbl[i];
+ min_j = min(j, min_j);
vnic->rss_table[i] = cpu_to_le16(vnic->fw_grp_ids[j]);
}
+
+skip_rss_tbl:
+ if (vnic->rss_table && !no_rss)
+ vnic->default_rx_ring = min_j;
+ else if (vnic->flags & BNXT_VNIC_RFS_FLAG)
+ vnic->default_rx_ring = vnic->vnic_id - 1;
+ else if ((vnic->vnic_id == 1) && BNXT_CHIP_TYPE_NITRO_A0(bp))
+ vnic->default_rx_ring = bp->rx_nr_rings - 1;
+ else
+ vnic->default_rx_ring = 0;
}
static void bnxt_fill_hw_rss_tbl_p5(struct bnxt *bp,
struct bnxt_vnic_info *vnic)
{
+ u16 tbl_size, i, min_j = bp->rx_nr_rings - 1;
__le16 *ring_tbl = vnic->rss_table;
struct bnxt_rx_ring_info *rxr;
- u16 tbl_size, i;
tbl_size = bnxt_get_rxfh_indir_size(bp->dev);
@@ -6735,6 +6746,7 @@ static void bnxt_fill_hw_rss_tbl_p5(struct bnxt *bp,
j = ethtool_rxfh_context_indir(vnic->rss_ctx)[i];
else
j = bp->rss_indir_tbl[i];
+ min_j = min(j, min_j);
rxr = &bp->rx_ring[j];
ring_id = rxr->rx_ring_struct.fw_ring_id;
@@ -6742,6 +6754,7 @@ static void bnxt_fill_hw_rss_tbl_p5(struct bnxt *bp,
ring_id = bnxt_cp_ring_for_rx(bp, rxr);
*ring_tbl++ = cpu_to_le16(ring_id);
}
+ vnic->default_rx_ring = min_j;
}
static void
@@ -6938,8 +6951,9 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic)
return rc;
if (bp->flags & BNXT_FLAG_CHIP_P5_PLUS) {
- struct bnxt_rx_ring_info *rxr = &bp->rx_ring[0];
+ struct bnxt_rx_ring_info *rxr;
+ rxr = &bp->rx_ring[vnic->default_rx_ring];
req->default_rx_ring_id =
cpu_to_le16(rxr->rx_ring_struct.fw_ring_id);
req->default_cmpl_ring_id =
@@ -6972,13 +6986,7 @@ int bnxt_hwrm_vnic_cfg(struct bnxt *bp, struct bnxt_vnic_info *vnic)
req->cos_rule = cpu_to_le16(0xffff);
}
- if (vnic->flags & BNXT_VNIC_RSS_FLAG)
- ring = 0;
- else if (vnic->flags & BNXT_VNIC_RFS_FLAG)
- ring = vnic->vnic_id - 1;
- else if ((vnic->vnic_id == 1) && BNXT_CHIP_TYPE_NITRO_A0(bp))
- ring = bp->rx_nr_rings - 1;
-
+ ring = vnic->default_rx_ring;
grp_idx = bp->rx_ring[ring].bnapi->index;
req->dflt_ring_grp = cpu_to_le16(bp->grp_info[grp_idx].fw_grp_id);
req->lb_rule = cpu_to_le16(0xffff);
@@ -11171,6 +11179,9 @@ static int bnxt_setup_nitroa0_vnic(struct bnxt *bp)
return rc;
}
+ /* Setup the proper default RX ring */
+ bnxt_fill_hw_rss_tbl(bp, vnic);
+
rc = bnxt_hwrm_vnic_cfg(bp, vnic);
if (rc) {
netdev_err(bp->dev, "Cannot allocate special vnic for NS2 A0: %x\n",
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
index 6335dfc14c98..44ea8fc7b766 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
@@ -1334,6 +1334,7 @@ struct bnxt_vnic_info {
#define BNXT_VNIC_RSSCTX_FLAG 0x40
struct ethtool_rxfh_context *rss_ctx;
u32 vnic_id;
+ u16 default_rx_ring;
};
struct bnxt_rss_ctx {
--
2.51.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH net 3/5] bnxt_en: Refresh VNIC default ring on queue restart if needed
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2026-07-31 19:09 ` [PATCH net 1/5] bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss() Michael Chan
2026-07-31 19:09 ` [PATCH net 2/5] bnxt_en: Determine and store default RX ring in vnic structure Michael Chan
@ 2026-07-31 19:09 ` Michael Chan
2026-07-31 19:09 ` [PATCH net 4/5] bnxt_en: Disable EOP for TPA on all chips to prevent data corruption Michael Chan
` (3 subsequent siblings)
6 siblings, 0 replies; 31+ messages in thread
From: Michael Chan @ 2026-07-31 19:09 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
Shravya KN, Kalesh AP
From: Shravya KN <shravya.k-n@broadcom.com>
When a queue is restarted, refresh VNIC_CFG for all VNICs whose
default RX ring is the restarted ring. This will eliminate this
possible FW warning caused by a stale default ring in the VNIC:
FW reported unknown error type 10
Fixes: 5ac066b7b062 ("bnxt_en: Fix queue start to update vnic RSS table")
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Shravya KN <shravya.k-n@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index ff098d959741..97cae19643c3 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -11098,6 +11098,11 @@ static int bnxt_set_vnic_mru_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic,
vnic->vnic_id, rc);
return rc;
}
+ if (rxr_id == vnic->default_rx_ring) {
+ rc = bnxt_hwrm_vnic_cfg(bp, vnic);
+ if (rc)
+ return rc;
+ }
}
vnic->mru = mru;
bnxt_hwrm_vnic_update(bp, vnic,
--
2.51.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH net 4/5] bnxt_en: Disable EOP for TPA on all chips to prevent data corruption
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (2 preceding siblings ...)
2026-07-31 19:09 ` [PATCH net 3/5] bnxt_en: Refresh VNIC default ring on queue restart if needed Michael Chan
@ 2026-07-31 19:09 ` Michael Chan
2026-07-31 19:09 ` [PATCH net 5/5] bnxt_en: Fix PTP PPS setting bug Michael Chan
` (2 subsequent siblings)
6 siblings, 0 replies; 31+ messages in thread
From: Michael Chan @ 2026-07-31 19:09 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
Kalesh AP
EOP (End of frame padding) on the AGG ring may cause overlapping of
zero padding at the end of one segment with the next segment's data.
If Relaxed Ordering (RO) is enabled, the zero padding may overwrite
valid data in the next segment and corrupt the data. Older chips
(P5 and older) do not automatically disable RO when EOP is enabled.
On some ARM systems, data corruption was reported on 57508 (P5)
chips with RO enabled.
Always disable EOP on all chips on the AGG rings when TPA is enabled
to fix the data corruption.
Fixes: bfcd8d791ec1 ("bnxt_en: Add fast path logic for TPA on 57500 chips.")
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 97cae19643c3..a0ea8c994b32 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4611,11 +4611,14 @@ static void bnxt_init_one_rx_agg_ring_rxbd(struct bnxt *bp,
type = ((u32)rxr->rx_page_size << RX_BD_LEN_SHIFT) |
RX_BD_TYPE_RX_AGG_BD;
- /* On P7, setting EOP will cause the chip to disable
- * Relaxed Ordering (RO) for TPA data. Disable EOP for
- * potentially higher performance with RO.
+ /* Disable EOP if TPA is enabled to prevent overlapping zero
+ * padding with the next segment's data. On P7_PLUS, EOP will
+ * automatically disable Relaxed Ordering (RO) to prevent
+ * potential data corruption (and may degrade performance). On
+ * older chips, RO will not be automatically disabled and may
+ * cause corruption.
*/
- if (BNXT_CHIP_P5_AND_MINUS(bp) || !(bp->flags & BNXT_FLAG_TPA))
+ if (!(bp->flags & BNXT_FLAG_TPA))
type |= RX_BD_FLAGS_AGG_EOP;
bnxt_init_rxbd_pages(ring, type);
--
2.51.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCH net 5/5] bnxt_en: Fix PTP PPS setting bug
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (3 preceding siblings ...)
2026-07-31 19:09 ` [PATCH net 4/5] bnxt_en: Disable EOP for TPA on all chips to prevent data corruption Michael Chan
@ 2026-07-31 19:09 ` Michael Chan
2026-08-05 3:00 ` [PATCH net 0/5] bnxt_en: Bug fixes patchwork-bot+netdevbpf
2026-08-05 3:04 ` Jakub Kicinski
6 siblings, 0 replies; 31+ messages in thread
From: Michael Chan @ 2026-07-31 19:09 UTC (permalink / raw)
To: davem
Cc: netdev, edumazet, kuba, pabeni, andrew+netdev, pavan.chebbi,
Keegan Freyhof
From: Keegan Freyhof <keegan.freyhof@broadcom.com>
The existing driver logic is always turning on PTP_CLK_REQ_PPS
regardless of the "on" parameter passed to bnxt_ptp_enable().
During shutdown, PTP_CLK_REQ_PPS may be turned off and this
bug will do the opposite and may trigger a PCIe PTM request TLP.
On some systems this can trigger a PCIe AER.
Fix it by properly configuring PTP_CLK_REQ_PPS based on the "on"
parameter.
Fixes: 9e518f25802c ("bnxt_en: 1PPS functions to configure TSIO pins")
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Signed-off-by: Keegan Freyhof <keegan.freyhof@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
index 5d41dc1bc782..b89293dfd2d1 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c
@@ -495,12 +495,15 @@ static int bnxt_ptp_enable(struct ptp_clock_info *ptp_info,
return rc;
case PTP_CLK_REQ_PPS:
/* Configure PHC PPS IN */
- rc = bnxt_ptp_cfg_pin(bp, 0, BNXT_PPS_PIN_PPS_IN);
+ pin_id = 0;
+ if (!on)
+ break;
+ rc = bnxt_ptp_cfg_pin(bp, pin_id, BNXT_PPS_PIN_PPS_IN);
if (rc)
return rc;
rc = bnxt_ptp_cfg_event(bp, BNXT_PPS_EVENT_INTERNAL);
if (!rc)
- ptp->pps_info.pins[0].event = BNXT_PPS_EVENT_INTERNAL;
+ ptp->pps_info.pins[pin_id].event = BNXT_PPS_EVENT_INTERNAL;
return rc;
default:
netdev_err(ptp->bp->dev, "Unrecognized PIN function\n");
--
2.51.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (4 preceding siblings ...)
2026-07-31 19:09 ` [PATCH net 5/5] bnxt_en: Fix PTP PPS setting bug Michael Chan
@ 2026-08-05 3:00 ` patchwork-bot+netdevbpf
2026-08-05 3:04 ` Jakub Kicinski
6 siblings, 0 replies; 31+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-08-05 3:00 UTC (permalink / raw)
To: Michael Chan
Cc: davem, netdev, edumazet, kuba, pabeni, andrew+netdev,
pavan.chebbi
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 31 Jul 2026 12:09:32 -0700 you wrote:
> This series include 3 bug fixes:
>
> 1. queue start bug fix on the VNIC's default ring. 2 refactoring
> patches preceed the actual bug fix.
> 2. Bug fix for TPA data corruption seen on some ARM systems.
> 3. PTP PPS setting bug fix.
>
> [...]
Here is the summary with links:
- [net,1/5] bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss()
https://git.kernel.org/netdev/net/c/1d0fc6c7ea49
- [net,2/5] bnxt_en: Determine and store default RX ring in vnic structure
https://git.kernel.org/netdev/net/c/53f01cd594e2
- [net,3/5] bnxt_en: Refresh VNIC default ring on queue restart if needed
https://git.kernel.org/netdev/net/c/0b137529a899
- [net,4/5] bnxt_en: Disable EOP for TPA on all chips to prevent data corruption
https://git.kernel.org/netdev/net/c/c3faf548a00f
- [net,5/5] bnxt_en: Fix PTP PPS setting bug
https://git.kernel.org/netdev/net/c/80eaf88efec3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH net 0/5] bnxt_en: Bug fixes
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
` (5 preceding siblings ...)
2026-08-05 3:00 ` [PATCH net 0/5] bnxt_en: Bug fixes patchwork-bot+netdevbpf
@ 2026-08-05 3:04 ` Jakub Kicinski
6 siblings, 0 replies; 31+ messages in thread
From: Jakub Kicinski @ 2026-08-05 3:04 UTC (permalink / raw)
To: Michael Chan, Vikas Gupta
Cc: davem, netdev, edumazet, pabeni, andrew+netdev, pavan.chebbi
On Fri, 31 Jul 2026 12:09:32 -0700 Michael Chan wrote:
> This series include 3 bug fixes:
>
> 1. queue start bug fix on the VNIC's default ring. 2 refactoring
> patches preceed the actual bug fix.
> 2. Bug fix for TPA data corruption seen on some ARM systems.
> 3. PTP PPS setting bug fix.
Just to avoid any further misunderstandings - you can have 15
outstanding patches per tree, so 15 for net and 15 for net-next.
There can be multiple series for each tree, as long as they don't
conflict.
^ permalink raw reply [flat|nested] 31+ messages in thread
end of thread, other threads:[~2026-08-05 3:04 UTC | newest]
Thread overview: 31+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-31 19:09 [PATCH net 0/5] bnxt_en: Bug fixes Michael Chan
2026-07-31 19:09 ` [PATCH net 1/5] bnxt_en: Move RSS table fill outside __bnxt_hwrm_vnic_set_rss() Michael Chan
2026-07-31 19:09 ` [PATCH net 2/5] bnxt_en: Determine and store default RX ring in vnic structure Michael Chan
2026-07-31 19:09 ` [PATCH net 3/5] bnxt_en: Refresh VNIC default ring on queue restart if needed Michael Chan
2026-07-31 19:09 ` [PATCH net 4/5] bnxt_en: Disable EOP for TPA on all chips to prevent data corruption Michael Chan
2026-07-31 19:09 ` [PATCH net 5/5] bnxt_en: Fix PTP PPS setting bug Michael Chan
2026-08-05 3:00 ` [PATCH net 0/5] bnxt_en: Bug fixes patchwork-bot+netdevbpf
2026-08-05 3:04 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2025-11-04 0:56 Michael Chan
2025-11-05 1:30 ` patchwork-bot+netdevbpf
2024-01-17 23:45 Michael Chan
2024-01-19 2:10 ` patchwork-bot+netdevbpf
2022-12-27 3:19 Michael Chan
2022-12-28 10:20 ` patchwork-bot+netdevbpf
2021-09-05 18:10 Michael Chan
2021-09-05 19:50 ` patchwork-bot+netdevbpf
2020-10-26 4:18 Michael Chan
2020-10-27 1:36 ` Jakub Kicinski
2020-04-26 20:24 Michael Chan
2020-04-27 18:45 ` David Miller
2020-03-22 20:40 Michael Chan
2020-03-23 17:27 ` Jakub Kicinski
2020-03-24 4:43 ` David Miller
2019-10-21 5:34 Michael Chan
2019-10-22 20:29 ` Jakub Kicinski
2019-06-29 15:16 Michael Chan
2019-06-30 23:01 ` David Miller
2016-02-10 22:33 Michael Chan
2016-02-16 20:51 ` David Miller
2015-11-05 21:25 Michael Chan
2015-11-05 21:35 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.