Re: [PATCH] i40e: fix shared code compile warning

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-06-24 14:43, Ananyev, Konstantin:
> Yes, it is much nicer to fix it in i40e_lan_hmc.c.
> But I don't really want us to open that door.
> So my vote would be to initial Mark's patch: add '-Wno-error' in the
> Makefile.
 
2014-06-24 15:25, Zhang, Helin:
> We should not modify code in shared code, if we do not want to maintain
> those huge code base. I think Mark's patch good for now, we can report that
> issue to shared code maintainers, and try to get them to fix it later.

2014-06-25 05:36, Chen, Jing D:
> my committed patch to ignore the warning on that file and continue the
> compile .  By doing so, the logic is right and  didn't change code's
> behavior.  We also needn't maintain it.  Even in bad case we find bugs
> hidden behind the '--CFLAGS_i40e_lan_hmc.0' warning in future, we can fix
> it after bug occurred. That's simple.

Applied for version 1.7.0.

Thanks
-- 
Thomas