All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Chen Jing D(Mark)"
	<jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] i40e: fix shared code compile warning
Date: Tue, 24 Jun 2014 10:46:50 +0200	[thread overview]
Message-ID: <2859281.xMAtdAgJn8@xps13> (raw)
In-Reply-To: <1403587377-10287-1-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

Hi,

2014-06-24 13:22, Chen Jing D:
> Fix a compile warning in shared code on 32-bits RHEL6.3/6.5.
> 
> Signed-off-by: Chen Jing D(Mark) <jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

In such case you should show the error message in the log.
	lib/librte_pmd_i40e/i40e/i40e_lan_hmc.c:917:
	error: integer constant is too large for ‘long’ type

> --- a/lib/librte_pmd_i40e/Makefile
> +++ b/lib/librte_pmd_i40e/Makefile
> @@ -52,6 +52,7 @@ CFLAGS_SHARED_DRIVERS += -Wno-missing-field-initializers
>  CFLAGS_SHARED_DRIVERS += -Wno-pointer-to-int-cast
>  CFLAGS_SHARED_DRIVERS += -Wno-format-nonliteral
>  CFLAGS_SHARED_DRIVERS += -Wno-format-security
> +CFLAGS_i40e_lan_hmc.o += -Wno-error

I know we shouldn't modify base drivers. But this one seems to be an important 
error. In such case, we already modified base driver. Recently:
	http://dpdk.org/ml/archives/dev/2014-June/003498.html

-- 
Thomas

  parent reply	other threads:[~2014-06-24  8:46 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-24  5:22 [PATCH] i40e: fix shared code compile warning Chen Jing D(Mark)
     [not found] ` <1403587377-10287-1-git-send-email-jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-24  8:46   ` Thomas Monjalon [this message]
2014-06-24  9:47     ` Chen, Jing D
     [not found]       ` <4341B239C0EFF9468EE453F9E9F4604D01595D45-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-24 10:06         ` Thomas Monjalon
2014-06-24 14:43           ` Ananyev, Konstantin
     [not found]             ` <2601191342CEEE43887BDE71AB97725821333FA3-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-24 15:25               ` Zhang, Helin
     [not found]                 ` <F35DEAC7BCE34641BA9FAC6BCA4A12E70A746859-0J0gbvR4kTg/UvCtAeCM4rfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-26 12:22                   ` Thomas Monjalon
2014-06-25  5:36           ` Chen, Jing D

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2859281.xMAtdAgJn8@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=jing.d.chen-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.